Skip to content

Commit bfba460

Browse files
GonalsGonals
authored
Merge pull request Expensify#86694 from Expensify/claude-addGranularCompanySizeBrackets
[Payment due @eVoloshchak] Add 1-4 and 5-10 company sizes to onboarding flow
2 parents 4de2675 + 2195e15 commit bfba460

16 files changed

Lines changed: 60 additions & 25 deletions

File tree

‎src/CONST/index.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,12 @@ const onboardingInviteTypes = {
148148
} as const;
149149

150150
const onboardingCompanySize = {
151+
MICRO_SMALL: '1-4',
152+
MICRO_MEDIUM: '5-10',
153+
154+
// This range is deprecated in favor of the smaller ranges above, but the constant is kept to compare against saved data for backwards compatibility.
151155
MICRO: '1-10',
156+
152157
SMALL: '11-50',
153158
MEDIUM_SMALL: '51-100',
154159
MEDIUM: '101-1000',

‎src/components/SidePanel/RHPVariantTest/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ const shouldOpenRHPVariant: ShouldOpenRHPVariant = (variantOverride) => {
4242
return true;
4343
}
4444

45-
const isMicroCompany = onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO;
45+
const isMicroCompany = onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL || onboardingCompanySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO;
4646
const isRHPConciergeDM = variant === CONST.ONBOARDING_RHP_VARIANT.RHP_CONCIERGE_DM;
4747
const isRHPAdminsRoom = variant === CONST.ONBOARDING_RHP_VARIANT.RHP_ADMINS_ROOM;
4848
const isRHPHomePage = variant === CONST.ONBOARDING_RHP_VARIANT.RHP_HOME_PAGE;

‎src/languages/de.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2918,7 +2918,9 @@ ${amount} für ${merchant} – ${date}`,
29182918
},
29192919
employees: {
29202920
title: 'Wie viele Mitarbeitende haben Sie?',
2921-
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 Beschäftigte',
2921+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 Mitarbeitende',
2922+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 Mitarbeitende',
2923+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 Mitarbeitende',
29222924
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 Mitarbeitende',
29232925
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 Mitarbeitende',
29242926
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 Mitarbeitende',

‎src/languages/en.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2970,6 +2970,8 @@ const translations = {
29702970
},
29712971
employees: {
29722972
title: 'How many employees do you have?',
2973+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 employees',
2974+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 employees',
29732975
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 employees',
29742976
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 employees',
29752977
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 employees',

‎src/languages/es.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2788,6 +2788,8 @@ ${amount} para ${merchant} - ${date}`,
27882788
},
27892789
employees: {
27902790
title: '¿Cuántos empleados tienes?',
2791+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 empleados',
2792+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 empleados',
27912793
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 empleados',
27922794
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 empleados',
27932795
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 empleados',

‎src/languages/fr.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2924,6 +2924,8 @@ ${amount} pour ${merchant} - ${date}`,
29242924
},
29252925
employees: {
29262926
title: 'Combien d’employés avez-vous ?',
2927+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1 à 4 employés',
2928+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5 à 10 employés',
29272929
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1 à 10 employés',
29282930
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11 à 50 employés',
29292931
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51 à 100 employés',

‎src/languages/it.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2911,10 +2911,12 @@ ${amount} per ${merchant} - ${date}`,
29112911
},
29122912
employees: {
29132913
title: 'Quanti dipendenti hai?',
2914+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 dipendenti',
2915+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 dipendenti',
29142916
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 dipendenti',
29152917
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 dipendenti',
29162918
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 dipendenti',
2917-
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1.000 dipendenti',
2919+
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: 'Da 101 a 1.000 dipendenti',
29182920
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Più di 1.000 dipendenti',
29192921
},
29202922
accounting: {

‎src/languages/ja.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2885,11 +2885,13 @@ ${date} の ${merchant} への ${amount}`,
28852885
},
28862886
employees: {
28872887
title: '従業員は何人いますか？',
2888+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1～4名の従業員',
2889+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5～10人の従業員',
28882890
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '従業員数 1～10 人',
2889-
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '従業員数 11～50 人',
2890-
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '従業員数 51～100 人',
2891+
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11～50名の従業員',
2892+
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51～100人の従業員',
28912893
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101～1,000人の従業員',
2892-
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '1,000人を超える従業員',
2894+
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: '1,000人超の従業員',
28932895
},
28942896
accounting: {
28952897
title: '会計ソフトを利用していますか？',

‎src/languages/nl.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2909,11 +2909,13 @@ ${amount} voor ${merchant} - ${date}`,
29092909
[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: 'Iets anders',
29102910
},
29112911
employees: {
2912-
title: 'Hoeveel werknemers heb je?',
2913-
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 werknemers',
2912+
title: 'Hoeveel medewerkers heb je?',
2913+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1-4 medewerkers',
2914+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5-10 medewerkers',
2915+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1-10 medewerkers',
29142916
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11-50 medewerkers',
2915-
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 werknemers',
2916-
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101–1.000 werknemers',
2917+
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51-100 medewerkers',
2918+
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM]: '101-1.000 werknemers',
29172919
[CONST.ONBOARDING_COMPANY_SIZE.LARGE]: 'Meer dan 1.000 medewerkers',
29182920
},
29192921
accounting: {

‎src/languages/pl.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2902,6 +2902,8 @@ ${amount} dla ${merchant} - ${date}`,
29022902
},
29032903
employees: {
29042904
title: 'Ilu masz pracowników?',
2905+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_SMALL]: '1–4 pracowników',
2906+
[CONST.ONBOARDING_COMPANY_SIZE.MICRO_MEDIUM]: '5–10 pracowników',
29052907
[CONST.ONBOARDING_COMPANY_SIZE.MICRO]: '1–10 pracowników',
29062908
[CONST.ONBOARDING_COMPANY_SIZE.SMALL]: '11–50 pracowników',
29072909
[CONST.ONBOARDING_COMPANY_SIZE.MEDIUM_SMALL]: '51–100 pracowników',

0 commit comments

Comments
 (0)