Skip to content

Commit bfc6781

Browse files
authored
Merge pull request Expensify#79754 from daledah/fix/76909-2
[noQA] Change the accessibility label in workflow section
2 parents a48722a + e16cb44 commit bfc6781

11 files changed

Lines changed: 14 additions & 2 deletions

File tree

src/components/ApprovalWorkflowSection.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,15 @@ function ApprovalWorkflowSection({approvalWorkflow, onPress, currency = CONST.CU
4848
: sortAlphabetically(approvalWorkflow.members, 'displayName', localeCompare)
4949
.map((m) => Str.removeSMSDomain(m.displayName))
5050
.join(', ');
51-
5251
return (
5352
<PressableWithoutFeedback
5453
accessibilityRole="button"
5554
style={[styles.border, shouldUseNarrowLayout ? styles.p3 : styles.p4, styles.flexRow, styles.justifyContentBetween, styles.mt6, styles.mbn3]}
5655
onPress={onPress}
57-
accessibilityLabel={translate('workflowsPage.addApprovalsTitle')}
56+
accessibilityLabel={translate('workflowsPage.accessibilityLabel', {
57+
members,
58+
approvers: approvalWorkflow?.approvers.map((approver) => Str.removeSMSDomain(approver?.displayName ?? '')).join(', '),
59+
})}
5860
>
5961
<View style={[styles.flex1]}>
6062
{approvalWorkflow.isDefault && (

src/languages/de.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2325,6 +2325,7 @@ ${amount} für ${merchant} – ${date}`,
23252325
expensesFromSubtitle: 'Alle Arbeitsbereichsmitglieder gehören bereits zu einem bestehenden Genehmigungsworkflow.',
23262326
approverSubtitle: 'Alle Genehmigenden gehören zu einem bestehenden Workflow.',
23272327
},
2328+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `Ausgaben von ${members}, und der Genehmigende ist ${approvers}`,
23282329
},
23292330
workflowsDelayedSubmissionPage: {
23302331
autoReportingFrequencyErrorMessage: 'Die Einreichungshäufigkeit konnte nicht geändert werden. Bitte versuchen Sie es erneut oder kontaktieren Sie den Support.',

src/languages/en.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2300,6 +2300,7 @@ const translations = {
23002300
submissionFrequencyDateOfMonth: 'Date of month',
23012301
disableApprovalPromptDescription: 'Disabling approvals will erase all existing approval workflows.',
23022302
addApprovalsTitle: 'Approvals',
2303+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `expenses from ${members}, and the approver is ${approvers}`,
23032304
addApprovalButton: 'Add approval workflow',
23042305
addApprovalTip: 'This default workflow applies to all members, unless a more specific workflow exists.',
23052306
approver: 'Approver',

src/languages/es.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2029,6 +2029,7 @@ ${amount} para ${merchant} - ${date}`,
20292029
disableApprovalPromptDescription: 'Deshabilitar las aprobaciones borrará todos los flujos de trabajo de aprobación existentes.',
20302030
submissionFrequencyDateOfMonth: 'Fecha del mes',
20312031
addApprovalsTitle: 'Aprobaciones',
2032+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `gastos de ${members}, y el aprobador es ${approvers}`,
20322033
addApprovalButton: 'Añadir flujo de aprobación',
20332034
addApprovalTip: 'Este flujo de trabajo por defecto se aplica a todos los miembros, a menos que exista un flujo de trabajo más específico.',
20342035
approver: 'Aprobador',

src/languages/fr.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2329,6 +2329,7 @@ ${amount} pour ${merchant} - ${date}`,
23292329
expensesFromSubtitle: 'Tous les membres de l’espace de travail appartiennent déjà à un flux d’approbation existant.',
23302330
approverSubtitle: 'Tous les approbateurs appartiennent à un workflow existant.',
23312331
},
2332+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `dépenses de ${members}, et l’approbateur est ${approvers}`,
23322333
},
23332334
workflowsDelayedSubmissionPage: {
23342335
autoReportingFrequencyErrorMessage: 'La fréquence d’envoi n’a pas pu être modifiée. Veuillez réessayer ou contacter l’assistance.',

src/languages/it.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2320,6 +2320,7 @@ ${amount} per ${merchant} - ${date}`,
23202320
expensesFromSubtitle: 'Tutti i membri dello spazio di lavoro appartengono già a un flusso di approvazione esistente.',
23212321
approverSubtitle: 'Tutti gli approvatori appartengono a un workflow esistente.',
23222322
},
2323+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `spese da ${members} e l’approvatore è ${approvers}`,
23232324
},
23242325
workflowsDelayedSubmissionPage: {
23252326
autoReportingFrequencyErrorMessage: "Impossibile modificare la frequenza di invio. Riprova o contatta l'assistenza.",

src/languages/ja.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2310,6 +2310,7 @@ ${merchant} への ${amount}(${date})`,
23102310
expensesFromSubtitle: 'すべてのワークスペースメンバーは、すでに既存の承認ワークフローに属しています。',
23112311
approverSubtitle: 'すべての承認者は既存のワークフローに属しています。',
23122312
},
2313+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `${members} からの経費で、承認者は ${approvers} です`,
23132314
},
23142315
workflowsDelayedSubmissionPage: {
23152316
autoReportingFrequencyErrorMessage: '送信頻度を変更できませんでした。もう一度お試しいただくか、サポートにお問い合わせください。',

src/languages/nl.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2319,6 +2319,7 @@ ${amount} voor ${merchant} - ${date}`,
23192319
expensesFromSubtitle: 'Alle werkruimteleden behoren al tot een bestaande goedkeuringsworkflow.',
23202320
approverSubtitle: 'Alle fiatteurs behoren tot een bestaande workflow.',
23212321
},
2322+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `uitgaven van ${members}, en de fiatteur is ${approvers}`,
23222323
},
23232324
workflowsDelayedSubmissionPage: {
23242325
autoReportingFrequencyErrorMessage: 'Indien frequentie van indienen niet kon worden gewijzigd. Probeer het opnieuw of neem contact op met support.',

src/languages/pl.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2314,6 +2314,7 @@ ${amount} dla ${merchant} - ${date}`,
23142314
expensesFromSubtitle: 'Wszyscy członkowie przestrzeni roboczej należą już do istniejącego obiegu zatwierdzania.',
23152315
approverSubtitle: 'Wszyscy zatwierdzający należą do istniejącego przepływu pracy.',
23162316
},
2317+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `wydatki od ${members}, a zatwierdzającym jest ${approvers}`, //_/\__/_/ \_,_/\__/\__/\_,_/
23172318
},
23182319
workflowsDelayedSubmissionPage: {
23192320
autoReportingFrequencyErrorMessage: 'Nie udało się zmienić częstotliwości wysyłania. Spróbuj ponownie lub skontaktuj się z pomocą techniczną.',

src/languages/pt-BR.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2312,6 +2312,7 @@ ${amount} para ${merchant} - ${date}`,
23122312
expensesFromSubtitle: 'Todos os membros do workspace já pertencem a um fluxo de aprovação existente.',
23132313
approverSubtitle: 'Todos os aprovadores pertencem a um fluxo de trabalho existente.',
23142314
},
2315+
accessibilityLabel: ({members, approvers}: {members: string; approvers: string}) => `despesas de ${members}, e o aprovador é ${approvers}`,
23152316
},
23162317
workflowsDelayedSubmissionPage: {
23172318
autoReportingFrequencyErrorMessage: 'A frequência de envio não pôde ser alterada. Tente novamente ou entre em contato com o suporte.',

0 commit comments

Comments
 (0)