Skip to content

Commit c0821dd

Browse files
committed
Pin react-native-onyx to perf branch HEAD (731fe957) for testing
Bumps react-native-onyx to elirangoshen/perf/mergeCollection-multiGet-prewarm HEAD (731fe957), which stacks on top of Expensify#787 (cache-first mergeCollectionWithPatches) and adds a cold-cache pre-warm optimization: - Fast path (every existingKey is in cache): skip pre-warm entirely. Preserves the original promise-chain depth so subscriber-callback timing is unchanged for warm-cache merges (the common case). - Slow path (any existingKey is a cache miss): use Storage.multiGet to batch the missing keys into a single storage round-trip, instead of N parallel Storage.getItem calls. Net runtime effect: same correctness, fewer storage operations on cold-cache merges, same broadcast timing for warm-cache merges. This branch also drops the now-obsolete `react-native-onyx+3.0.73.patch` (the canonical upstream revert it implemented landed in Onyx PR Expensify#785, which is already part of the pinned SHA). Not for merge -- branch is for performance verification only.
1 parent e08f2d0 commit c0821dd

4 files changed

Lines changed: 6 additions & 81 deletions

File tree

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
"react-native-localize": "^3.5.4",
180180
"react-native-nitro-modules": "0.35.0",
181181
"react-native-nitro-sqlite": "9.6.0",
182-
"react-native-onyx": "3.0.73",
182+
"react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#731fe95764798364c54797ed94df605a7b97c86d",
183183
"react-native-pager-view": "8.0.0",
184184
"react-native-pdf": "7.0.2",
185185
"react-native-permissions": "^5.4.0",
Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
11
# `react-native-onyx` patches
22

3-
### [react-native-onyx+3.0.73.patch](react-native-onyx+3.0.73.patch)
4-
5-
- Reason:
6-
7-
> Reverts [Onyx PR #770 (the subscription-side skip for skippable collection member ids in subscribeToKey)](https://github.com/Expensify/react-native-onyx/pull/770) and the line [PR #779](https://github.com/Expensify/react-native-onyx/pull/779) added to work around [PR #770](https://github.com/Expensify/react-native-onyx/pull/770)'s silent-no-callback contract.
8-
9-
- Upstream PR/issue: https://github.com/Expensify/react-native-onyx/pull/785
10-
- E/App issue: https://github.com/Expensify/App/issues/86181
11-
- PR Introducing Patch: https://github.com/Expensify/App/pull/90764
3+
_No active patches._

patches/react-native-onyx/react-native-onyx+3.0.73.patch

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)