Use hasAuthToken() dynamically instead of stale isAuthenticated closure

The isAuthenticated parameter is captured at call time in
openReportFromDeepLink and never updates after login. When a user deep
links while logged out, isAuthenticated stays false in the closure even
after waitForUserSignIn resolves, so the guard added in the previous
commit always evaluated to false and handleDeeplinkNavigation was never
called.

Switch to hasAuthToken() which reads the current auth state dynamically,
fixing the deep-link-then-login flow while still preventing premature
navigation before authentication.

Co-authored-by: mkhutornyi <mkhutornyi@users.noreply.github.com>

Author: MelvinBot

src/libs/actions/Link.ts

@@ -32,7 +32,7 @@ import SCREENS from '@src/SCREENS';
 import {hasCompletedGuidedSetupFlowSelector} from '@src/selectors/Onboarding';
 import type {Beta, IntroSelected, Report} from '@src/types/onyx';
 import {doneCheckingPublicRoom, navigateToConciergeChat, openReport} from './Report';
-import {canAnonymousUserAccessRoute, isAnonymousUser, signOutAndRedirectToSignIn, waitForUserSignIn} from './Session';
+import {canAnonymousUserAccessRoute, hasAuthToken, isAnonymousUser, signOutAndRedirectToSignIn, waitForUserSignIn} from './Session';
 import {setOnboardingErrorMessage} from './Welcome';
 
 let currentUserEmail = '';
@@ -364,10 +364,11 @@ function openReportFromDeepLink(
                             }
                         };
 
-                        // We must check isAuthenticated before hasCompletedGuidedSetupFlowSelector because the selector
-                        // returns true for empty onboarding objects (the pre-login default state), which would cause
-                        // premature deeplink navigation before authentication completes.
-                        if ((isAuthenticated && hasCompletedGuidedSetupFlowSelector(val)) || isAnonymousUser()) {
+                        // We must check hasAuthToken() dynamically (not the stale `isAuthenticated` closure value)
+                        // before hasCompletedGuidedSetupFlowSelector because the selector returns true for empty
+                        // onboarding objects (the pre-login default state), which would cause premature deeplink
+                        // navigation before authentication completes.
+                        if ((hasAuthToken() && hasCompletedGuidedSetupFlowSelector(val)) || isAnonymousUser()) {
                             handleDeeplinkNavigation();
                         }
                     });

tests/unit/OnboardingSelectorsTest.ts

@@ -8,18 +8,18 @@ describe('onboardingSelectors', () => {
     // the onboarding flow is only showed to the users with `hasCompletedGuidedSetupFlow` set to false
     describe('hasCompletedGuidedSetupFlowSelector', () => {
         // Regression test: hasCompletedGuidedSetupFlowSelector returns true for empty onboarding objects (the pre-login default state).
-        // The deeplink guard in Link.ts must combine this with an isAuthenticated check to prevent premature navigation.
-        it('Should return true for empty onboarding (pre-login default), confirming the need for an isAuthenticated guard in deeplink navigation', () => {
+        // The deeplink guard in Link.ts must combine this with a dynamic hasAuthToken() check to prevent premature navigation.
+        it('Should return true for empty onboarding (pre-login default), confirming the need for an auth guard in deeplink navigation', () => {
             const emptyOnboarding = {} as OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>;
-            const isAuthenticated = false;
+            const hasToken = false; // simulates hasAuthToken() returning false before login
             const selectorResult = hasCompletedGuidedSetupFlowSelector(emptyOnboarding);
 
             // The selector returns true for empty objects (old/migrated accounts), which is correct for its own purpose.
             expect(selectorResult).toBe(true);
 
-            // But the deeplink guard must NOT navigate when the user is not authenticated, even if the selector returns true.
-            // This is the condition from openReportFromDeepLink: (isAuthenticated && hasCompletedGuidedSetupFlowSelector(val))
-            expect(isAuthenticated && selectorResult).toBe(false);
+            // But the deeplink guard must NOT navigate when the user has no auth token, even if the selector returns true.
+            // This is the condition from openReportFromDeepLink: (hasAuthToken() && hasCompletedGuidedSetupFlowSelector(val))
+            expect(hasToken && selectorResult).toBe(false);
         });
 
         it('Should return true if onboarding NVP is an empty object', () => {