Skip to content

Commit c2ac449

Browse files
authored
Merge pull request Expensify#89349 from karan-1302/fix/expense-description-required-field
Fix expense description save when require
2 parents 9217218 + 521185d commit c2ac449

1 file changed

Lines changed: 1 addition & 21 deletions

File tree

src/pages/iou/request/step/IOURequestStepDescription.tsx

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,9 @@ import useLocalize from '@hooks/useLocalize';
1414
import useOnyx from '@hooks/useOnyx';
1515
import usePermissions from '@hooks/usePermissions';
1616
import usePolicy from '@hooks/usePolicy';
17-
import usePolicyForMovingExpenses from '@hooks/usePolicyForMovingExpenses';
1817
import useRestartOnReceiptFailure from '@hooks/useRestartOnReceiptFailure';
1918
import useShowNotFoundPageInIOUStep from '@hooks/useShowNotFoundPageInIOUStep';
2019
import useThemeStyles from '@hooks/useThemeStyles';
21-
import {isCategoryDescriptionRequired} from '@libs/CategoryUtils';
2220
import {addErrorMessage} from '@libs/ErrorUtils';
2321
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
2422
import {shouldUseTransactionDraft} from '@libs/IOUUtils';
@@ -89,20 +87,6 @@ function IOURequestStepDescription({
8987
const {isBetaEnabled} = usePermissions();
9088
const isASAPSubmitBetaEnabled = isBetaEnabled(CONST.BETAS.ASAP_SUBMIT);
9189

92-
const {policyForMovingExpensesID} = usePolicyForMovingExpenses();
93-
94-
const [transactionDraft] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${getNonEmptyStringOnyxID(transaction?.transactionID)}`);
95-
96-
const movingExpensesPolicy = usePolicy(policyForMovingExpensesID);
97-
const [movingExpensesPolicyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyForMovingExpensesID}`);
98-
99-
const isDescriptionRequired = useMemo(() => {
100-
const categoriesToUse = policyCategories ?? movingExpensesPolicyCategories;
101-
const policyToUse = policy ?? movingExpensesPolicy;
102-
103-
return isCategoryDescriptionRequired(categoriesToUse, transaction?.category ?? transactionDraft?.category, policyToUse?.areRulesEnabled);
104-
}, [policyCategories, movingExpensesPolicyCategories, transaction?.category, transactionDraft?.category, policy, movingExpensesPolicy]);
105-
10690
/**
10791
* @returns - An object containing the errors for each inputID
10892
*/
@@ -114,13 +98,9 @@ function IOURequestStepDescription({
11498
addErrorMessage(errors, 'moneyRequestComment', translate('common.error.characterLimitExceedCounter', values.moneyRequestComment.length, CONST.DESCRIPTION_LIMIT));
11599
}
116100

117-
if (isDescriptionRequired && !values.moneyRequestComment) {
118-
addErrorMessage(errors, INPUT_IDS.MONEY_REQUEST_COMMENT, translate('common.error.fieldRequired'));
119-
}
120-
121101
return errors;
122102
},
123-
[isDescriptionRequired, translate],
103+
[translate],
124104
);
125105

126106
const navigateBack = useCallback(() => {

0 commit comments

Comments
 (0)