Merge branch 'main' into fix/69130

Author: nkdengineer

.eslintrc.js

@@ -259,6 +259,11 @@ module.exports = {
                 selector: 'TSEnumDeclaration',
                 message: "Please don't declare enums, use union types instead.",
             },
+            {
+                selector: 'CallExpression[callee.name="getUrlWithBackToParam"]',
+                message:
+                    'Usage of getUrlWithBackToParam function is prohibited. This is legacy code and no new occurrences should be added. Please look into documentation and use alternative routing methods instead.',
+            },
 
             // These are the original rules from AirBnB's style guide, modified to allow for...of loops and for...in loops
             {

.github/CODEOWNERS

@@ -1,9 +1,6 @@
 # Every PR gets a review from an internal Expensify engineer
 * @Expensify/pullerbear
 
-# PRs that touch the front end source code, get an additional review from the product-pr team
-src/ @Expensify/product-pr @Expensify/pullerbear
-
 # PRs that touch the front end style or assets, get an additional review from the Design team
-src/styles/ @Expensify/design @Expensify/product-pr @Expensify/pullerbear
-assets/ @Expensify/design @Expensify/product-pr @Expensify/pullerbear
+src/styles/ @Expensify/design @Expensify/pullerbear
+assets/ @Expensify/design @Expensify/pullerbear

.github/workflows/reassurePerformanceTests.yml

@@ -40,6 +40,9 @@ jobs:
                 echo "Deleted file: $file"
               fi
             done
+      - name: Capture PR head SHA
+        if: ${{ github.event_name == 'pull_request' }}
+        run: echo "PR_SHA=${{ github.event.pull_request.head.sha }}" >> "$GITHUB_ENV"
 
       - name: Run performance testing script
         shell: bash
@@ -54,7 +57,7 @@ jobs:
           git add Mobile-Expensify
           npm install --force || (rm -rf node_modules && npm install --force) 
           NODE_OPTIONS=--experimental-vm-modules npx reassure --baseline
-          git switch --force --detach -
+          git switch --force --detach "${PR_SHA:-${GITHUB_SHA}}"
           cd Mobile-Expensify
           git checkout "$(git rev-parse HEAD)"
           cd ..

.github/workflows/remote-build-android.yml

@@ -2,6 +2,11 @@ name: Remote Build Android
 
 on:
   workflow_dispatch:
+    inputs:
+      mobile_expensify_pr:
+        description: 'Mobile-Expensify PR number to use for hybrid build'
+        required: false
+        type: string
   push:
     branches-ignore: [staging, production, cherry-pick-*]
     paths-ignore: ['docs/**', 'contributingGuides/**', 'help/**', '.github/**', 'scripts/**', 'tests/**']
@@ -35,6 +40,14 @@ jobs:
         with:
           IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}
 
+      - name: Checkout specific Mobile-Expensify PR
+        if: ${{ matrix.is_hybrid_build && github.event.inputs.mobile_expensify_pr }}
+        run: |
+          cd Mobile-Expensify
+          git fetch origin pull/${{ github.event.inputs.mobile_expensify_pr }}/head:pr-${{ github.event.inputs.mobile_expensify_pr }}
+          git checkout pr-${{ github.event.inputs.mobile_expensify_pr }}
+          echo "Checked out Mobile-Expensify PR #${{ github.event.inputs.mobile_expensify_pr }}"
+
       - name: RNEF Remote Build - Android
         # rnef v2
         uses: callstackincubator/android@d9a81f860e436ff2971323990244e32830dcabd1

.github/workflows/remote-build-ios.yml

@@ -2,6 +2,11 @@ name: Remote Build iOS
 
 on:
   workflow_dispatch:
+    inputs:
+      mobile_expensify_pr:
+        description: 'Mobile-Expensify PR number to use for hybrid build'
+        required: false
+        type: string
   push:
     branches-ignore: [staging, production, cherry-pick-*]
     paths-ignore: ['docs/**', 'contributingGuides/**', 'help/**', '.github/**', 'scripts/**', 'tests/**']
@@ -39,6 +44,14 @@ jobs:
         with:
           IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}
 
+      - name: Checkout specific Mobile-Expensify PR
+        if: ${{ matrix.is_hybrid_build && github.event.inputs.mobile_expensify_pr }}
+        run: |
+          cd Mobile-Expensify
+          git fetch origin pull/${{ github.event.inputs.mobile_expensify_pr }}/head:pr-${{ github.event.inputs.mobile_expensify_pr }}
+          git checkout pr-${{ github.event.inputs.mobile_expensify_pr }}
+          echo "Checked out Mobile-Expensify PR #${{ github.event.inputs.mobile_expensify_pr }}"
+
       - name: RNEF Remote Build - iOS
         # rnef v2
         uses: callstackincubator/ios@7847e0676242cefa801cba8ede6736140b7bae91 

Mobile-Expensify

@@ -114,8 +114,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009020109
-        versionName "9.2.1-9"
+        versionCode 1009020300
+        versionName "9.2.3-0"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"

android/app/build.gradle

@@ -36,7 +36,6 @@ class ShareActionHandlerModule(reactContext: ReactApplicationContext) :
             val shareObject = JSONObject(shareObjectString)
             val content = shareObject.optString("content")
             val mimeType = shareObject.optString("mimeType")
-            val fileUriPath = "file://$content"
             val timestamp = System.currentTimeMillis()
 
             val file = File(content)
@@ -53,6 +52,8 @@ class ShareActionHandlerModule(reactContext: ReactApplicationContext) :
 
             val identifier = file.name
             var aspectRatio = 0.0f
+            val fileUri = android.net.Uri.fromFile(file)
+            val fileUriPath = fileUri.toString()
 
             if (mimeType.startsWith("image/")) {
                 val options = BitmapFactory.Options().apply { inJustDecodeBounds = true }