Merge exfy/main

Author: adhorodyski

babel.config.js

@@ -130,6 +130,9 @@ const metro = {
         production: {
             plugins: [['transform-remove-console', {exclude: ['error', 'warn']}]],
         },
+        test: {
+            plugins: ['@babel/plugin-transform-dynamic-import'],
+        },
     },
 };
 

contributingGuides/PERFORMANCE.md

@@ -282,7 +282,7 @@ Since our codebase is very complex, it results in a large DOM tree rendered for
 
 One of the most common issues is related to modals, popovers, and tooltips — elements that may appear on the screen. The problem is that they are usually present in the DOM tree even when initially invisible. Because of this, the initial render time of a screen may increase, ultimately slowing down the app.
 
-The solution is better control of invisible elements, making sure they are not included in the first render. This can be done, e.g., by a simple `return null`, smart usage of `lazy loading`, the `useTransition` hook, or the `<Deferred />` component.
+The solution is better control of invisible elements, making sure they are not included in the first render. This can be done, e.g., by a simple `return null`, smart usage of `lazy loading`, the `useTransition` hook, or the [`<NavigationDeferredMount />`](/src/components/NavigationDeferredMount.tsx) component. `<NavigationDeferredMount />` gates a heavy subtree behind navigation transition completion via `TransitionTracker`, rendering a cheap `placeholder` until the nav animation has finished, then mounting its `children` inside `startTransition` — ideal for heavy subtrees (e.g. report headers, page-level secondary actions) mounted during navigation transitions that pull many `useOnyx` subscriptions or heavy hooks but don't need to be interactive on first render.
 
 Another issue worth mentioning is unnecessary code execution, especially for elements that are never shown on a specific platform. In theory, we separate the logic between platforms by using index.tsx/index.native.tsx files, but sometimes platform-specific logic may slip in, causing unnecessary execution. For example, this may happen when logic specific to a wide layout (applicable only for web) is included.
 
@@ -294,6 +294,7 @@ Examples:
 - [PopoverWithMeasuredContent optimization for mobile](https://github.com/Expensify/App/pull/68223) - returns early to avoid unnecessary calculations
 - [Reduce confirm modal initial render count](https://github.com/Expensify/App/pull/67518) - returns early to reduce first load cost
 - [Do not render PopoverMenu until it gets opened](https://github.com/Expensify/App/pull/67877) - adds a wrapper to control if `PopoverMenu` should be rendered
+- [Defer mount of MoneyReportHeaderSecondaryActions](https://github.com/Expensify/App/pull/88522) - introduces `NavigationDeferredMount` and uses it to defer the "More" dropdown subtree (20+ `useOnyx` subscriptions) until the navigation transition completes
 
 # Proposing Performance Improvements
 

contributingGuides/STYLE.md

@@ -571,9 +571,7 @@ When you change the function id argument type to allow `undefined`, check if it
 
 ```diff
 function MoneyRequestView({report, shouldShowAnimatedBackground, readonly = false, updatedTransaction, isFromReviewDuplicates = false}: MoneyRequestViewProps) {
-    const [parentReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`, {
-        canEvict: false,
-    });
+    const [parentReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`);
 -   const parentReportAction = parentReportActions?.[report?.parentReportActionID ?? '-1'];
 +   const parentReportAction = parentReportActions?.[report?.parentReportActionID];
 ```

contributingGuides/philosophies/ONYX-DATA-MANAGEMENT.md

@@ -35,17 +35,7 @@ Different platforms come with varying storage capacities and Onyx has a way to g
 
 **To flag a key as safe for removal:**
 - Add the key to the `evictableKeys` option in `Onyx.init(options)`
-- Implement `canEvict` in the Onyx config for each component subscribing to a key
-- The key will only be deleted when all subscribers return `true` for `canEvict`
-
-Example:
-```js
-Onyx.init({
-    evictableKeys: [ONYXKEYS.COLLECTION.REPORT_ACTIONS],
-});
-
-const [reportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {canEvict: !isActiveReport});
-```
+- A least recently accessed key will only be deleted when an Onyx operation retries after failing.
 
 ## Onyx Derived Values
 

docs/articles/travel/getting-started/Expensify-Travel-Walkthrough.md

@@ -963,6 +963,7 @@ https://help.expensify.com/articles/new-expensify/reports-and-expenses/Delete-Ex
 https://help.expensify.com/articles/new-expensify/reports-and-expenses/Duplicate-Detection,https://help.expensify.com/articles/new-expensify/reports-and-expenses/How-to-Find-and-Resolve-Flagged-Duplicate-Expenses
 https://help.expensify.com/articles/new-expensify/reports-and-expenses/Merging-expenses,https://help.expensify.com/articles/new-expensify/reports-and-expenses/How-to-Merge-Expenses
 https://help.expensify.com/articles/new-expensify/reports-and-expenses/How-to-prevent-duplicate-expenses,https://help.expensify.com/articles/new-expensify/reports-and-expenses/Why-Expenses-Duplicate
+https://help.expensify.com/articles/travel/getting-started/Expensify-Travel-Walkthrough,https://help.expensify.com/travel/hubs/getting-started/
 https://help.expensify.com/articles/new-expensify/connect-credit-cards/Assign-and-Manage-Cards,https://help.expensify.com/articles/new-expensify/connect-credit-cards/Assign-Company-Cards
 https://help.expensify.com/articles/new-expensify/connect-credit-cards/Commercial-feeds,https://help.expensify.com/articles/new-expensify/connect-credit-cards/Set-up-a-Commercial-Card-Feed-Connection
 https://help.expensify.com/articles/new-expensify/connect-credit-cards/Company-Card-Settings,https://help.expensify.com/articles/new-expensify/connect-credit-cards/Configure-Company-Card-Settings

docs/redirects.csv

@@ -404,7 +404,7 @@ PODS:
     - nanopb/encode (= 3.30910.0)
   - nanopb/decode (3.30910.0)
   - nanopb/encode (3.30910.0)
-  - NitroModules (0.29.4):
+  - NitroModules (0.35.0):
     - boost
     - DoubleConversion
     - fast_float
@@ -3793,7 +3793,7 @@ PODS:
     - SocketRocket
     - Turf
     - Yoga
-  - RNNitroSQLite (9.2.0):
+  - RNNitroSQLite (9.6.0):
     - boost
     - DoubleConversion
     - fast_float
@@ -4818,7 +4818,7 @@ SPEC CHECKSUMS:
   MapboxMaps: f87023cf0d72b180b40ea0b6fb4b2d7db6b73b71
   MapboxMobileEvents: d044b9edbe0ec7df60f6c2c9634fe9a7f449266b
   nanopb: fad817b59e0457d11a5dfbde799381cd727c1275
-  NitroModules: 8bffd214aa360baba0f2c5718fe0acff5ef94763
+  NitroModules: f8c2cc3025e4550aee15ff77c525622bf98e774a
   NWWebSocket: b4741420f1976e1dff4da3edad00c401e4f1d769
   Onfido: 65454f91d10758193c857fd149417f6efbea84c5
   onfido-react-native-sdk: bb8cfd9198e2e97978461d969497d18b37e45ca7
@@ -4930,7 +4930,7 @@ SPEC CHECKSUMS:
   RNLiveMarkdown: 589e31da57c2cb6d98b37ac68ae8b0b256247172
   RNLocalize: 05e367a873223683f0e268d0af9a8a8e6aed3b26
   rnmapbox-maps: 392ac61c42a9ff01a51d4c2f6775d9131b5951fb
-  RNNitroSQLite: fb251387cfbee73b100cd484a3c886fda681b3b5
+  RNNitroSQLite: a9b5965d511ed6e99ce903380e64934d043a0d2c
   RNPermissions: 518f0a0c439acc74e2b9937e0e7d29e5031ae949
   RNReactNativeHapticFeedback: 5f1542065f0b24c9252bd8cf3e83bc9c548182e4
   RNReanimated: fbcb7fd8da5b0b088401542c58fb5d266388f1cf

ios/Podfile.lock

@@ -1,9 +1,24 @@
 import '@testing-library/react-native';
+import type {KeyboardEventName} from 'react-native';
+import {Keyboard} from 'react-native';
 import Onyx from 'react-native-onyx';
 import ONYXKEYS from '@src/ONYXKEYS';
 
 jest.useRealTimers();
 
+// Patch Keyboard.addListener to return a subscription object with .remove() so that
+// @react-navigation/bottom-tabs useIsKeyboardShown hook doesn't crash on cleanup.
+if (Keyboard && typeof Keyboard.addListener === 'function') {
+    const originalAddListener = Keyboard.addListener.bind(Keyboard);
+    Keyboard.addListener = ((event: KeyboardEventName, callback: () => void) => {
+        const subscription = originalAddListener(event, callback);
+        if (!subscription || typeof subscription.remove !== 'function') {
+            return {remove: jest.fn()};
+        }
+        return subscription;
+    }) as typeof Keyboard.addListener;
+}
+
 // This mock must live in setupAfterEnv (not setupFiles) because @shopify/flash-list/jestSetup,
 // imported in setup.ts, registers its own measureLayout mock. Placing ours here ensures it
 // runs after FlashList's setup and takes precedence.

jest/setupAfterEnv.ts

@@ -2,14 +2,15 @@ package com.margelo.nitro.utils
 
 import android.content.Context
 import com.margelo.nitro.NitroModules
+import androidx.core.content.edit
 
 class HybridAppStartTimeModule : HybridAppStartTimeModuleSpec() {
     override val memorySize: Long = 16L
 
-    override fun recordAppStartTime() {
+    fun recordAppStartTime() {
         val context = NitroModules.applicationContext ?: return
         val sharedPreferences = context.getSharedPreferences("AppStartTime", Context.MODE_PRIVATE)
-        sharedPreferences.edit().putLong("AppStartTime", System.currentTimeMillis()).apply()
+        sharedPreferences.edit { putLong("AppStartTime", System.currentTimeMillis()) }
     }
 
     override val appStartTime: Double