Merge pull request Expensify#75809 from shubham1206agra/refactor-hasOtherControlWorkspaces

Refactor: isolate hasOtherControlWorkspaces from ONYXKEYS.COLLECTION.POLICY Onyx.connect data

Author: tgolen

src/libs/PolicyUtils.ts

@@ -1465,9 +1465,9 @@ function getDefaultChatEnabledPolicy(groupPoliciesWithChatEnabled: Array<OnyxInp
     return undefined;
 }
 
-function hasOtherControlWorkspaces(currentPolicyID: string) {
-    const otherControlWorkspaces = Object.values(allPolicies ?? {}).filter((policy) => policy?.id !== currentPolicyID && isPolicyAdmin(policy) && isControlPolicy(policy));
-    return otherControlWorkspaces.length > 0;
+function hasOtherControlWorkspaces(adminPolicies: Policy[] | undefined, currentPolicyID: string) {
+    const otherControlWorkspaces = adminPolicies?.filter((policy) => policy?.id !== currentPolicyID && isControlPolicy(policy));
+    return (otherControlWorkspaces?.length ?? 0) > 0;
 }
 
 // If no policyID is provided, it indicates the workspace upgrade/downgrade URL

src/pages/workspace/downgrade/DowngradeConfirmation.tsx

@@ -1,9 +1,15 @@
-import React from 'react';
+import {activeAdminPoliciesSelector} from '@selectors/Policy';
+import React, {useCallback} from 'react';
+import type {OnyxCollection} from 'react-native-onyx';
 import ConfirmationPage from '@components/ConfirmationPage';
+import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
 import {useMemoizedLazyIllustrations} from '@hooks/useLazyAsset';
 import useLocalize from '@hooks/useLocalize';
+import useOnyx from '@hooks/useOnyx';
 import useThemeStyles from '@hooks/useThemeStyles';
 import {hasOtherControlWorkspaces as hasOtherControlWorkspacesPolicyUtils} from '@libs/PolicyUtils';
+import ONYXKEYS from '@src/ONYXKEYS';
+import type {Policy} from '@src/types/onyx';
 
 type Props = {
     onConfirmDowngrade: () => void;
@@ -14,7 +20,15 @@ function DowngradeConfirmation({onConfirmDowngrade, policyID}: Props) {
     const {translate} = useLocalize();
     const styles = useThemeStyles();
     const illustrations = useMemoizedLazyIllustrations(['MushroomTopHat'] as const);
-    const hasOtherControlWorkspaces = hasOtherControlWorkspacesPolicyUtils(policyID);
+    const {login} = useCurrentUserPersonalDetails();
+    const selector = useCallback(
+        (policies: OnyxCollection<Policy>) => {
+            return activeAdminPoliciesSelector(policies, login ?? '');
+        },
+        [login],
+    );
+    const [adminPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true, selector});
+    const hasOtherControlWorkspaces = hasOtherControlWorkspacesPolicyUtils(adminPolicies, policyID);
 
     return (
         <ConfirmationPage

src/selectors/Policy.ts

@@ -1,5 +1,5 @@
 import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
-import {getOwnedPaidPolicies} from '@libs/PolicyUtils';
+import {getOwnedPaidPolicies, isPolicyAdmin} from '@libs/PolicyUtils';
 import CONST from '@src/CONST';
 import type {Policy, PolicyReportField} from '@src/types/onyx';
 import mapOnyxCollectionItems from '@src/utils/mapOnyxCollectionItems';
@@ -12,6 +12,13 @@ const activePolicySelector = (policy: OnyxEntry<Policy>) => (policy?.type !== CO
 
 const ownerPoliciesSelector = (policies: OnyxCollection<Policy>, currentUserAccountID: number) => getOwnedPaidPolicies(policies, currentUserAccountID);
 
+const activeAdminPoliciesSelector = (policies: OnyxCollection<Policy>, currentUserAccountLogin: string) => {
+    const adminPolicies = Object.values(policies ?? {}).filter(
+        (policy): policy is Policy => policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && isPolicyAdmin(policy, currentUserAccountLogin),
+    );
+    return adminPolicies;
+};
+
 /**
  * Creates a selector that aggregates all non-formula policy report fields from all policies,
  * sorted alphabetically by field key using the provided locale compare function
@@ -30,4 +37,4 @@ const createAllPolicyReportFieldsSelector = (policies: OnyxCollection<Policy>, l
     return Object.fromEntries(nonFormulaReportFields);
 };
 
-export {activePolicySelector, createPoliciesSelector, createAllPolicyReportFieldsSelector, ownerPoliciesSelector};
+export {activePolicySelector, createPoliciesSelector, createAllPolicyReportFieldsSelector, ownerPoliciesSelector, activeAdminPoliciesSelector};

tests/unit/PolicyUtilsTest.ts

@@ -18,6 +18,7 @@ import {
     getUnitRateValue,
     hasDynamicExternalWorkflow,
     hasOnlyPersonalPolicies,
+    hasOtherControlWorkspaces,
     isCurrentUserMemberOfAnyPolicy,
     isPolicyMemberWithoutPendingDelete,
     shouldShowPolicy,
@@ -1306,4 +1307,31 @@ describe('PolicyUtils', () => {
             expect(result).toBe(true);
         });
     });
+
+    describe('hasOtherControlWorkspaces', () => {
+        it('should return false when policies is empty', () => {
+            const result = hasOtherControlWorkspaces([], '1');
+            expect(result).toBe(false);
+        });
+
+        it('should return false when there are no control workspaces other than the current one', () => {
+            const policies = [
+                {...createRandomPolicy(1, CONST.POLICY.TYPE.CORPORATE), pendingAction: undefined},
+                {...createRandomPolicy(2, CONST.POLICY.TYPE.PERSONAL), pendingAction: undefined},
+                {...createRandomPolicy(3, CONST.POLICY.TYPE.TEAM), pendingAction: undefined},
+            ];
+            const result = hasOtherControlWorkspaces(policies, '1');
+            expect(result).toBe(false);
+        });
+
+        it('should return true when there are other control workspaces', () => {
+            const policies = [
+                {...createRandomPolicy(1, CONST.POLICY.TYPE.CORPORATE), pendingAction: undefined},
+                {...createRandomPolicy(2, CONST.POLICY.TYPE.CORPORATE), pendingAction: undefined},
+                {...createRandomPolicy(3, CONST.POLICY.TYPE.PERSONAL), pendingAction: undefined},
+            ];
+            const result = hasOtherControlWorkspaces(policies, '1');
+            expect(result).toBe(true);
+        });
+    });
 });