Skip to content

Commit c845656

Browse files
committed
refactor: migrate rnef to rock
1 parent f54a2c1 commit c845656

11 files changed

Lines changed: 690 additions & 506 deletions

File tree

.github/workflows/remote-build-android.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ jobs:
3636
IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}
3737

3838
- name: RNEF Remote Build - Android
39-
# rnef v2
40-
uses: callstackincubator/android@d9a81f860e436ff2971323990244e32830dcabd1
39+
# rock v3
40+
uses: callstackincubator/android@8fe27a5a3efcf32b54e4741be0ba58bafc73bb0d
4141
env:
4242
GITHUB_TOKEN: ${{ github.token }}
4343
IS_HYBRID_APP: ${{ matrix.is_hybrid_build }}
4444
with:
4545
variant: ${{ matrix.variant }}
46-
rnef-build-extra-params: '--extra-params -PreactNativeArchitectures=arm64-v8a,x86_64'
46+
rock-build-extra-params: '--extra-params -PreactNativeArchitectures=arm64-v8a,x86_64'
4747
comment-bot: false

.github/workflows/remote-build-ios.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ jobs:
4040
IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}
4141

4242
- name: RNEF Remote Build - iOS
43-
# rnef v2
44-
uses: callstackincubator/ios@7847e0676242cefa801cba8ede6736140b7bae91
43+
# rock v3
44+
uses: callstackincubator/ios@dd886b4ad3b35351d799d4c2633a678c94549038
4545
env:
4646
GITHUB_TOKEN: ${{ github.token }}
4747
IS_HYBRID_APP: ${{ matrix.is_hybrid_build }}

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ docs/.bundle
148148
# Output of react compiler healthcheck dev script
149149
react-compiler-output.txt
150150

151-
# React Native Enterprise Framework
152-
.rnef/
151+
# Rock Framework
152+
.rock/
153153

154154
# Generated by bob (for Nitro modules)
155155
modules/*/lib/

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ react {
6666
autolinkLibrariesWithApp()
6767
// Added by install-expo-modules
6868
entryFile = file(["node", "-e", "require('expo/scripts/resolveAppEntry')", rootDir.getAbsoluteFile().getParentFile().getAbsolutePath(), "android", "absolute"].execute(null, rootDir).text.trim())
69-
cliFile = file("../../node_modules/@rnef/cli/dist/src/bin.js")
69+
cliFile = file("../../node_modules/rock/dist/src/bin.js")
7070
bundleCommand = "bundle"
7171
}
7272

android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ pluginManagement { includeBuild("../node_modules/@react-native/gradle-plugin") }
22
plugins { id("com.facebook.react.settings") }
33
apply from: "${rootDir}/../gradleUtils/PatchedArtifactsSettings.gradle"
44

5-
extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand(['npx', 'rnef', 'config', '-p', 'android']) }
5+
extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand(['npx', 'rock', 'config', '-p', 'android']) }
66
rootProject.name = 'NewExpensify'
77
include ':react-native-webview'
88
project(':react-native-webview').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-webview/android')

ios/Podfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ target 'NewExpensify' do
8282
'ReleaseProduction' => :release,
8383
'Debug' => :debug
8484

85-
config = use_native_modules!(['npx', 'rnef', 'config', '-p', 'ios'])
85+
config = use_native_modules!(['npx', 'rock', 'config', '-p', 'ios'])
8686

8787
# Flags change depending on the env values.
8888
flags = get_default_flags()

0 commit comments

Comments
 (0)