Skip to content

Commit c87b1c7

Browse files
authored
Merge branch 'Expensify:main' into fix/lhn-props
2 parents 7cc09b4 + a1c004e commit c87b1c7

12 files changed

Lines changed: 49 additions & 16 deletions

File tree

Mobile-Expensify

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ android {
114114
minSdkVersion rootProject.ext.minSdkVersion
115115
targetSdkVersion rootProject.ext.targetSdkVersion
116116
multiDexEnabled rootProject.ext.multiDexEnabled
117-
versionCode 1009015900
118-
versionName "9.1.59-0"
117+
versionCode 1009015901
118+
versionName "9.1.59-1"
119119
// Supported language variants must be declared here to avoid from being removed during the compilation.
120120
// This also helps us to not include unnecessary language variants in the APK.
121121
resConfigs "en", "es"

ios/NewExpensify/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</dict>
4545
</array>
4646
<key>CFBundleVersion</key>
47-
<string>9.1.59.0</string>
47+
<string>9.1.59.1</string>
4848
<key>FullStory</key>
4949
<dict>
5050
<key>OrgId</key>

ios/NotificationServiceExtension/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.1.59</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.1.59.0</string>
16+
<string>9.1.59.1</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionPointIdentifier</key>

ios/ShareViewController/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.1.59</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.1.59.0</string>
16+
<string>9.1.59.1</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionAttributes</key>

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "new.expensify",
3-
"version": "9.1.59-0",
3+
"version": "9.1.59-1",
44
"author": "Expensify, Inc.",
55
"homepage": "https://new.expensify.com",
66
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {useFocusEffect} from '@react-navigation/native';
22
import isEmpty from 'lodash/isEmpty';
3-
import React, {memo, useCallback, useMemo, useState} from 'react';
3+
import React, {memo, useCallback, useEffect, useMemo, useState} from 'react';
44
import {View} from 'react-native';
55
import Animated, {FadeIn, FadeOut} from 'react-native-reanimated';
66
import type {TupleToUnion} from 'type-fest';
@@ -26,6 +26,7 @@ import ControlSelection from '@libs/ControlSelection';
2626
import {convertToDisplayString} from '@libs/CurrencyUtils';
2727
import {canUseTouchScreen} from '@libs/DeviceCapabilities';
2828
import {getThreadReportIDsForTransactions} from '@libs/MoneyRequestReportUtils';
29+
import {isFullScreenName} from '@libs/Navigation/helpers/isNavigatorName';
2930
import {navigationRef} from '@libs/Navigation/Navigation';
3031
import {getIOUActionForTransactionID} from '@libs/ReportActionsUtils';
3132
import {generateReportID, getMoneyRequestSpendBreakdown, isIOUReport} from '@libs/ReportUtils';
@@ -39,7 +40,7 @@ import CONST from '@src/CONST';
3940
import NAVIGATORS from '@src/NAVIGATORS';
4041
import type {Route} from '@src/ROUTES';
4142
import ROUTES from '@src/ROUTES';
42-
import type SCREENS from '@src/SCREENS';
43+
import SCREENS from '@src/SCREENS';
4344
import type * as OnyxTypes from '@src/types/onyx';
4445
import MoneyRequestReportTableHeader from './MoneyRequestReportTableHeader';
4546
import SearchMoneyRequestReportEmptyState from './SearchMoneyRequestReportEmptyState';
@@ -219,6 +220,34 @@ function MoneyRequestReportTransactionList({
219220
[reportActions, sortedTransactions],
220221
);
221222

223+
useEffect(() => {
224+
const lastFullScreenRoute = navigationRef.getRootState()?.routes.findLast((route) => isFullScreenName(route.name));
225+
226+
// Only setActiveTransactionThreadIDs if current full screen report route is this report
227+
if (lastFullScreenRoute?.name !== NAVIGATORS.REPORTS_SPLIT_NAVIGATOR && lastFullScreenRoute?.name !== NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR) {
228+
return;
229+
}
230+
231+
// Check params contain reportID
232+
const lastRoute = lastFullScreenRoute?.state?.routes?.at(-1);
233+
if (!lastRoute?.params || !('reportID' in lastRoute.params)) {
234+
return;
235+
}
236+
237+
// Check lastRoute is a report screen
238+
if (lastRoute?.name !== SCREENS.SEARCH.MONEY_REQUEST_REPORT && lastRoute?.name !== SCREENS.REPORT) {
239+
return;
240+
}
241+
242+
// Check lastRoute params has reportID equal with this reportID
243+
if (lastRoute.params.reportID !== report.reportID) {
244+
return;
245+
}
246+
247+
const sortedSiblingTransactionReportIDs = getThreadReportIDsForTransactions(reportActions, transactions);
248+
setActiveTransactionThreadIDs(sortedSiblingTransactionReportIDs);
249+
}, [report.reportID, reportActions, transactions]);
250+
222251
const dateColumnSize = useMemo(() => {
223252
const shouldShowYearForSomeTransaction = transactions.some((transaction) => shouldShowTransactionYear(transaction));
224253
return shouldShowYearForSomeTransaction ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;

src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import {findFocusedRoute} from '@react-navigation/native';
2-
import React, {useEffect, useMemo} from 'react';
2+
import React, {useEffect} from 'react';
33
import Icon from '@components/Icon';
44
import * as Expensicons from '@components/Icon/Expensicons';
55
import PressableWithFeedback from '@components/Pressable/PressableWithFeedback';
@@ -21,7 +21,7 @@ function MoneyRequestReportTransactionsNavigation({currentReportID}: MoneyReques
2121
const theme = useTheme();
2222

2323
const reportIDsList = getActiveTransactionThreadIDs();
24-
const {prevReportID, nextReportID} = useMemo(() => {
24+
const {prevReportID, nextReportID} = (() => {
2525
if (!reportIDsList) {
2626
return {prevReportID: undefined, nextReportID: undefined};
2727
}
@@ -32,7 +32,7 @@ function MoneyRequestReportTransactionsNavigation({currentReportID}: MoneyReques
3232
const nextID = currentReportIndex <= reportIDsList.length - 1 ? reportIDsList.at(currentReportIndex + 1) : undefined;
3333

3434
return {prevReportID: prevID, nextReportID: nextID};
35-
}, [currentReportID, reportIDsList]);
35+
})();
3636

3737
const backTo = Navigation.getActiveRoute();
3838

src/pages/iou/request/step/IOURequestStepScan/ReceiptPreviews/index.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,10 @@ function ReceiptPreviews({submit, setTabSwipeDisabled, isMultiScanEnabled}: Rece
115115
};
116116
});
117117

118+
if (!isMultiScanEnabled) {
119+
return;
120+
}
121+
118122
return (
119123
<Animated.View style={slideInStyle}>
120124
<View style={styles.pr4}>

0 commit comments

Comments
 (0)