Fixes and cleanup

Author: parasharrajat

src/components/ReportActionItem/TripRoomPreview.tsx

@@ -181,7 +181,6 @@ function TripRoomPreview({
         />
     );
 
-    console.debug('displayAmount', totalDisplaySpend, displayAmount);
     return (
         <OfflineWithFeedback
             pendingAction={action?.pendingAction}

src/libs/TripReservationUtils.ts

@@ -368,7 +368,8 @@ function getRailReservations(pnr: Pnr, travelers: PnrTraveler[]): Array<{reserva
                         },
                     ],
                     vendor: leg.vendorName,
-                    coachNumber: leg.travelClass,
+                    coachNumber: leg.allocatedSpaces?.at(0)?.coachNumber,
+                    seatNumber: leg.allocatedSpaces?.at(0)?.seatNumber,
                     travelerPersonalInfo: {
                         name: getTravelerName(traveler),
                         email: traveler?.email ?? '',
@@ -434,5 +435,21 @@ function getTripTotal(tripReport: Report): {
     return getMoneyRequestSpendBreakdown(tripReport);
 }
 
-export {getTripReservationIcon, getTripEReceiptIcon, getTripReservationCode, getReservationsFromTripReport, getTripTotal};
+function getReservationDetailsFromSequence(tripReservations: ReservationData[], sequenceIndex: number) {
+    const reservationDataIndex = tripReservations?.findIndex((reservation) => reservation.sequenceIndex === sequenceIndex);
+    const reservationData = tripReservations.at(reservationDataIndex);
+    const prevReservationData = Number(reservationData?.reservationIndex) > 0 ? tripReservations?.at(reservationDataIndex - 1) : undefined;
+    const reservation = reservationData?.reservation;
+    const prevReservation = prevReservationData?.reservation;
+    const reservationType = reservation?.type;
+    const reservationIcon = getTripReservationIcon(reservation?.type);
+    return {
+        reservation,
+        prevReservation,
+        reservationType,
+        reservationIcon,
+    };
+}
+
+export {getTripReservationIcon, getTripEReceiptIcon, getTripReservationCode, getReservationsFromTripReport, getTripTotal, getReservationDetailsFromSequence};
 export type {ReservationData};

src/pages/Travel/TripDetailsPage.tsx

@@ -16,7 +16,7 @@ import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import type {TravelNavigatorParamList} from '@libs/Navigation/types';
 import {getTripIDFromTransactionParentReportID} from '@libs/ReportUtils';
-import {getReservationsFromTripReport, getTripReservationIcon} from '@libs/TripReservationUtils';
+import {getReservationDetailsFromSequence, getReservationsFromTripReport} from '@libs/TripReservationUtils';
 import {openTravelDotLink} from '@userActions/Link';
 import CONFIG from '@src/CONFIG';
 import CONST from '@src/CONST';
@@ -57,13 +57,7 @@ function TripDetailsPage({route}: TripDetailsPageProps) {
     // If pnr is not passed and transaction is present, we want to use transaction to get the trip reservations as the provided sequenceIndex now refers to the position of trip reservation in transaction's reservation list
     const tripReservations = getReservationsFromTripReport(!Number(pnr) && transaction ? undefined : parentReport, transaction ? [transaction] : []);
 
-    const reservationDataIndex = tripReservations?.findIndex((reservation) => reservation.sequenceIndex === Number(sequenceIndex));
-    const reservationData = tripReservations.at(reservationDataIndex);
-    const prevReservationData = Number(reservationData?.reservationIndex) > 0 ? tripReservations?.at(reservationDataIndex - 1) : undefined;
-    const reservation = reservationData?.reservation;
-    const prevReservation = prevReservationData?.reservation;
-    const reservationType = reservation?.type;
-    const reservationIcon = getTripReservationIcon(reservation?.type);
+    const {reservation, prevReservation, reservationType, reservationIcon} = getReservationDetailsFromSequence(tripReservations, Number(sequenceIndex));
     const [travelerPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: (personalDetails) => pickTravelerPersonalDetails(personalDetails, reservation), canBeMissing: true});
 
     return (

src/types/onyx/TripData.ts

@@ -1697,7 +1697,12 @@ type RailPnr = {
     /** Leg information for the rail booking. */
     legInfos: Array<{
         /** Allocated spaces for the leg. */
-        allocatedSpaces: unknown[];
+        allocatedSpaces: Array<{
+            /** Seat */
+            seatNumber: string;
+            /** Coach */
+            coachNumber: string;
+        }>;
         /** Amenities available for the leg. */
         amenities: unknown[];
         /** Arrival time in ISO 8601 format. */