Skip to content

Commit c9d22cc

Browse files
committed
fix: v1 visual parity - SubBackButton title + speed-row alignment
1 parent 466201e commit c9d22cc

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

src/components/PopoverMenu/v2/sub/SubBackButton.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ function SubBackButton({text, testID, onPress: consumerOnPress}: SubBackButtonPr
2323
useSubContext(SubBackButton.displayName);
2424

2525
const {translate} = useLocalize();
26-
const hasCustomText = text !== undefined;
2726
const labelText = text ?? translate('common.goBack');
2827
const {ref, focused, onPress: exitSub, onFocus, isAtActiveLevel} = useSubBackButton();
2928
const icons = useMemoizedLazyExpensifyIcons(['BackArrow']);
@@ -49,12 +48,9 @@ function SubBackButton({text, testID, onPress: consumerOnPress}: SubBackButtonPr
4948
iconFill={(isHovered) => (isHovered ? theme.iconHovered : theme.icon)}
5049
additionalIconStyles={[{width: variables.iconSizeNormal, height: variables.iconSizeNormal}, styles.opacitySemiTransparent, styles.mr1]}
5150
iconStyles={[{width: variables.iconSizeNormal, height: variables.iconSizeNormal}]}
52-
style={hasCustomText ? styles.pv0 : undefined}
5351
wrapperStyle={[styles.ph5, styles.pv3]}
5452
innerContainerStyle={styles.alignItemsCenter}
5553
title={labelText}
56-
titleStyle={hasCustomText ? styles.createMenuHeaderText : undefined}
57-
shouldShowBasicTitle={hasCustomText}
5854
accessibilityLabel={`${translate('common.goBack')}, ${labelText}`}
5955
shouldCheckActionAllowedOnPress={false}
6056
onPress={handlePress}

src/components/VideoPopoverMenu/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ function VideoPopoverMenu() {
3838
key={speed}
3939
text={speed === 1 ? normalSpeedLabel : speed.toString()}
4040
isSelected={currentPlaybackSpeed === speed}
41-
shouldPutLeftPaddingWhenNoIcon
4241
onSelect={() => updatePlaybackSpeed(speed)}
4342
/>
4443
))}

0 commit comments

Comments
 (0)