|
23 | 23 | - [ ] MacOS: Chrome / Safari |
24 | 24 | - [ ] MacOS: Desktop |
25 | 25 | - [ ] For any bug fix or new feature in this PR, I verified that sufficient [unit tests](https://github.com/Expensify/App/blob/main/tests/README.md) are included to prevent regressions in this flow. |
26 | | -- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack |
27 | | -- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx` |
| 26 | + |
| 27 | +### Code Quality & Standards |
28 | 28 | - [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) |
29 | 29 | - [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`). |
30 | 30 | - [ ] I verified that comments were added to code that is not self explanatory |
31 | 31 | - [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. |
32 | | - - [ ] I verified any copy / text shown in the product is localized by adding it to `src/languages/*` files and using the [translation method](https://github.com/Expensify/App/blob/4510fc76bbf5df699a2575bfb49a276af90f3ed7/src/components/LocaleContextProvider.tsx#L80) |
33 | | - - [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the [localization methods](https://github.com/Expensify/App/blob/4510fc76bbf5df699a2575bfb49a276af90f3ed7/src/components/LocaleContextProvider.tsx#L116-L123) |
34 | | - - [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) |
35 | 32 | - [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. |
36 | 33 | - [ ] I verified the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#jsdocs)) were followed |
37 | 34 | - [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers |
38 | | -- [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` have been tested & I retested again) |
39 | 35 | - [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) |
40 | 36 | - [ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such |
| 37 | +- [ ] If any new file was added I verified that: |
| 38 | + - [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory |
| 39 | +- [ ] If a new CSS style is added I verified that: |
| 40 | + - [ ] A similar style doesn't already exist |
| 41 | + - [ ] The style can't be created with an existing [StyleUtils](https://github.com/Expensify/App/blob/main/src/utils/index.ts) function (i.e. `StyleUtils.getBackgroundAndBorderStyle(theme.componentBG`) |
41 | 42 | - [ ] If a new component is created I verified that: |
42 | 43 | - [ ] A similar component doesn't exist in the codebase |
43 | 44 | - [ ] All props are defined accurately and each prop has a `/** comment above it */` |
|
62 | 63 | - [ ] I added `Design` label and/or tagged `@Expensify/design` so the design team can review the changes. |
63 | 64 | - [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page. |
64 | 65 | - [ ] I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard. |
| 66 | +- [ ] I verified any copy / text shown in the product is localized by adding it to `src/languages/*` files and using the [translation method](https://github.com/Expensify/App/blob/4510fc76bbf5df699a2575bfb49a276af90f3ed7/src/components/LocaleContextProvider.tsx#L80) |
| 67 | +- [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the [localization methods](https://github.com/Expensify/App/blob/4510fc76bbf5df699a2575bfb49a276af90f3ed7/src/components/LocaleContextProvider.tsx#L116-L123) |
| 68 | +- [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) |
| 69 | +- [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack |
| 70 | +- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx` |
65 | 71 |
|
66 | 72 | ### Screenshots/Videos |
67 | 73 | <details> |
|
0 commit comments