Merge pull request Expensify#63722 from Expensify/mollfpr-fix-stale-transaction-violations

Fix useTransactionViolations returning stale violations data

Author: rlinoz

src/hooks/useTransactionViolations.ts

@@ -1,12 +1,17 @@
 import {useMemo} from 'react';
-import {useOnyx} from 'react-native-onyx';
 import {isViolationDismissed} from '@libs/TransactionUtils';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {TransactionViolations} from '@src/types/onyx';
+import useOnyx from './useOnyx';
 
 function useTransactionViolations(transactionID?: string): TransactionViolations {
-    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`);
-    const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`);
+    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {
+        canBeMissing: true,
+    });
+    const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, {
+        canBeMissing: true,
+    });
+
     return useMemo(() => transactionViolations.filter((violation) => !isViolationDismissed(transaction, violation)), [transaction, transactionViolations]);
 }