Merge remote-tracking branch 'origin/main' into revert-89808

Author: abzokhattab

Mobile-Expensify

@@ -111,8 +111,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009036916
-        versionName "9.3.69-16"
+        versionCode 1009037001
+        versionName "9.3.70-1"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"

android/app/build.gradle

@@ -425,7 +425,6 @@
 "../../src/libs/actions/TwoFactorAuthActions.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/libs/actions/UnreportedExpenses.tsx"	"no-restricted-syntax"	1
 "../../src/libs/actions/User.ts"	"no-restricted-syntax"	8
-"../../src/libs/actions/User.ts"	"rulesdir/no-onyx-connect"	1
 "../../src/libs/actions/VacationDelegate.ts"	"no-restricted-syntax"	2
 "../../src/libs/actions/Wallet.ts"	"no-restricted-syntax"	1
 "../../src/libs/actions/Welcome/index.ts"	"no-restricted-syntax"	1
@@ -500,7 +499,7 @@
 "../../src/pages/domain/Groups/PreferredWorkspaceToggle.tsx"	"@typescript-eslint/no-deprecated/ConfirmModal"	1
 "../../src/pages/domain/Saml/SamlLoginSectionContent.tsx"	"@typescript-eslint/no-deprecated/ConfirmModal"	1
 "../../src/pages/inbox/DeleteTransactionNavigateBackHandler.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
-"../../src/pages/inbox/ReportFetchHandler.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	3
+"../../src/pages/inbox/ReportFetchHandler.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	2
 "../../src/pages/inbox/ReportNavigateAwayHandler.tsx"	"react-hooks/exhaustive-deps"	1
 "../../src/pages/inbox/hooks/useReportWasDeleted.ts"	"react-hooks/set-state-in-effect"	1
 "../../src/pages/inbox/report/ContextMenu/BaseReportActionContextMenu.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
@@ -509,24 +508,23 @@
 "../../src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx"	"@typescript-eslint/no-deprecated/getReportNameDeprecated"	1
 "../../src/pages/inbox/report/ContextMenu/PopoverReportActionContextMenu.tsx"	"@typescript-eslint/no-deprecated/ConfirmModal"	1
 "../../src/pages/inbox/report/ContextMenu/PopoverReportActionContextMenu.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
-"../../src/pages/inbox/report/ContextMenu/PopoverReportActionContextMenu.tsx"	"react-hooks/refs"	30
+"../../src/pages/inbox/report/ContextMenu/PopoverReportActionContextMenu.tsx"	"react-hooks/refs"	29
 "../../src/pages/inbox/report/ListBoundaryLoader.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/pages/inbox/report/PureReportActionItem.tsx"	"react-hooks/refs"	2
 "../../src/pages/inbox/report/PureReportActionItem.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/pages/inbox/report/ReactionList/HeaderReactionList.tsx"	"no-restricted-syntax"	1
-"../../src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	2
-"../../src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx"	"react-hooks/preserve-manual-memoization"	2
-"../../src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx"	"react-hooks/refs"	8
+"../../src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
+"../../src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx"	"react-hooks/refs"	7
 "../../src/pages/inbox/report/ReportActionCompose/SuggestionEmoji.tsx"	"react-hooks/refs"	1
 "../../src/pages/inbox/report/ReportActionCompose/SuggestionMention.tsx"	"react-hooks/refs"	3
 "../../src/pages/inbox/report/ReportActionItemMessage.tsx"	"@typescript-eslint/no-deprecated/getReportName"	1
-"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	2
+"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"no-restricted-syntax"	1
 "../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"react-hooks/preserve-manual-memoization"	1
-"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"react-hooks/refs"	6
+"../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"react-hooks/refs"	5
 "../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"react-hooks/set-state-in-effect"	1
-"../../src/pages/inbox/report/ReportActionsList.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	5
-"../../src/pages/inbox/report/ReportActionsList.tsx"	"react-hooks/refs"	7
+"../../src/pages/inbox/report/ReportActionsList.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	4
+"../../src/pages/inbox/report/ReportActionsList.tsx"	"react-hooks/refs"	5
 "../../src/pages/inbox/report/ReportActionsList.tsx"	"react-hooks/set-state-in-effect"	3
 "../../src/pages/inbox/report/ReportActionsView.tsx"	"react-hooks/globals"	1
 "../../src/pages/inbox/report/ReportActionsView.tsx"	"react-hooks/preserve-manual-memoization"	1
@@ -553,9 +551,8 @@
 "../../src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSButtons/index.tsx"	"@typescript-eslint/no-deprecated/ConfirmModal"	3
 "../../src/pages/iou/request/step/IOURequestStepDistanceMap.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
-"../../src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/pages/iou/request/step/IOURequestStepMerchant.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
-"../../src/pages/iou/request/step/IOURequestStepReport.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	2
+"../../src/pages/iou/request/step/IOURequestStepReport/hooks/useReportSelectionActions.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	2
 "../../src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/pages/iou/request/step/IOURequestStepScan/ReceiptView/index.tsx"	"react-hooks/set-state-in-effect"	1
 "../../src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx"	"react-hooks/immutability"	1

config/eslint/eslint.seatbelt.tsv

@@ -4,12 +4,21 @@ Contributors are eligible to be paid via Expensify 18 months after they were ass
 - You’ll need to create an Expensify account and Connect Personal Bank Account. To receive payments in USD, GBP, or EUR, add receiving accounts in those currencies via platforms like Wise, Payoneer, PingPong, Skydo, etc. 
   - Payoneer provides a U.S.-based USD account through Citibank. Since you won’t have direct access to a Citibank online account, you’ll need to connect the bank account manually instead of using Plaid. 
     - You can do this in **oldDot** by navigating to: Settings > Account > Wallet > Add Personal Bank Account > Connect manually.
-  - Skydo is a service that contributors in India have used. 
+  - Skydo is a service that contributors in India have used [Slack Thread](https://expensify.slack.com/archives/C02NK2DQWUX/p1761116747758089).
 - View [Enable Global Reimbursement](https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Enable-Global-Reimbursement) to get more details on setting up reimbursements in United States (USD), Canada (CAD), United Kingdom (GBP), European Union (EUR), Australia (AUD) and Singapore (SGD) currencies.
 - View [Receive Payments](https://help.expensify.com/articles/expensify-classic/bank-accounts-and-payments/payments/Receive-Payments) for details on receiving payments in the US and internationally, including via Wise (formerly TransferWise), Paypal, Venmo and more.  
 
 After approval it can take between 1 business day and a week, depending on the country and service you use.  
 
+## Requesting Payments
+Request payment, by submitting your reports, in the same month the payment summary is posted. If that is not possible, request it as soon as possible after month-end. This is a hard requirement.
+
+Include in the Description field a link to the payment confirmation posted by the Expensify employee for which payment is due. Please do not add any additional details.  
+**Do not ever request payment before an employee has posted a payment summary.** 
+
+**Important!:** If you’re new to NewDot payments, please double check your eligibility date against the date you were assigned to a GH issue.  If you were assigned to a GH issue before your eligibility date, you must be paid via Upwork.
+
+
 ## For issues with deposits
 If you're having an issue with the deposit, ie. a report gets _stuck_ in a state like Approved, start a chat with Concierge to ask for help. Provide as many details below as possible
 
@@ -22,3 +31,16 @@ If you're having an issue with the deposit, ie. a report gets _stuck_ in a state
 > - Location of reimbursement account
 > - Have you received reimbursements to the connected deposit account successfully in the past?
 
+## Refund Process
+In case you have been over-paid (e.g. regression penalty was not applied, dupe request for payment, etc.) you can issue a refund by submitting a negative expense to your workspace report. (OldDot Only)
+1. Go to OldDot
+2. Click on your avatar and in the “Use this expense workspace” section verify that the correct workspace is selected (Contributors+ - Expensify Inc)
+3. Go to Expenses then press New Expense > Manually Create
+4. In the merchant and the description fields link to the related GH issue and in the total put the amount you want to refund but in negative e.g. -125
+5. Click on Save
+6. Post on the issue you’re refunding to denote the refund, amount and the Report ID
+
+
+**Note:** This process will not actually issue a refund (i.e. money won’t be deducted from your bank account). You will need to offset the refund with a positive payment that is equal or greater than the negative expense.  e.g. if you later on submitted an expense for $1,000, the report’s total would be $875 ($1,000 less the $125 you’re refunding)
+
+If you need to “hold back” expenses in order to have a report total that is positive, remove the category and tag and description then they will not auto submit. **When you are done doing this, you MUST SUBMIT YOUR REPORT MANUALLY**, otherwise auto submit will split them into 2 reports and what you did will be in vain.

contributingGuides/PAYMENT_VIA_EXPENSIFY.md

@@ -1,7 +1,7 @@
 ---
 title: Getting Started with the Spend Page
 description: Learn how to use the Spend page in New Expensify to view, filter, and manage your expense data using report previews, tables, filters, and smart suggestions.
-keywords: [New Expensify, Spend page, report preview, report table, filters, smart suggestions, expense management, add expenses, bulk actions, date range, search, expenses missing, Spend navigation]
+keywords: [New Expensify, Spend page, report preview, report table, filters, smart suggestions, expense management, add expenses, bulk actions, date range, search, expenses missing, Spend navigation, inline editing, edit expense inline]
 ---
 
 The Spend page in New Expensify gives you a complete view of your submitted, approved, and reimbursed expenses—all in one place. This guide shows you how to use report previews, tables, filters, and smart suggestions to track, manage, and take action on your expenses more efficiently.
@@ -49,6 +49,7 @@ Each row represents an expense and includes:
 
 ## Available Actions on the Table
 - **Click an expense** to view or edit it in the right-hand panel  
+- **Edit a cell directly (desktop only):** Click a **date**, **merchant**, **description**, **category**, or **amount** cell to edit the value inline without opening the expense details. Click outside the cell or press Enter to save.
 - **Select multiple expenses** using checkboxes, then apply bulk actions such as:
   - **Move to another report:** When you need to have multiple reports or need to break up expenses across multiple weeks or months.
   - **Download:** For exporting to a CSV file for analysis or to share with your accountant.

docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md

@@ -1,7 +1,7 @@
 ---
 title: Managing Expenses in a Report
 description: Learn how to add, remove, and move expenses in a report in New Expensify, including how comments and system messages interact with them.
-keywords: [New Expensify, manage expenses, add expense, delete expense, move expense, expense table, edit report, report approval, expense actions, create report, admin create report]
+keywords: [New Expensify, manage expenses, add expense, delete expense, move expense, expense table, edit report, report approval, expense actions, create report, admin create report, inline editing, edit expense inline]
 ---
 
 Easily add, delete, or move expenses within reports in New Expensify. This guide covers how to manage expenses using the expense table on both web and mobile.
@@ -98,6 +98,16 @@ Additional columns such as **Attendees** and **Per attendee** can be enabled via
 
 Clicking a row opens the full expense in a side panel (web) or details screen (mobile).
 
+## How to edit expenses inline on desktop
+
+On desktop, you can edit certain expense fields directly in the table without opening the expense details:
+
+1. Click a **date**, **merchant**, **description**, **category**, or **amount** cell in the expense table.
+2. Edit the value using the inline editor that appears (a text input, date picker, or category picker depending on the field).
+3. Click outside the cell or press Enter to save your changes.
+
+**Note:** Inline editing is only available on desktop (wide layout). On mobile, tap the expense row to open the full details screen.
+
 ---
 
 # FAQ

docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md

@@ -23,7 +23,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>9.3.69</string>
+	<string>9.3.70</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleURLTypes</key>
@@ -44,7 +44,7 @@
 		</dict>
 	</array>
 	<key>CFBundleVersion</key>
-	<string>9.3.69.16</string>
+	<string>9.3.70.1</string>
 	<key>FullStory</key>
 	<dict>
 		<key>OrgId</key>

ios/NewExpensify/Info.plist

@@ -11,9 +11,9 @@
 	<key>CFBundleName</key>
 	<string>$(PRODUCT_NAME)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>9.3.69</string>
+	<string>9.3.70</string>
 	<key>CFBundleVersion</key>
-	<string>9.3.69.16</string>
+	<string>9.3.70.1</string>
 	<key>NSExtension</key>
 	<dict>
 		<key>NSExtensionPointIdentifier</key>

ios/NotificationServiceExtension/Info.plist

@@ -11,9 +11,9 @@
 	<key>CFBundleName</key>
 	<string>$(PRODUCT_NAME)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>9.3.69</string>
+	<string>9.3.70</string>
 	<key>CFBundleVersion</key>
-	<string>9.3.69.16</string>
+	<string>9.3.70.1</string>
 	<key>NSExtension</key>
 	<dict>
 		<key>NSExtensionAttributes</key>