Merge pull request Expensify#83095 from Expensify/claude-fixTravelInvoicingErrorAndPublicDomainCheck

Fix: Remove generic error from failureData and move public domain check in Travel Invoicing

Author: rlinoz

src/libs/actions/TravelInvoicing.ts

@@ -288,7 +288,6 @@ function toggleTravelInvoicing(policyID: string, workspaceAccountID: number, ena
                     isEnabled: !enabled,
                 },
                 pendingAction: null,
-                errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
             },
         },
     ];

src/pages/workspace/travel/WorkspaceTravelInvoicingSection.tsx

@@ -115,6 +115,12 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
      * When turning OFF: show confirmation modal, then call toggleTravelInvoicing(false).
      */
     const handleToggle = (isEnabled: boolean) => {
+        // Check if user is on a public domain - Travel Invoicing requires a private domain
+        if (account?.isFromPublicDomain) {
+            Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));
+            return;
+        }
+
         if (!isEnabled) {
             // Trying to disable - check for outstanding balance first
             if (hasOutstandingTravelBalance(cardSettings)) {
@@ -127,12 +133,6 @@ function WorkspaceTravelInvoicingSection({policyID}: WorkspaceTravelInvoicingSec
             return;
         }
 
-        // Check if user is on a public domain - Travel Invoicing requires a private domain
-        if (account?.isFromPublicDomain) {
-            Navigation.navigate(ROUTES.TRAVEL_PUBLIC_DOMAIN_ERROR.getRoute(Navigation.getActiveRoute()));
-            return;
-        }
-
         // Turning ON - check if bank account setup is needed first
         if (!eligibleBankAccounts.length || isSetupUnfinished) {
             // No bank accounts - start add bank account flow

tests/unit/TravelInvoicingTest.ts

@@ -250,7 +250,6 @@ describe('TravelInvoicing', () => {
                                 isEnabled: !enabled,
                             }),
                             pendingAction: null,
-                            errors: expect.anything() as unknown,
                         }),
                     }),
                 ]),