Skip to content

Commit d0a9ba7

Browse files
refactor: pre-compute isOneOnOneChat on optionItem instead of recomputing in renderItem
1 parent 954747b commit d0a9ba7

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/components/LHNOptionsList/OptionRowLHN/OptionRowLHNCore.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
2020
import DateUtils from '@libs/DateUtils';
2121
import FS from '@libs/Fullstory';
2222
import {shouldUseBoldText} from '@libs/OptionsListUtils';
23-
import {isChatUsedForOnboarding as isChatUsedForOnboardingReportUtils, isGroupChat, isOneOnOneChat, isSystemChat} from '@libs/ReportUtils';
23+
import {isChatUsedForOnboarding as isChatUsedForOnboardingReportUtils, isGroupChat, isSystemChat} from '@libs/ReportUtils';
2424
import FreeTrial from '@pages/settings/Subscription/FreeTrial';
2525
import variables from '@styles/variables';
2626
import CONST from '@src/CONST';
@@ -78,7 +78,7 @@ function OptionRowLHN({isOptionFocused = false, onSelectRow = () => {}, optionIt
7878
const currentSelectedTimezone = currentUserPersonalDetails?.timezone?.selected ?? CONST.DEFAULT_TIME_ZONE.selected;
7979
const formattedDate = DateUtils.getStatusUntilDate(translate, statusClearAfterDate, optionItem?.timezone?.selected ?? CONST.DEFAULT_TIME_ZONE.selected, currentSelectedTimezone);
8080
const statusContent = formattedDate ? `${statusText ? `${statusText} ` : ''}(${formattedDate})` : statusText;
81-
const isStatusVisible = !!emojiCode && isOneOnOneChat(optionItem);
81+
const isStatusVisible = !!emojiCode && !!optionItem.isOneOnOneChat;
8282

8383
const subscriptAvatarBorderColor = isOptionFocused ? focusedBackgroundColor : theme.sidebar;
8484

src/libs/SidebarUtils.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,8 +893,11 @@ function getOptionData({
893893

894894
const status = personalDetail?.status ?? '';
895895

896+
const isOneOnOneChatReport = isOneOnOneChat(report);
897+
result.isOneOnOneChat = isOneOnOneChatReport;
898+
896899
// For 1:1 DMs, add the other participant's selected timezone
897-
if (isOneOnOneChat(report)) {
900+
if (isOneOnOneChatReport) {
898901
const recipientPersonalDetail = participantPersonalDetailListExcludeCurrentUser.at(0);
899902
result.timezone = recipientPersonalDetail?.timezone;
900903
}

0 commit comments

Comments
 (0)