Merge pull request Expensify#88534 from callstack-internal/fix/87757-plaid-oauth-broader-fix

Fix: 87757 plaid oauth broader fix

Author: amyevans

cspell.json

@@ -640,6 +640,7 @@
         "rideshare",
         "RNCORE",
         "RNFS",
+        "RNLinksdk",
         "rnmapbox",
         "RNTL",
         "RNVP",

patches/react-native-plaid-link-sdk/details.md

@@ -0,0 +1,26 @@
+# `react-native-plaid-link-sdk` patches
+
+### [react-native-plaid-link-sdk+12.5.3+001+fix-oauth-hybrid-app-ios.patch](react-native-plaid-link-sdk+12.5.3+001+fix-oauth-hybrid-app-ios.patch)
+
+- Reason:
+
+    ```
+    Fixes Plaid OAuth getting stuck in a retry loop on HybridApp iOS (e.g.
+    Banco Santander ES). HybridApp routes the bank's universal-link return
+    through JS Linking, so LinkKit never sees the callback URL and re-fires
+    OAuth after its internal timeout. The patch exposes [PLKHandler
+    resumeAfterTermination:] to JS so we can forward the URL back into the SDK.
+
+    The patch:
+    1. Adds RCT_EXPORT_METHOD(continueFromRedirectUri:) to RNLinksdk.mm.
+    2. Tracks the active module via a static sSharedInstance, set when
+       createPlaidLink succeeds and cleared on exit/handoff, so the
+       forwarder can resolve the correct handler.
+    3. Adds the matching continueFromRedirectUri Spec entry to
+       src/fabric/NativePlaidLinkModuleiOS.ts (required on New Architecture
+       so the TurboModule codegen exposes the method to JS).
+    ```
+
+- Upstream PR/issue: -
+- E/App issue: https://github.com/Expensify/App/issues/87757
+- PR introducing patch: https://github.com/Expensify/App/pull/88534

patches/react-native-plaid-link-sdk/react-native-plaid-link-sdk+12.5.3+001+fix-oauth-hybrid-app-ios.patch

@@ -0,0 +1,75 @@
+diff --git a/node_modules/react-native-plaid-link-sdk/ios/RNLinksdk.mm b/node_modules/react-native-plaid-link-sdk/ios/RNLinksdk.mm
+index cca454e..a1b66d7 100644
+--- a/node_modules/react-native-plaid-link-sdk/ios/RNLinksdk.mm
++++ b/node_modules/react-native-plaid-link-sdk/ios/RNLinksdk.mm
+@@ -12,6 +12,12 @@ static NSString* const kRNLinkKitEventNameKey = @"event";
+ static NSString* const kRNLinkKitEventMetadataKey = @"metadata";
+ static NSString* const kRNLinkKitVersionConstant = @"version";
+ 
++// Tracks the module instance whose linkHandler is currently active for OAuth.
++// Set when createPlaidLink succeeds, cleared whenever linkHandler is nilled.
++// Lets JS forward universal-link OAuth redirects back into the SDK via
++// the RCT_EXPORT_METHOD continueFromRedirectUri: below.
++static RNLinksdk *sSharedInstance = nil;
++
+ @interface RNLinksdk ()
+ @property (nonatomic, strong) id<PLKHandler> linkHandler;
+ @property (nonatomic, strong) UIViewController* presentingViewController;
+@@ -92,6 +98,9 @@ RCT_EXPORT_METHOD(createPlaidLink:(NSString*)token noLoadingState:(BOOL)noLoadin
+             }
+             strongSelf.exitCallback = nil;
+             strongSelf.linkHandler = nil;
++            if (sSharedInstance == strongSelf) {
++                sSharedInstance = nil;
++            }
+         }
+     };
+ 
+@@ -108,6 +117,9 @@ RCT_EXPORT_METHOD(createPlaidLink:(NSString*)token noLoadingState:(BOOL)noLoadin
+                 if (strongSelf.presentingViewController == nil) {
+                     // Deallocate the handler it's no longer needed.
+                     strongSelf.linkHandler = nil;
++                    if (sSharedInstance == strongSelf) {
++                        sSharedInstance = nil;
++                    }
+                 }
+             }
+         }
+@@ -121,6 +133,9 @@ RCT_EXPORT_METHOD(createPlaidLink:(NSString*)token noLoadingState:(BOOL)noLoadin
+     NSError *creationError = nil;
+     self.linkHandler = [RNPlaidHelper createWithLinkTokenConfiguration:config error:&creationError];
+     self.creationError = creationError;
++    if (self.linkHandler) {
++        sSharedInstance = self;
++    }
+ }
+ 
+ RCT_EXPORT_METHOD(open:(BOOL)fullScreen onSuccess:(RCTResponseSenderBlock)onSuccess onExit:(RCTResponseSenderBlock)onExit) {
+@@ -175,6 +190,15 @@ RCT_EXPORT_METHOD(open:(BOOL)fullScreen onSuccess:(RCTResponseSenderBlock)onSucc
+     }
+ }
+ 
++RCT_EXPORT_METHOD(continueFromRedirectUri:(NSString *)urlString) {
++    NSURL *url = [NSURL URLWithString:urlString];
++    RNLinksdk *instance = sSharedInstance;
++    if (url == nil || instance == nil || instance.linkHandler == nil) {
++        return;
++    }
++    [instance.linkHandler resumeAfterTermination:url];
++}
++
+ RCT_EXPORT_METHOD(dismiss) {
+     [self.presentingViewController dismissViewControllerAnimated:YES
+                                                       completion:nil];
+diff --git a/node_modules/react-native-plaid-link-sdk/src/fabric/NativePlaidLinkModuleiOS.ts b/node_modules/react-native-plaid-link-sdk/src/fabric/NativePlaidLinkModuleiOS.ts
+index a783aa9..a15e91f 100644
+--- a/node_modules/react-native-plaid-link-sdk/src/fabric/NativePlaidLinkModuleiOS.ts
++++ b/node_modules/react-native-plaid-link-sdk/src/fabric/NativePlaidLinkModuleiOS.ts
+@@ -12,6 +12,7 @@ export interface Spec extends TurboModule {
+         onSuccess: (result: UnsafeObject<LinkSuccess>) => void,
+         onExit: (error: UnsafeObject<LinkError>, result: UnsafeObject<LinkExit>) => void,
+       ): void;
++    continueFromRedirectUri(urlString: string): void;
+     dismiss(): void;
+     submit(
+       phoneNumber: string | undefined,

src/libs/Navigation/linkingConfig/subscribe.ts

@@ -1,6 +1,7 @@
 import type {LinkingOptions} from '@react-navigation/native';
 import {findFocusedRoute} from '@react-navigation/native';
 import {Linking} from 'react-native';
+import continuePlaidOAuth from '@libs/continuePlaidOAuth';
 import navigationRef from '@libs/Navigation/navigationRef';
 import type {RootNavigatorParamList} from '@libs/Navigation/types';
 import CONST from '@src/CONST';
@@ -24,6 +25,10 @@ const subscribe: LinkingOptions<RootNavigatorParamList>['subscribe'] = (listener
         // React Navigation would resolve to NotFound (or reset navigation away from the Plaid step)
         // and break the flow — keep the current screen mounted so the SDK can finish.
         if (url.includes(CONST.PLAID.OAUTH_REDIRECT_PATH_IOS)) {
+            // Forward the OAuth redirect URI into the Plaid SDK so it can finalize OAuth.
+            // Without this, the native SDK never sees the callback URL and retries OAuth in a loop
+            // after app-to-app bank auth returns. See issue #87757.
+            continuePlaidOAuth(url);
             return;
         }
         listener(url);

src/libs/continuePlaidOAuth/index.ios.ts

@@ -0,0 +1,14 @@
+import {TurboModuleRegistry} from 'react-native';
+import type {TurboModule} from 'react-native';
+
+type PlaidBridge = TurboModule & {
+    continueFromRedirectUri: (urlString: string) => void;
+};
+
+const bridge = TurboModuleRegistry.get<PlaidBridge>('RNLinksdk');
+
+function continuePlaidOAuth(url: string): void {
+    bridge?.continueFromRedirectUri(url);
+}
+
+export default continuePlaidOAuth;

src/libs/continuePlaidOAuth/index.ts

@@ -0,0 +1,6 @@
+// eslint-disable-next-line @typescript-eslint/no-unused-vars -- Parameter kept for API parity with the iOS implementation (index.ios.ts)
+function continuePlaidOAuth(_url: string): void {
+    // Plaid OAuth return is handled only on iOS HybridApp (see issue #87757).
+}
+
+export default continuePlaidOAuth;