Fix accessibility live region lint feedback

Author: ShridharGoel

eslint-plugin-local-rules/require-a11y-disable-justification.js

@@ -2,7 +2,8 @@ const name = 'require-a11y-disable-justification';
 
 const ISSUE_URL_REGEX = /https?:\/\/github\.com\/(?:Expensify\/App|FormidableLabs\/eslint-plugin-react-native-a11y)\/(?:issues|pull)\/\d+/i;
 const ISSUE_URL_GLOBAL_REGEX = /https?:\/\/github\.com\/(?:Expensify\/App|FormidableLabs\/eslint-plugin-react-native-a11y)\/(?:issues|pull)\/\d+/gi;
-const DISABLE_A11Y_REGEX = /eslint-disable(?:-next-line|-line)?\s+[^]*?react-native-a11y\//i;
+const DISABLE_A11Y_REGEX = /eslint-disable(?:-next-line|-line)?\s+[\s\S]*?react-native-a11y\//i;
+const MIN_RATIONALE_LENGTH = 12;
 
 const meta = {
     type: 'problem',
@@ -35,7 +36,7 @@ function hasRationale(commentText) {
         .replaceAll(/\s+/g, ' ')
         .trim();
 
-    return strippedComment.length >= 12;
+    return strippedComment.length >= MIN_RATIONALE_LENGTH;
 }
 
 function create(context) {

eslint-plugin-local-rules/require-live-region-for-status-updates.js

@@ -156,7 +156,7 @@ function create(context) {
                 return;
             }
 
-            if (hasKnownStatusRole && liveRegionValue === 'none') {
+            if ((hasKnownStatusRole || hasAnyResolvedStatusRole) && liveRegionValue === 'none') {
                 context.report({
                     node,
                     messageId: 'invalidLiveRegion',

src/CONST/index.ts

@@ -6144,6 +6144,8 @@ const CONST = {
     ROLE: {
         /** Use for elements with important, time-sensitive information. */
         ALERT: 'alert',
+        /** Use for elements with advisory information that should be announced without interrupting the user. */
+        STATUS: 'status',
         /** Use for elements that act as buttons. */
         BUTTON: 'button',
         /** Use for elements representing checkboxes. */

src/components/Attachments/AttachmentCarousel/CarouselItem.tsx

@@ -72,7 +72,6 @@ function CarouselItem({item, onPress, isFocused, isModalHovered, reportID}: Caro
                 accessibilityRole={CONST.ROLE.BUTTON}
                 // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
                 accessibilityLabel={item.file?.name || translate('attachmentView.unknownFilename')}
-                // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
                 sentryLabel={CONST.SENTRY_LABEL.ATTACHMENT_CAROUSEL.ITEM}
             >
                 {children}

src/components/Attachments/AttachmentView/AttachmentViewImage/index.tsx

@@ -38,7 +38,6 @@ function AttachmentViewImage({attachmentID, url, file, isAuthTokenRequired, load
             accessibilityRole={CONST.ROLE.BUTTON}
             // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
             accessibilityLabel={file?.name || translate('attachmentView.unknownFilename')}
-            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
             sentryLabel={CONST.SENTRY_LABEL.ATTACHMENT_CAROUSEL.ITEM}
         >
             {children}

src/components/PDFView/index.native.tsx

@@ -222,7 +222,6 @@ function PDFView({onToggleKeyboard, onLoadComplete, fileName, onPress, isFocused
             accessibilityRole={CONST.ROLE.BUTTON}
             // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
             accessibilityLabel={fileName || translate('attachmentView.unknownFilename')}
-            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
             sentryLabel={CONST.SENTRY_LABEL.PDF_VIEW.DOCUMENT}
         >
             {renderPDFView()}

src/components/PDFView/index.tsx

@@ -138,7 +138,6 @@ function PDFView({onToggleKeyboard, fileName, onPress, isFocused, sourceURL, sty
             accessibilityRole={CONST.ROLE.BUTTON}
             // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
             accessibilityLabel={fileName || translate('attachmentView.unknownFilename')}
-            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
             sentryLabel={CONST.SENTRY_LABEL.PDF_VIEW.DOCUMENT}
         >
             {renderPDFView()}

src/components/TransactionItemRow/ReceiptPreview/index.tsx

@@ -119,7 +119,7 @@ function ReceiptPreview({source, hovered, isEReceipt = false, transactionItem}:
             {shouldShowImage ? (
                 <View style={[styles.w100]}>
                     {isLoading && (
-                        <View style={[StyleSheet.absoluteFill, styles.justifyContentCenter, styles.alignItemsCenter]}>
+                        <View style={[StyleSheet.absoluteFillObject, styles.justifyContentCenter, styles.alignItemsCenter]}>
                             <ActivityIndicator
                                 size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
                                 reasonAttributes={reasonAttributes}

src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

@@ -337,7 +337,7 @@ function BaseValidateCodeForm({
                 )}
             </OfflineWithFeedback>
             <View
-                role="status"
+                role={CONST.ROLE.STATUS}
                 accessibilityLiveRegion="polite"
             >
                 {!!validateCodeSent && (

src/pages/inbox/report/actionContents/FraudAlertContent.tsx

@@ -45,6 +45,7 @@ function FraudAlertContent({action, reportID}: FraudAlertContentProps) {
     return (
         <View
             accessibilityRole={CONST.ROLE.ALERT}
+            accessibilityLiveRegion="assertive"
             accessibilityLabel={translate('reportFraudConfirmationPage.title')}
         >
             <ReportActionItemBasicMessage message={message} />