Merge pull request Expensify#66722 from Expensify/revert-65422-fix/64257-splitted-tx-doesnt-show-immediately

Revert "Fix splitted transactions don't show immediately"

Author: amyevans

src/hooks/useAnimatedHighlightStyle/index.ts

@@ -1,4 +1,5 @@
 import React, {useState} from 'react';
+import {InteractionManager} from 'react-native';
 import {Easing, interpolate, interpolateColor, runOnJS, useAnimatedStyle, useSharedValue, withDelay, withSequence, withTiming} from 'react-native-reanimated';
 import useScreenWrapperTransitionStatus from '@hooks/useScreenWrapperTransitionStatus';
 import useTheme from '@hooks/useTheme';
@@ -94,25 +95,27 @@ export default function useAnimatedHighlightStyle({
             return;
         }
         setStartHighlight(false);
-        runOnJS(() => {
-            nonRepeatableProgress.set(
-                withDelay(
-                    itemEnterDelay,
-                    withTiming(1, {duration: itemEnterDuration, easing: Easing.inOut(Easing.ease)}, (finished) => {
-                        if (!finished) {
-                            return;
-                        }
-
-                        repeatableProgress.set(
-                            withSequence(
-                                withDelay(highlightStartDelay, withTiming(1, {duration: highlightStartDuration, easing: Easing.inOut(Easing.ease)})),
-                                withDelay(highlightEndDelay, withTiming(0, {duration: highlightEndDuration, easing: Easing.inOut(Easing.ease)})),
-                            ),
-                        );
-                    }),
-                ),
-            );
-        })();
+        InteractionManager.runAfterInteractions(() => {
+            runOnJS(() => {
+                nonRepeatableProgress.set(
+                    withDelay(
+                        itemEnterDelay,
+                        withTiming(1, {duration: itemEnterDuration, easing: Easing.inOut(Easing.ease)}, (finished) => {
+                            if (!finished) {
+                                return;
+                            }
+
+                            repeatableProgress.set(
+                                withSequence(
+                                    withDelay(highlightStartDelay, withTiming(1, {duration: highlightStartDuration, easing: Easing.inOut(Easing.ease)})),
+                                    withDelay(highlightEndDelay, withTiming(0, {duration: highlightEndDuration, easing: Easing.inOut(Easing.ease)})),
+                                ),
+                            );
+                        }),
+                    ),
+                );
+            })();
+        });
     }, [
         didScreenTransitionEnd,
         startHighlight,

src/libs/actions/IOU.ts

@@ -11923,9 +11923,8 @@ function saveSplitTransactions(draftTransaction: OnyxEntry<OnyxTypes.Transaction
         failureData.push(...(onyxData.failureData ?? []));
     });
 
-    // The new expenses are added to Onyx using the SET method. We use SET here as well to ensure the original transaction update isn't delayed.
     optimisticData.push({
-        onyxMethod: Onyx.METHOD.SET,
+        onyxMethod: Onyx.METHOD.MERGE,
         key: `${ONYXKEYS.COLLECTION.TRANSACTION}${originalTransactionID}`,
         value: {
             ...originalTransaction,