Skip to content

Commit d485575

Browse files
committed
Bring back useMemo
1 parent 8b4becc commit d485575

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/components/Search/FilterDropdowns/DropdownButton.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,12 @@ function DropdownButton({label, value, viewportOffsetTop, PopoverComponent}: Dro
102102
return {width: CONST.POPOVER_DROPDOWN_WIDTH};
103103
}, [isSmallScreenWidth, styles]);
104104

105+
const popoverContent = useMemo(() => {
106+
return PopoverComponent({closeOverlay: toggleOverlay});
107+
// PopoverComponent is stable so we don't need it here as a dep.
108+
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
109+
}, [isOverlayVisible, toggleOverlay]);
110+
105111
return (
106112
<>
107113
{/* Dropdown Trigger */}
@@ -143,7 +149,7 @@ function DropdownButton({label, value, viewportOffsetTop, PopoverComponent}: Dro
143149
}}
144150
shouldSkipRemeasurement
145151
>
146-
<PopoverComponent closeOverlay={toggleOverlay} />
152+
{popoverContent}
147153
</PopoverWithMeasuredContent>
148154
</>
149155
);

0 commit comments

Comments
 (0)