Merge branch 'Expensify:main' into 74999-member-admin-option-is-displayed-in-singular-when-several-users-are-selected

Author: abbasifaizan70

.env.example

@@ -42,3 +42,4 @@ GITHUB_TOKEN=YOUR_TOKEN
 OPENAI_API_KEY=YOUR_TOKEN
 
 SENTRY_AUTH_TOKEN=SENTRY_AUTH_TOKEN
+SENTRY_ALLOW_FAILURE=true

.github/actions/javascript/createOrUpdateStagingDeploy/createOrUpdateStagingDeploy.ts

@@ -164,23 +164,21 @@ async function run(): Promise<IssuesCreateResponse | void> {
             });
 
             // Then make sure we include any demoted or closed blockers as well, and just check them off automatically
-            // eslint-disable-next-line unicorn/no-array-for-each
-            currentChecklistData?.deployBlockers.forEach((deployBlocker) => {
+            for (const deployBlocker of currentChecklistData?.deployBlockers ?? []) {
                 const isResolved = deployBlockers.findIndex((openBlocker) => openBlocker.number === deployBlocker.number) < 0;
                 deployBlockers.push({
                     ...deployBlocker,
                     isResolved,
                 });
-            });
+            }
 
             // Include any existing Mobile-Expensify PRs from the current checklist that aren't in the new merged list
-            // eslint-disable-next-line unicorn/no-array-for-each
-            currentChecklistData?.PRListMobileExpensify.forEach((existingPR) => {
+            for (const existingPR of currentChecklistData?.PRListMobileExpensify ?? []) {
                 const isAlreadyIncluded = PRListMobileExpensify.findIndex((pr) => pr.number === existingPR.number) >= 0;
                 if (!isAlreadyIncluded) {
                     PRListMobileExpensify.push(existingPR);
                 }
-            });
+            }
 
             const didVersionChange = newVersion !== currentChecklistData?.version;
             const stagingDeployCashBodyAndAssignees = await GithubUtils.generateStagingDeployCashBodyAndAssignees(

.github/actions/javascript/createOrUpdateStagingDeploy/index.js

@@ -11674,22 +11674,20 @@ async function run() {
                 };
             });
             // Then make sure we include any demoted or closed blockers as well, and just check them off automatically
-            // eslint-disable-next-line unicorn/no-array-for-each
-            currentChecklistData?.deployBlockers.forEach((deployBlocker) => {
+            for (const deployBlocker of currentChecklistData?.deployBlockers ?? []) {
                 const isResolved = deployBlockers.findIndex((openBlocker) => openBlocker.number === deployBlocker.number) < 0;
                 deployBlockers.push({
                     ...deployBlocker,
                     isResolved,
                 });
-            });
+            }
             // Include any existing Mobile-Expensify PRs from the current checklist that aren't in the new merged list
-            // eslint-disable-next-line unicorn/no-array-for-each
-            currentChecklistData?.PRListMobileExpensify.forEach((existingPR) => {
+            for (const existingPR of currentChecklistData?.PRListMobileExpensify ?? []) {
                 const isAlreadyIncluded = PRListMobileExpensify.findIndex((pr) => pr.number === existingPR.number) >= 0;
                 if (!isAlreadyIncluded) {
                     PRListMobileExpensify.push(existingPR);
                 }
-            });
+            }
             const didVersionChange = newVersion !== currentChecklistData?.version;
             const stagingDeployCashBodyAndAssignees = await GithubUtils_1.default.generateStagingDeployCashBodyAndAssignees(newVersion, PRList.map((pr) => pr.url), PRListMobileExpensify.map((pr) => pr.url), PRList.filter((pr) => pr.isVerified).map((pr) => pr.url), PRListMobileExpensify.filter((pr) => pr.isVerified).map((pr) => pr.url), deployBlockers.map((blocker) => blocker.url), deployBlockers.filter((blocker) => blocker.isResolved).map((blocker) => blocker.url), currentChecklistData?.internalQAPRList.filter((pr) => pr.isResolved).map((pr) => pr.url), didVersionChange ? false : currentChecklistData.isFirebaseChecked, didVersionChange ? false : currentChecklistData.isGHStatusChecked);
             if (stagingDeployCashBodyAndAssignees) {

.github/actions/javascript/getGraphiteString/getGraphiteString.ts

@@ -23,14 +23,13 @@ const run = () => {
 
     // Initialize string to store Graphite metrics
     let graphiteString = '';
-    let timestamp: number;
+    let timestamp: number | null = null;
 
     // Iterate over each entry
-    // eslint-disable-next-line unicorn/no-array-for-each
-    regressionEntries.forEach((entry) => {
+    for (const entry of regressionEntries) {
         // Skip empty lines
         if (entry.trim() === '') {
-            return;
+            continue;
         }
 
         try {
@@ -56,7 +55,7 @@ const run = () => {
             console.error(error.message);
             core.setFailed(error);
         }
-    });
+    }
 
     // Set generated graphite string to the github variable
     core.setOutput('GRAPHITE_STRING', graphiteString);

.github/actions/javascript/getGraphiteString/index.js

@@ -2745,13 +2745,12 @@ const run = () => {
     const regressionEntries = regressionFile.split('\n');
     // Initialize string to store Graphite metrics
     let graphiteString = '';
-    let timestamp;
+    let timestamp = null;
     // Iterate over each entry
-    // eslint-disable-next-line unicorn/no-array-for-each
-    regressionEntries.forEach((entry) => {
+    for (const entry of regressionEntries) {
         // Skip empty lines
         if (entry.trim() === '') {
-            return;
+            continue;
         }
         try {
             const current = JSON.parse(entry);
@@ -2773,7 +2772,7 @@ const run = () => {
             console.error(error.message);
             core.setFailed(error);
         }
-    });
+    }
     // Set generated graphite string to the github variable
     core.setOutput('GRAPHITE_STRING', graphiteString);
 };

.github/workflows/deploy.yml

@@ -167,6 +167,7 @@ jobs:
           ANDROID_BUILD_TYPE: ${{ vars.ANDROID_BUILD_TYPE }}
           GITHUB_ACTOR: ${{ github.actor }}
           GITHUB_TOKEN: ${{ github.token }}
+          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
 
       - name: Upload Android app to Google Play
         if: ${{ fromJSON(env.SHOULD_BUILD_APP) }}
@@ -382,6 +383,7 @@ jobs:
           APPLE_SHARE_PROVISIONING_PROFILE_NAME: ${{ vars.APPLE_SHARE_PROVISIONING_PROFILE_NAME }}
           APPLE_NOTIFICATION_PROVISIONING_PROFILE_FILE: ${{ vars.APPLE_NOTIFICATION_PROVISIONING_PROFILE_FILE }}
           APPLE_NOTIFICATION_PROVISIONING_PROFILE_NAME: ${{ vars.APPLE_NOTIFICATION_PROVISIONING_PROFILE_NAME }}
+          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
 
       - name: Upload release build to TestFlight
         if: ${{ fromJSON(env.SHOULD_BUILD_APP) }}

.github/workflows/testBuild.yml

@@ -284,6 +284,7 @@ jobs:
           ANDROID_UPLOAD_KEY_PASSWORD: ${{ steps.load-credentials.outputs.ANDROID_UPLOAD_KEY_PASSWORD }}
           GITHUB_ACTOR: ${{ github.actor }}
           GITHUB_TOKEN: ${{ github.token }}
+          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
         run: bundle exec fastlane android build_adhoc_hybrid
 
       - name: Configure AWS Credentials

.nvmrc

@@ -1 +1 @@
-20.19.4
+20.19.5

Mobile-Expensify

@@ -114,8 +114,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009026700
-        versionName "9.2.67-0"
+        versionCode 1009027200
+        versionName "9.2.72-0"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"