fix: change policyTagList to transactionPolicyTagList

Author: jakubstec

__mocks__/reportData/violations.ts

@@ -33,7 +33,7 @@ const receiptErrorsR14932: ReceiptErrors = {
             transactionID: RECEIPT_ERRORS_TRANSACTION_ID_R14932,
             source: CONST.POLICY.ID_FAKE,
             transactionPolicy: undefined,
-            policyTagList: undefined,
+            transactionPolicyTagList: undefined,
         },
     },
 };

src/components/ReportActionItem/MoneyRequestReceiptView.tsx

@@ -443,7 +443,14 @@ function MoneyRequestReceiptView({
             return;
         }
         const source = URL.createObjectURL(file as Blob);
-        replaceReceipt({transactionID: linkedTransactionID, file: file as File, source, transactionPolicy: policy, transactionPolicyCategories: policyCategories, policyTagList});
+        replaceReceipt({
+            transactionID: linkedTransactionID,
+            file: file as File,
+            source,
+            transactionPolicy: policy,
+            transactionPolicyCategories: policyCategories,
+            transactionPolicyTagList: policyTagList,
+        });
     };
 
     // For empty receipt should be fullHeight

src/libs/ReceiptUploadRetryHandler/handleFileRetry.ts

@@ -13,6 +13,9 @@ export default function handleFileRetry(message: ReceiptError, file: File, dismi
 
     switch (message.action) {
         case CONST.IOU.ACTION_PARAMS.REPLACE_RECEIPT: {
+            console.log('message: ', message);
+            console.log('retryParams: ', retryParams);
+
             dismissError();
             const replaceReceiptParams = {...retryParams} as IOU.ReplaceReceipt;
             replaceReceiptParams.file = file;

src/libs/ReceiptUploadRetryHandler/index.ts

@@ -15,6 +15,8 @@ export default function handleRetryPress(message: ReceiptError, dismissError: ()
             handleFileRetry(message, reconstructedFile, dismissError, setShouldShowErrorModal);
         })
         .catch(() => {
+            console.error('retry fetch failed:', message.source);
+            console.error('message:', message);
             setShouldShowErrorModal(true);
         });
 }

src/libs/actions/IOU/Receipt.ts

@@ -160,7 +160,7 @@ function detachReceipt(
     );
 }
 
-function replaceReceipt({transactionID, file, source, state, transactionPolicy, transactionPolicyCategories, isSameReceipt, policyTagList}: ReplaceReceipt) {
+function replaceReceipt({transactionID, file, source, state, transactionPolicy, transactionPolicyCategories, isSameReceipt, transactionPolicyTagList}: ReplaceReceipt) {
     if (!file) {
         return;
     }
@@ -179,7 +179,7 @@ function replaceReceipt({transactionID, file, source, state, transactionPolicy,
         filename: file.name,
     };
     const newTransaction = transaction && {...transaction, receipt: receiptOptimistic};
-    const retryParams: ReplaceReceipt = {transactionID, file: undefined, source, transactionPolicy, transactionPolicyCategories, policyTagList};
+    const retryParams: ReplaceReceipt = {transactionID, file: undefined, source, transactionPolicy, transactionPolicyCategories, transactionPolicyTagList};
     const currentSearchQueryJSON = getCurrentSearchQueryJSON();
 
     const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.TRANSACTION | typeof ONYXKEYS.COLLECTION.SNAPSHOT | typeof ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS>> = [
@@ -228,9 +228,9 @@ function replaceReceipt({transactionID, file, source, state, transactionPolicy,
             newTransaction,
             currentTransactionViolations,
             transactionPolicy,
-            policyTagList ?? {},
+            transactionPolicyTagList ?? {},
             transactionPolicyCategories ?? {},
-            hasDependentTags(transactionPolicy, policyTagList ?? {}),
+            hasDependentTags(transactionPolicy, transactionPolicyTagList ?? {}),
             isInvoiceReportReportUtils(expenseReport),
         );
         optimisticData.push(violationsOnyxData);

src/libs/actions/IOU/index.ts

@@ -417,7 +417,7 @@ type ReplaceReceipt = {
     transactionPolicyCategories?: OnyxEntry<OnyxTypes.PolicyCategories>;
     transactionPolicy: OnyxEntry<OnyxTypes.Policy>;
     isSameReceipt?: boolean;
-    policyTagList: OnyxEntry<OnyxTypes.PolicyTagLists>;
+    transactionPolicyTagList: OnyxEntry<OnyxTypes.PolicyTagLists>;
 };
 
 type GetSearchOnyxUpdateParams = {

src/pages/inbox/report/ReportActionCompose/useAttachmentUploadValidation.ts

@@ -95,7 +95,14 @@ function useAttachmentUploadValidation({
 
         if (shouldAddOrReplaceReceipt && transactionID) {
             const source = URL.createObjectURL(files.at(0) as Blob);
-            replaceReceipt({transactionID, file: files.at(0) as File, source, transactionPolicy: policy, transactionPolicyCategories: policyCategories, policyTagList});
+            replaceReceipt({
+                transactionID,
+                file: files.at(0) as File,
+                source,
+                transactionPolicy: policy,
+                transactionPolicyCategories: policyCategories,
+                transactionPolicyTagList: policyTagList,
+            });
             return;
         }
 

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

@@ -217,7 +217,14 @@ function IOURequestStepScan({
             } else {
                 navigateBack();
             }
-            replaceReceipt({transactionID: initialTransactionID, file: file as File, source, transactionPolicy: policy, transactionPolicyCategories: policyCategories, policyTagList});
+            replaceReceipt({
+                transactionID: initialTransactionID,
+                file: file as File,
+                source,
+                transactionPolicy: policy,
+                transactionPolicyCategories: policyCategories,
+                transactionPolicyTagList: policyTagList,
+            });
         },
         [initialTransactionID, policy, policyCategories, backTo, navigateBack, policyTagList],
     );

src/pages/iou/request/step/IOURequestStepScan/index.tsx

@@ -53,7 +53,14 @@ function IOURequestStepScan({
 
     const updateScanAndNavigate = useCallback(
         (file: FileObject, source: string) => {
-            replaceReceipt({transactionID: initialTransactionID, file: file as File, source, transactionPolicy: policy, transactionPolicyCategories: policyCategories, policyTagList});
+            replaceReceipt({
+                transactionID: initialTransactionID,
+                file: file as File,
+                source,
+                transactionPolicy: policy,
+                transactionPolicyCategories: policyCategories,
+                transactionPolicyTagList: policyTagList,
+            });
             navigateBack();
         },
         [initialTransactionID, navigateBack, policy, policyCategories, policyTagList],

src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx

@@ -300,7 +300,7 @@ function TransactionReceiptModalContent({navigation, route}: AttachmentModalScre
                         source: durableUri,
                         transactionPolicyCategories: policyCategories,
                         transactionPolicy: policy,
-                        policyTagList,
+                        transactionPolicyTagList: policyTagList,
                         ...(isSameReceipt ? {state: transaction?.receipt?.state, isSameReceipt: true} : {}),
                     });
                 }