fix prop name, icon alignment, and comment.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Author: Krishna2323

src/components/MoneyRequestAmountInput.tsx

@@ -96,7 +96,7 @@ type MoneyRequestAmountInputProps = {
 
     /** The testID of the input. Used to locate this view in end-to-end tests. */
     testID?: string;
-} & Pick<TextInputWithCurrencySymbolProps, 'autoGrowExtraSpace' | 'submitBehavior' | 'shouldPrefixUseDefaultLineHeight'>;
+} & Pick<TextInputWithCurrencySymbolProps, 'autoGrowExtraSpace' | 'submitBehavior' | 'shouldUseDefaultLineHeightForPrefix'>;
 
 type Selection = {
     start: number;
@@ -136,7 +136,7 @@ function MoneyRequestAmountInput(
         testID,
         submitBehavior,
         shouldApplyPaddingToContainer = false,
-        shouldPrefixUseDefaultLineHeight = true,
+        shouldUseDefaultLineHeightForPrefix = true,
         ...props
     }: MoneyRequestAmountInputProps,
     forwardedRef: ForwardedRef<BaseTextInputRef>,
@@ -349,7 +349,7 @@ function MoneyRequestAmountInput(
             testID={testID}
             submitBehavior={submitBehavior}
             shouldApplyPaddingToContainer={shouldApplyPaddingToContainer}
-            shouldPrefixUseDefaultLineHeight={shouldPrefixUseDefaultLineHeight}
+            shouldUseDefaultLineHeightForPrefix={shouldUseDefaultLineHeightForPrefix}
         />
     );
 }

src/components/TextInput/BaseTextInput/implementation/index.native.tsx

@@ -78,7 +78,7 @@ function BaseTextInput(
         placeholderTextColor,
         onClearInput,
         iconContainerStyle,
-        shouldPrefixUseDefaultLineHeight = true,
+        shouldUseDefaultLineHeightForPrefix = true,
         ...props
     }: BaseTextInputProps,
     ref: ForwardedRef<BaseTextInputRef>,
@@ -359,7 +359,7 @@ function BaseTextInput(
                                         tabIndex={-1}
                                         style={[styles.textInputPrefix, !hasLabel && styles.pv0, styles.pointerEventsNone, prefixStyle]}
                                         dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
-                                        shouldUseDefaultLineHeight={!!shouldPrefixUseDefaultLineHeight && !shouldApplyHeight}
+                                        shouldUseDefaultLineHeight={!!shouldUseDefaultLineHeightForPrefix && !shouldApplyHeight}
                                     >
                                         {prefixCharacter}
                                     </Text>

src/components/TextInput/BaseTextInput/implementation/index.tsx

@@ -80,7 +80,7 @@ function BaseTextInput(
         placeholderTextColor,
         onClearInput,
         iconContainerStyle,
-        shouldPrefixUseDefaultLineHeight = true,
+        shouldUseDefaultLineHeightForPrefix = true,
         ...inputProps
     }: BaseTextInputProps,
     ref: ForwardedRef<BaseTextInputRef>,
@@ -369,7 +369,7 @@ function BaseTextInput(
                                         tabIndex={-1}
                                         style={[styles.textInputPrefix, !hasLabel && styles.pv0, styles.pointerEventsNone, prefixStyle]}
                                         dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
-                                        shouldUseDefaultLineHeight={shouldPrefixUseDefaultLineHeight}
+                                        shouldUseDefaultLineHeight={shouldUseDefaultLineHeightForPrefix}
                                     >
                                         {prefixCharacter}
                                     </Text>

src/components/TextInput/BaseTextInput/types.ts

@@ -187,8 +187,8 @@ type CustomBaseTextInputProps = {
     /** Whether the input should be enforced to take full height of container. Default is `false` */
     shouldUseFullInputHeight?: boolean;
 
-    /** Whether the input prefix should use the default text line height */
-    shouldPrefixUseDefaultLineHeight?: boolean;
+    /** Whether the input prefix should use the default `Text` line height fallback. Disable this if you intentionally want the prefix to have `lineHeight: undefined` */
+    shouldUseDefaultLineHeightForPrefix?: boolean;
 };
 
 type BaseTextInputRef = HTMLFormElement | AnimatedTextInputRef;

src/components/TextInputWithCurrencySymbol/types.ts

@@ -83,7 +83,7 @@ type BaseTextInputWithCurrencySymbolProps = {
 
     /** The test ID of TextInput. Used to locate the view in end-to-end tests. */
     testID?: string;
-} & Pick<BaseTextInputProps, 'autoFocus' | 'autoGrow' | 'autoGrowExtraSpace' | 'contentWidth' | 'onPress' | 'submitBehavior' | 'shouldPrefixUseDefaultLineHeight'>;
+} & Pick<BaseTextInputProps, 'autoFocus' | 'autoGrow' | 'autoGrowExtraSpace' | 'contentWidth' | 'onPress' | 'submitBehavior' | 'shouldUseDefaultLineHeightForPrefix'>;
 
 type TextInputWithCurrencySymbolProps = Omit<BaseTextInputWithCurrencySymbolProps, 'onSelectionChange'> & {
     onSelectionChange?: (start: number, end: number) => void;

src/styles/utils/index.ts

@@ -1385,7 +1385,7 @@ const createStyleUtils = (theme: ThemeColors, styles: ThemeStyles) => ({
         const paddingStyle = includePadding ? {paddingHorizontal: 11} : {};
         return {
             ...paddingStyle,
-            marginTop: hasLabel ? 8 : 16,
+            marginTop: hasLabel ? variables.inputIconMarginTopSmall : variables.inputIconMarginTopLarge,
         };
     },
 

src/styles/variables.ts

@@ -124,6 +124,8 @@ export default {
     inputPaddingTop: getValueUsingPixelRatio(15, 21),
     inputPaddingBottom: getValueUsingPixelRatio(8, 11),
     inputHeightSmall: 28,
+    inputIconMarginTopSmall: getValueUsingPixelRatio(8, 11),
+    inputIconMarginTopLarge: getValueUsingPixelRatio(16, 21),
     formErrorLineHeight: getValueUsingPixelRatio(18, 23),
     communicationsLinkHeight: getValueUsingPixelRatio(20, 30),
     alternateTextHeight: getValueUsingPixelRatio(20, 24),