Skip to content

Commit e041033

Browse files
committed
Merge remote-tracking branch 'upstream/main' into 67608-category-tag-list-deselected-when-editing-name
2 parents 900112e + 0020ebc commit e041033

160 files changed

Lines changed: 1707 additions & 1345 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,3 +153,6 @@ react-compiler-output.txt
153153

154154
# Generated by bob (for Nitro modules)
155155
modules/*/lib/
156+
157+
# Claude Code files
158+
.claude/

Mobile-Expensify

__mocks__/@ua/react-native-airship.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,6 @@ enum EventType {
66
PushReceived = 'com.airship.push_received',
77
}
88

9-
// eslint-disable-next-line no-restricted-syntax
10-
enum PermissionStatus {
11-
Granted = 'granted',
12-
Denied = 'denied',
13-
NotDetermined = 'not_determined',
14-
}
15-
169
// eslint-disable-next-line @typescript-eslint/no-namespace
1710
namespace iOS {
1811
/**
@@ -78,4 +71,4 @@ const Airship: Partial<AirshipRoot> = {
7871

7972
export default Airship;
8073

81-
export {EventType, iOS, PermissionStatus};
74+
export {EventType, iOS};

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ android {
114114
minSdkVersion rootProject.ext.minSdkVersion
115115
targetSdkVersion rootProject.ext.targetSdkVersion
116116
multiDexEnabled rootProject.ext.multiDexEnabled
117-
versionCode 1009018915
118-
versionName "9.1.89-15"
117+
versionCode 1009018920
118+
versionName "9.1.89-20"
119119
// Supported language variants must be declared here to avoid from being removed during the compilation.
120120
// This also helps us to not include unnecessary language variants in the APK.
121121
resConfigs "en", "es"

contributingGuides/STYLE.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1269,8 +1269,10 @@ The correct approach is avoid using `ScrollView`. You can add props like `listHe
12691269
</ScrollView>
12701270
```
12711271
1272-
### Correct Approach (Using `SelectionList`)
1272+
### Correct Approach
1273+
The correct approach is to use the list component's built-in header and footer props instead of wrapping in a `ScrollView`:
12731274
1275+
- Using `SelectionList`
12741276
```jsx
12751277
<SelectionList
12761278
sections={[{item}]}
@@ -1281,6 +1283,20 @@ The correct approach is avoid using `ScrollView`. You can add props like `listHe
12811283
/>
12821284
```
12831285
1286+
- If you can't switch to `SelectionList` or `FlatList`, you can use `FlashList` as an alternative approach:
1287+
```jsx
1288+
<ScrollView>
1289+
<Text>Header Content</Text>
1290+
<FlashList
1291+
data={data}
1292+
renderItem={RadioListItem}
1293+
estimatedItemSize={variables.optionRowHeight}
1294+
keyExtractor={keyExtractor}
1295+
/>
1296+
<Button title="Submit" onPress={handleSubmit} />
1297+
</ScrollView>
1298+
```
1299+
12841300
This ensures optimal performance and avoids layout issues.
12851301
12861302

ios/NewExpensify/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</dict>
4545
</array>
4646
<key>CFBundleVersion</key>
47-
<string>9.1.89.15</string>
47+
<string>9.1.89.20</string>
4848
<key>FullStory</key>
4949
<dict>
5050
<key>OrgId</key>

ios/NotificationServiceExtension/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.1.89</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.1.89.15</string>
16+
<string>9.1.89.20</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionPointIdentifier</key>

ios/ShareViewController/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<key>CFBundleShortVersionString</key>
1414
<string>9.1.89</string>
1515
<key>CFBundleVersion</key>
16-
<string>9.1.89.15</string>
16+
<string>9.1.89.20</string>
1717
<key>NSExtension</key>
1818
<dict>
1919
<key>NSExtensionAttributes</key>

modules/hybrid-app/android/src/main/java/com/expensify/reactnativehybridapp/ReactNativeHybridApp.kt

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -51,22 +51,4 @@ class ReactNativeHybridApp(reactContext: ReactApplicationContext) :
5151
override fun onURLListenerAdded() {
5252
Log.d(NAME, "`onURLListenerAdded` should never be called in standalone `New Expensify` app")
5353
}
54-
55-
override fun signInToOldDot(
56-
autoGeneratedLogin: String,
57-
autoGeneratedPassword: String,
58-
authToken: String,
59-
email: String,
60-
policyID: String
61-
) {
62-
Log.d(NAME, "`signInToOldDot` should never be called in standalone `New Expensify` app")
63-
}
64-
65-
override fun signOutFromOldDot() {
66-
Log.d(NAME, "`signOutFromOldDot` should never be called in standalone `New Expensify` app")
67-
}
68-
69-
override fun clearOldDotAfterSignOut() {
70-
Log.d(NAME, "`clearOldDotAfterSignOut` should never be called in standalone `New Expensify` app")
71-
}
7254
}

modules/hybrid-app/ios/ReactNativeHybridApp.mm

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,6 @@ - (void)onURLListenerAdded {
4343
NSLog(@"[ReactNativeHybridApp] `onURLListenerAdded` should never be called in standalone `New Expensify` app");
4444
}
4545

46-
- (void)signInToOldDot:(NSString *)autoGeneratedLogin autoGeneratedPassword:(NSString *)autoGeneratedPassword authToken:(NSString *)authToken email:(NSString *)email policyID:(NSString *)policyID {
47-
NSLog(@"[ReactNativeHybridApp] `signInToOldDot` should never be called in standalone `New Expensify` app");
48-
}
49-
50-
- (void)signOutFromOldDot {
51-
NSLog(@"[ReactNativeHybridApp] `signOutFromOldDot` should never be called in standalone `New Expensify` app");
52-
}
53-
54-
- (void)clearOldDotAfterSignOut {
55-
NSLog(@"[ReactNativeHybridApp] `clearOldDotAfterSignOut` should never be called in standalone `New Expensify` app");
56-
}
57-
5846
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
5947
(const facebook::react::ObjCTurboModule::InitParams &)params
6048
{

0 commit comments

Comments
 (0)