Skip to content

Commit e25ee77

Browse files
authored
Merge pull request Expensify#88204 from Expensify/claude-hidePrivateNotesBeta
Hide Private Notes behind beta flag
2 parents f8263d4 + 525005c commit e25ee77

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

src/libs/Permissions.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,16 @@ function canUseTrackFlows(): boolean {
3535
return false;
3636
}
3737

38+
/**
39+
* Private notes are temporarily disabled.
40+
*/
41+
function canUsePrivateNotes(): boolean {
42+
return false;
43+
}
44+
3845
export default {
3946
canUseLinkPreviews,
4047
canUseTrackFlows,
48+
canUsePrivateNotes,
4149
isBetaEnabled,
4250
};

src/pages/ProfilePage.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
2525
import createDynamicRoute from '@libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute';
2626
import Navigation from '@libs/Navigation/Navigation';
2727
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
28+
import Permissions from '@libs/Permissions';
2829
import {getDisplayNameOrDefault, getPhoneNumber} from '@libs/PersonalDetailsUtils';
2930
import {
3031
findSelfDMReportID,
@@ -268,7 +269,7 @@ function ProfilePage({route}: ProfilePageProps) {
268269
}}
269270
/>
270271
)}
271-
{!isEmptyObject(report) && !!report.reportID && !isCurrentUser && (
272+
{Permissions.canUsePrivateNotes() && !isEmptyObject(report) && !!report.reportID && !isCurrentUser && (
272273
<MenuItem
273274
title={`${translate('privateNotes.title')}`}
274275
titleStyle={styles.flex1}

src/pages/ReportDetailsPage.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,8 @@ function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetail
326326
const isWorkspaceChat = useMemo(() => isWorkspaceChatUtil(report?.chatType ?? ''), [report?.chatType]);
327327

328328
useEffect(() => {
329-
// Do not fetch private notes if isLoadingPrivateNotes is already defined, or if the network is offline, or if the report is a self DM.
330-
if (isPrivateNotesFetchTriggered || isOffline || isSelfDM) {
329+
// Do not fetch private notes if the feature is disabled, isLoadingPrivateNotes is already defined, the network is offline, or if the report is a self DM.
330+
if (!Permissions.canUsePrivateNotes() || isPrivateNotesFetchTriggered || isOffline || isSelfDM) {
331331
return;
332332
}
333333

@@ -529,8 +529,8 @@ function ReportDetailsPage({policy, report, route, reportMetadata}: ReportDetail
529529
}
530530
}
531531

532-
// Prevent displaying private notes option for threads and task reports
533-
if (!isChatThread && !isMoneyRequestReport && !isInvoiceReport && !isTaskReport) {
532+
// Prevent displaying private notes option for threads and task reports, or when the feature is disabled
533+
if (Permissions.canUsePrivateNotes() && !isChatThread && !isMoneyRequestReport && !isInvoiceReport && !isTaskReport) {
534534
items.push({
535535
key: CONST.REPORT_DETAILS_MENU_ITEM.PRIVATE_NOTES,
536536
translationKey: 'privateNotes.title',

0 commit comments

Comments
 (0)