Commit e2df690
Trim + uppercase source currency in Formula.formatAmount
Mirror the trim+uppercase already applied to displayCurrency at the top
of formatAmount so the source-currency branch validates against the
canonical form. Previously a case- or whitespace-only variant of the
source currency (e.g. 'eur') failed the strict isValidCurrencyCode
gate and returned an empty string, forcing the placeholder upstream
even though the value was just non-canonical. Side benefit: the
'currency !== trimmedDisplayCurrency' comparison no longer reports a
false mismatch for the same currency in different casing.
Added two regression tests under Currency Formatting & Conversion >
Edge cases verifying that 'eur' and ' USD ' format like their
canonical-case counterparts.
Addresses PR review comment from @lakchote.
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent dbcb3c8 commit e2df690
2 files changed
Lines changed: 24 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
567 | 567 | | |
568 | 568 | | |
569 | 569 | | |
| 570 | + | |
570 | 571 | | |
571 | 572 | | |
572 | 573 | | |
573 | | - | |
| 574 | + | |
574 | 575 | | |
575 | 576 | | |
576 | 577 | | |
577 | 578 | | |
578 | 579 | | |
579 | | - | |
| 580 | + | |
580 | 581 | | |
581 | 582 | | |
582 | 583 | | |
| |||
588 | 589 | | |
589 | 590 | | |
590 | 591 | | |
591 | | - | |
| 592 | + | |
592 | 593 | | |
593 | | - | |
| 594 | + | |
594 | 595 | | |
595 | 596 | | |
596 | | - | |
| 597 | + | |
597 | 598 | | |
598 | 599 | | |
599 | 600 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
503 | 503 | | |
504 | 504 | | |
505 | 505 | | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
506 | 524 | | |
507 | 525 | | |
508 | 526 | | |
| |||
0 commit comments