refactor code

Author: dmkt9

src/libs/ReportActionsUtils.ts

@@ -1249,13 +1249,16 @@ const isIOUActionMatchingTransactionList = (
 /**
  * Gets the reportID for the transaction thread associated with a report by iterating over the reportActions and identifying the IOU report actions.
  * Returns a reportID if there is exactly one transaction thread for the report, and null otherwise.
+ *
+ * @param ignoreAllDeletedReportActions Filter out all deleted reportActions, even if they have visible childActions.
  */
 function getOneTransactionThreadReportID(
     report: OnyxEntry<Report>,
     chatReport: OnyxEntry<Report>,
     reportActions: OnyxEntry<ReportActions> | ReportAction[],
     isOffline: boolean | undefined = undefined,
     reportTransactionIDs?: string[],
+    ignoreAllDeletedReportActions = false,
 ): string | undefined {
     // If the report is not an IOU, Expense report, or Invoice, it shouldn't be treated as one-transaction report.
     if (report?.type !== CONST.REPORT.TYPE.IOU && report?.type !== CONST.REPORT.TYPE.EXPENSE && report?.type !== CONST.REPORT.TYPE.INVOICE) {
@@ -1294,7 +1297,7 @@ function getOneTransactionThreadReportID(
             // - the action is pending deletion and the user is offline
             (!!originalMessage?.IOUTransactionID ||
                 // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-                (isMessageDeleted(action) && action.childVisibleActionCount) ||
+                (ignoreAllDeletedReportActions ? !isMessageDeleted(action) : isMessageDeleted(action) && action.childVisibleActionCount) ||
                 (action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && (isOffline ?? isNetworkOffline)))
         ) {
             iouRequestActions.push(action);

src/libs/ReportUtils.ts

@@ -8872,18 +8872,16 @@ function navigateToLinkedReportAction(ancestor: Ancestor, isInNarrowPaneModal: b
     let newAncestor = ancestor;
     // If `parentReport` is an money report with one transaction, navigate directly to `parentReport`,
     // preventing redundant navigation when threading back to the parent chat thread
-    if (parentReport && parentReportAction) {
-        const allParentReportActions = getReportActions(parentReport);
-        const visibleParentReportActions = Object.values(allParentReportActions ?? {}).filter(
-            (action) => !isMessageDeleted(action) || (action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && isOffline),
-        );
-        if (getOneTransactionThreadReportID(parentReport, getReportOrDraftReport(parentReport.chatReportID), visibleParentReportActions)) {
-            newAncestor = {
-                ...ancestor,
-                report: parentReport,
-                reportAction: parentReportAction,
-            };
-        }
+    if (
+        parentReport &&
+        parentReportAction &&
+        getOneTransactionThreadReportID(parentReport, getReportOrDraftReport(parentReport.chatReportID), getReportActions(parentReport), isOffline, undefined, true)
+    ) {
+        newAncestor = {
+            ...ancestor,
+            report: parentReport,
+            reportAction: parentReportAction,
+        };
     }
 
     if (isInNarrowPaneModal) {

src/pages/home/HeaderView.tsx

@@ -36,7 +36,7 @@ import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
 import Navigation from '@libs/Navigation/Navigation';
 import {getPersonalDetailsForAccountIDs} from '@libs/OptionsListUtils';
 import Parser from '@libs/Parser';
-import {getOneTransactionThreadReportID, getReportActions, isMessageDeleted} from '@libs/ReportActionsUtils';
+import {getOneTransactionThreadReportID, getReportActions} from '@libs/ReportActionsUtils';
 import {
     canJoinChat,
     canUserPerformWriteAction,
@@ -142,18 +142,17 @@ function HeaderView({report, parentReportAction, onNavigationMenuButtonClicked,
     const isTaskReport = isTaskReportReportUtils(report);
     const [parentOfParentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${parentReport?.parentReportID}`, {canBeMissing: true});
     const {isOffline} = useNetwork();
-    const visibleParentOfParentReportActions = useMemo(() => {
-        if (!parentOfParentReport) {
-            return;
-        }
-
-        const allReportActions = getReportActions(parentOfParentReport);
-        return Object.values(allReportActions ?? {}).filter((action) => !isMessageDeleted(action) || (action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && isOffline));
-    }, [parentOfParentReport, isOffline]);
     const reportHeaderData =
         ((!isTaskReport && !isChatThread) ||
             (parentOfParentReport &&
-                !!getOneTransactionThreadReportID(parentOfParentReport, getReportOrDraftReport(parentOfParentReport?.chatReportID), visibleParentOfParentReportActions))) &&
+                !!getOneTransactionThreadReportID(
+                    parentOfParentReport,
+                    getReportOrDraftReport(parentOfParentReport?.chatReportID),
+                    getReportActions(parentOfParentReport),
+                    isOffline,
+                    undefined,
+                    true,
+                ))) &&
         report?.parentReportID
             ? parentReport
             : report;