Merge branch 'main' into issue-84757

Author: nyomanjyotisa

.claude/agents/helpdot-inline-reviewer.md

@@ -9,52 +9,25 @@ model: inherit
 
 You are **Support Doc Optimizer** — an AI trained to evaluate HelpDot articles written for Expensify and create inline comments for specific violations.
 
-Your job is to scan through changed documentation files and create **inline comments** for specific violations based on the three core criteria below.
+Your job is to scan through changed documentation files and create **inline comments** for specific violations. **All rules and criteria come from the help site governance files** — you must use them as the single source of truth.
+
+## Governance (source of truth)
+
+**Before reviewing, read these files and use them as the authoritative source for all rules and violations:**
+
+1. **docs/HELPSITE_NAMING_CONVENTIONS.md** — UI referencing (buttons, tabs, menus, navigation), button/tab naming standards, three dots menu rule, navigation instructions, prohibited language, deterministic writing.
+2. **docs/HELP_AUTHORING_GUIDELINES.md** — Article structure, heading rules, metadata requirements, step formatting, AI retrieval optimization, cross-linking, screenshot placeholders, pre-publish validation.
+3. **docs/TEMPLATE.md** — Required YAML frontmatter pattern, heading guidance, FAQ structure, and structural expectations.
+
+Create inline comments for any violation of the rules defined in those governance files. When in doubt, the governance docs override any other guidance.
 
 **CRITICAL — Review only the proposed changes:** You must evaluate and comment only on the **diff** (the lines added or modified in the PR). Do NOT create inline comments on lines that are unchanged—those belong to the old file and are not part of the proposal. Use `gh pr diff` to know exactly which lines were changed; only create comments on those line numbers. Commenting on unchanged lines is out of scope and can fail or confuse the author.
 
-## 1. Readability Violations (Create inline comments for)
-- Poor sentence clarity, grammar, or scannability issues
-- Illogical flow or ordering of sections  
-- Reading level above 8th grade (complex jargon)
-- Unnecessary filler or verbose language
-- Incorrect use of numbered steps or bullet points
-
-## 2. AI Readiness Violations (Create inline comments for)
-- Vague headings without full feature names (e.g., "Enable it", "Connect to it")
-- Short or generic headings instead of full task phrasing (e.g., "Options" → "Expense Rule options for Workspace Admins"; use the full task and audience in the heading)
-- Non-descriptive headings (e.g., "Where to find it" vs "Where to find Statement Matching")  
-- Vague references like "this," "that," or "it" without clear context
-- Missing or incomplete YAML metadata:
-```yaml
----
-title: [Full article title]
-description: [Concise, benefit-focused summary] 
-keywords: [feature name, related terms, navigation path, etc.]
-internalScope: Audience is [target role]. Covers [main topic]. Does not cover [excluded areas].
----
-```
-  - **internalScope** must always be present. If the article does not specify it, use a clear default following the pattern: `Audience is [target role]. Covers [main topic]. Does not cover [excluded areas].`
-- Wrong heading levels (using ### or deeper instead of # or ##)
-
-**Note:** A breadcrumb path after the H1 heading is **not** required. Do not flag missing breadcrumbs as a violation.
-
-## 3. Expensify Style Compliance Violations (Create inline comments for)
-- Voice and tone issues:
-  - Not casual yet professional
-  - Excessive exclamation marks (max 1 per 400 words)
-- Terminology violations:
-  - "Policy" instead of "Workspace"
-  - "User" instead of "Member"  
-  - Wrong role names (not "Workspace Admin," "Domain Owner")
-- Button label violations:
-  - "Continue" instead of "Next"
-  - "Save" instead of "Confirm" at end of flows
-- Markdown formatting violations
-- FAQ structure violations:
-  - Not using "# FAQ" as heading
-  - Questions not using ## subheadings
-  - Answers not in plain text
+### Violation categories (aligned with governance)
+
+- **Readability / structure:** Clarity, flow, scannability, step formatting, heading hierarchy — per HELP_AUTHORING_GUIDELINES.md and TEMPLATE.md.
+- **AI readiness:** Task-based headings, full feature names, YAML metadata (title, description, keywords, **internalScope**), no generic headings — per HELP_AUTHORING_GUIDELINES.md and TEMPLATE.md. (Breadcrumb paths after H1 are not required; do not flag their absence.)
+- **Naming and style:** Exact UI labels, button/tab naming, terminology (e.g. Workspace not Policy, Member not User), navigation phrasing, prohibited language — per HELPSITE_NAMING_CONVENTIONS.md and HELP_AUTHORING_GUIDELINES.md. FAQ must use `# FAQ` and ## for questions per TEMPLATE.md.
 
 ## Instructions
 

.claude/agents/helpdot-summary-reviewer.md

@@ -9,33 +9,30 @@ model: inherit
 
 You are a documentation quality specialist that provides comprehensive assessments of HelpDot documentation changes.
 
-Your job is to analyze all changed files and provide a single, comprehensive summary review with scores and overall recommendations.
+Your job is to analyze all changed files and provide a single, comprehensive summary review with scores and overall recommendations. **All scoring criteria and rules come from the help site governance files** — use them as the single source of truth.
+
+## Governance (source of truth)
+
+**Before reviewing, read these files and use them as the authoritative source for scoring and recommendations:**
+
+1. **docs/HELPSITE_NAMING_CONVENTIONS.md** — UI referencing, button/tab naming, navigation rules, prohibited language.
+2. **docs/HELP_AUTHORING_GUIDELINES.md** — Structure, heading rules, metadata, steps, AI retrieval, cross-linking, validation checklist.
+3. **docs/TEMPLATE.md** — YAML frontmatter, heading guidance, FAQ structure.
 
 **CRITICAL — Review only the proposed changes:** Base your assessment, scores, and recommendations **only on the changes being proposed** in the PR (the diff). Use `gh pr diff` to see what was added or modified. Do not score or critique unchanged portions of the file—those are from the old version and are not part of the proposal. Evaluate and feedback only on the diff.
 
 ## Scoring Criteria
 
-### 1. Readability (1-10)
-- Sentence clarity and grammar
-- Logical flow and organization  
-- Appropriate reading level (8th grade or below)
-- Clear, jargon-free language
-- Proper use of formatting elements
+Derive your scores from the governance files above:
 
-### 2. AI Readiness (1-10) 
-- Descriptive headings with full feature names and full task phrasing (e.g., "Expense Rule options for Workspace Admins" not "Options")
-- Clear context without vague references
-- Proper YAML metadata structure, including **internalScope** in the form: `Audience is [target role]. Covers [main topic]. Does not cover [excluded areas].` (use a clear default if not provided)
-- Consistent heading hierarchy (# and ## only)
+### 1. Readability (1-10)
+- Sentence clarity, flow, scannability, step formatting — per HELP_AUTHORING_GUIDELINES.md and TEMPLATE.md.
 
-**Note:** Breadcrumb paths after H1 are not required; do not penalize for their absence.
+### 2. AI Readiness (1-10)
+- Task-based headings, full feature names, YAML metadata (including **internalScope**), heading hierarchy (# and ## only) — per HELP_AUTHORING_GUIDELINES.md and TEMPLATE.md. (Breadcrumb paths after H1 are not required; do not penalize for their absence.)
 
 ### 3. Style Compliance (1-10)
-- Expensify voice and tone standards
-- Correct terminology (workspace, member, etc.)
-- Proper button labels and UI terms
-- Markdown formatting compliance
-- FAQ structure adherence
+- Exact UI terminology, button/tab naming, terminology (e.g. Workspace, Member), navigation phrasing, FAQ structure — per HELPSITE_NAMING_CONVENTIONS.md and HELP_AUTHORING_GUIDELINES.md.
 
 ## Output Format
 

.claude/commands/review-helpdot-pr.md

@@ -3,17 +3,21 @@ allowed-tools: Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),mcp__
 description: Review a HelpDot documentation pull request
 ---
 
-Perform a comprehensive HelpDot documentation review using two specialized subagents:
+Perform a comprehensive HelpDot documentation review using two specialized subagents. Both reviewers use the **help site governance files** in the repo as the source of truth for rules and scoring:
+
+- **docs/HELPSITE_NAMING_CONVENTIONS.md** — UI referencing, button/tab naming, navigation
+- **docs/HELP_AUTHORING_GUIDELINES.md** — Structure, headings, metadata, AI retrieval, validation
+- **docs/TEMPLATE.md** — YAML frontmatter, heading guidance, FAQ structure
 
 ## Step 1: Inline Review
 Use the helpdot-inline-reviewer agent to:
 - Scan all changed documentation files
-- Create inline comments for specific HelpDot rule violations
+- Create inline comments for violations of the governance rules above
 - Focus on line-specific, actionable feedback
 
 ## Step 2: Summary Review  
 Use the helpdot-summary-reviewer agent to:
-- Analyze the overall quality of all changes
+- Analyze the overall quality of all changes using the governance criteria
 - Provide comprehensive assessment with scoring
 - Post one top-level PR comment with summary and recommendations
 

__mocks__/react-native-permissions.ts

@@ -1,15 +1,23 @@
-import {PERMISSIONS, RESULTS} from 'react-native-permissions/dist/commonjs/permissions';
+import {PERMISSIONS} from 'react-native-permissions/dist/commonjs/permissions';
 import type {ValueOf} from 'type-fest';
 
+const RESULTS = {
+    UNAVAILABLE: 'unavailable',
+    BLOCKED: 'blocked',
+    DENIED: 'denied',
+    GRANTED: 'granted',
+    LIMITED: 'limited',
+} as const;
+
 type Results = ValueOf<typeof RESULTS>;
 type ResultsCollection = Record<string, Results>;
 type NotificationSettings = Record<string, boolean>;
 type Notification = {status: Results; settings: NotificationSettings};
 
 const openLimitedPhotoLibraryPicker: jest.Mock<void> = jest.fn(() => {});
 const openSettings: jest.Mock<void> = jest.fn(() => {});
-const check = jest.fn(() => RESULTS.GRANTED as string);
-const request = jest.fn(() => RESULTS.GRANTED as string);
+const check = jest.fn(() => Promise.resolve(RESULTS.GRANTED as string));
+const request = jest.fn(() => Promise.resolve(RESULTS.GRANTED as string));
 const checkLocationAccuracy: jest.Mock<string> = jest.fn(() => 'full');
 const requestLocationAccuracy: jest.Mock<string> = jest.fn(() => 'full');
 

assets/images/envelope-open-star.svg

@@ -45,7 +45,7 @@
     "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
     "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
     "typecheck-tsgo": "tsgo --project tsconfig.tsgo.json",
-    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=334 --cache --cache-location=node_modules/.cache/eslint --cache-strategy content --concurrency=auto",
+    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=316 --cache --cache-location=node_modules/.cache/eslint --cache-strategy content --concurrency=auto",
     "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
     "check-lazy-loading": "ts-node scripts/checkLazyLoading.ts",
     "lint-watch": "npx eslint-watch --watch --changed",

package.json

@@ -8,6 +8,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import {handlePlaidError, openPlaidBankAccountSelector, openPlaidBankLogin, setPlaidEvent} from '@libs/actions/BankAccounts';
 import KeyboardShortcut from '@libs/KeyboardShortcut';
 import Log from '@libs/Log';
+import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
 import {handleRestrictedEvent} from '@userActions/App';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
@@ -229,9 +230,13 @@ function AddPlaidBankAccount({
         }
 
         if (plaidData?.isLoading) {
+            const reasonAttributes: SkeletonSpanReasonAttributes = {context: 'AddPlaidBankAccount', isLoading: !!plaidData.isLoading};
             return (
                 <View style={[styles.flex1, styles.alignItemsCenter, styles.justifyContentCenter]}>
-                    <ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />
+                    <ActivityIndicator
+                        size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
+                        reasonAttributes={reasonAttributes}
+                    />
                 </View>
             );
         }

src/components/AddPlaidBankAccount.tsx

@@ -10,6 +10,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import {getPaymentMethods} from '@libs/actions/PaymentMethods';
 import getPlatform from '@libs/getPlatform';
 import Log from '@libs/Log';
+import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
 import {checkIfWalletIsAvailable, handleAddCardToWallet, isCardInWallet} from '@libs/Wallet/index';
 import CONST from '@src/CONST';
 import type AddToWalletButtonProps from './types';
@@ -91,7 +92,13 @@ function AddToWalletButton({card, cardHolderName, cardDescription, style}: AddTo
     }
 
     if (isLoading) {
-        return <ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />;
+        const reasonAttributes: SkeletonSpanReasonAttributes = {context: 'AddToWalletButton', isLoading};
+        return (
+            <ActivityIndicator
+                size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
+                reasonAttributes={reasonAttributes}
+            />
+        );
     }
 
     if (isInWallet) {

src/components/AddToWalletButton/index.native.tsx

@@ -102,7 +102,7 @@ function AttachmentCarousel({
     if (page == null) {
         return (
             <View style={[styles.flex1, styles.attachmentCarouselContainer]}>
-                <FullScreenLoadingIndicator />
+                <FullScreenLoadingIndicator reasonAttributes={{context: 'AttachmentCarousel'}} />
             </View>
         );
     }

src/components/Attachments/AttachmentCarousel/index.tsx

@@ -16,6 +16,7 @@ import useStyleUtils from '@hooks/useStyleUtils';
 import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
 import HapticFeedback from '@libs/HapticFeedback';
+import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
 import CONST from '@src/CONST';
 import type ChildrenProps from '@src/types/utils/ChildrenProps';
 import type IconAsset from '@src/types/utils/IconAsset';
@@ -300,6 +301,10 @@ function Button({
     const StyleUtils = useStyleUtils();
     const [isHovered, setIsHovered] = useState(false);
 
+    const buttonLoadingReasonAttributes: SkeletonSpanReasonAttributes = {
+        context: 'Button',
+    };
+
     const renderContent = () => {
         if ('children' in rest) {
             return rest.children;
@@ -535,6 +540,7 @@ function Button({
                         color={success || danger ? theme.textLight : theme.text}
                         style={[styles.pAbsolute, styles.l0, styles.r0]}
                         size={extraSmall ? 12 : undefined}
+                        reasonAttributes={buttonLoadingReasonAttributes}
                     />
                 )}
             </PressableWithFeedback>