Skip to content

Commit e75dfdb

Browse files
committed
fix: styles for the image
1 parent 2e42831 commit e75dfdb

6 files changed

Lines changed: 391 additions & 133 deletions

File tree

assets/images/educational-illustration__multi-scan.svg

Lines changed: 380 additions & 0 deletions
Loading

assets/images/multi-scan.svg

Lines changed: 0 additions & 126 deletions
This file was deleted.

src/components/FeatureTrainingModal.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {Image, InteractionManager, View} from 'react-native';
55
import type {ImageResizeMode, ImageSourcePropType, StyleProp, TextStyle, ViewStyle} from 'react-native';
66
import {GestureHandlerRootView} from 'react-native-gesture-handler';
77
import type {MergeExclusive} from 'type-fest';
8+
import ImageSVGProps from '@components/ImageSVG/types';
89
import useLocalize from '@hooks/useLocalize';
910
import useNetwork from '@hooks/useNetwork';
1011
import useResponsiveLayout from '@hooks/useResponsiveLayout';
@@ -147,10 +148,10 @@ type FeatureTrainingModalSVGProps = {
147148
contentFitImage?: ImageContentFit;
148149

149150
/** The width of the image */
150-
imageWidth?: number;
151+
imageWidth?: ImageSVGProps['width'];
151152

152153
/** The height of the image */
153-
imageHeight?: number;
154+
imageHeight?: ImageSVGProps['height'];
154155
};
155156

156157
// This page requires either an icon or a video/animation, but not both
@@ -370,6 +371,7 @@ function FeatureTrainingModal({
370371
}
371372
: {}),
372373
...modalInnerContainerStyle,
374+
padding: 0,
373375
}}
374376
>
375377
<Wrapper

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {useCameraDevice} from 'react-native-vision-camera';
1414
import type {TupleToUnion} from 'type-fest';
1515
import TestReceipt from '@assets/images/fake-receipt.png';
1616
import Hand from '@assets/images/hand.svg';
17-
import MultiScan from '@assets/images/multi-scan.svg';
17+
import MultiScan from '@assets/images/educational-illustration__multi-scan.svg';
1818
import Shutter from '@assets/images/shutter.svg';
1919
import type {FileObject} from '@components/AttachmentModal';
2020
import AttachmentPicker from '@components/AttachmentPicker';
@@ -868,7 +868,7 @@ function IOURequestStepScan({
868868
title={translate('iou.scanMultipleReceipts')}
869869
image={MultiScan}
870870
shouldRenderSVG
871-
contentFitImage="contain"
871+
imageHeight={220}
872872
modalInnerContainerStyle={styles.pt0}
873873
illustrationOuterContainerStyle={styles.multiScanEducationalPopupImage}
874874
onConfirm={dismissMultiScanEducationalPopup}

src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import Animated, {useAnimatedStyle, useSharedValue, withTiming} from 'react-nati
1010
import type Webcam from 'react-webcam';
1111
import TestReceipt from '@assets/images/fake-receipt.png';
1212
import Hand from '@assets/images/hand.svg';
13-
import MultiScan from '@assets/images/multi-scan.svg';
13+
import MultiScan from '@assets/images/educational-illustration__multi-scan.svg';
1414
import ReceiptUpload from '@assets/images/receipt-upload.svg';
1515
import Shutter from '@assets/images/shutter.svg';
1616
import type {FileObject} from '@components/AttachmentModal';
@@ -997,7 +997,8 @@ function IOURequestStepScan({
997997
title={translate('iou.scanMultipleReceipts')}
998998
image={MultiScan}
999999
shouldRenderSVG
1000-
contentFitImage="contain"
1000+
imageHeight="auto"
1001+
imageWidth="auto"
10011002
modalInnerContainerStyle={styles.pt0}
10021003
illustrationOuterContainerStyle={styles.multiScanEducationalPopupImage}
10031004
onConfirm={dismissMultiScanEducationalPopup}

src/styles/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5908,7 +5908,8 @@ const styles = (theme: ThemeColors) =>
59085908
multiScanEducationalPopupImage: {
59095909
backgroundColor: colors.pink700,
59105910
overflow: 'hidden',
5911-
height: 220,
5911+
paddingHorizontal: 0,
5912+
aspectRatio: 1.7,
59125913
},
59135914
}) satisfies Styles;
59145915

0 commit comments

Comments
 (0)