Skip to content

Commit ec8ffdc

Browse files
committed
Fix blank expense/row by moving border style from pressableStyle to wrapperStyle
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
1 parent dcad897 commit ec8ffdc

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/components/Search/SearchList/ListItem/ExpenseReportListItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ function ExpenseReportListItem<TItem extends ListItem>({
180180
styles.mh0,
181181
isPendingDelete && styles.cursorDisabled,
182182
isLargeScreenWidth ? StyleUtils.getSearchTableRowPressableStyle(!!isLastItem, item.isSelected, {vertical: variables.tableRowPaddingVertical}) : styles.noBorderRadius,
183-
!isLargeScreenWidth && !isLastItem && StyleUtils.getSelectedBorderBottomStyle(item.isSelected),
184183
!isLargeScreenWidth && isFirstItem && [styles.searchTableTopRadius, styles.overflowHidden],
185184
!isLargeScreenWidth && isLastItem && [styles.searchTableBottomRadius, styles.overflowHidden],
186185
],
@@ -284,6 +283,7 @@ function ExpenseReportListItem<TItem extends ListItem>({
284283
isLargeScreenWidth && isLastItem && [styles.searchTableBottomRadius, styles.overflowHidden],
285284
!isLargeScreenWidth && isFirstItem && styles.searchTableTopRadius,
286285
!isLargeScreenWidth && isLastItem && styles.searchTableBottomRadius,
286+
!isLargeScreenWidth && !isLastItem && StyleUtils.getSelectedBorderBottomStyle(item.isSelected),
287287
]}
288288
accessible={false}
289289
shouldShowRightCaret={false}

src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ function TransactionGroupListItem<TItem extends ListItem>({
217217
...(isLastItem ? styles.searchTableBottomRadius : {}),
218218
},
219219
isItemSelected && styles.activeComponentBG,
220-
!isLargeScreenWidth && !isLastItem && StyleUtils.getSelectedBorderBottomStyle(isItemSelected),
221220
];
222221
const pressableRef = useRef<View>(null);
223222

@@ -544,7 +543,11 @@ function TransactionGroupListItem<TItem extends ListItem>({
544543
styles.userSelectNone,
545544
isLargeScreenWidth
546545
? [StyleUtils.getSearchTableGroupRowBorderStyle(isFirstItem, isLastItem, isItemSelected), isLastItem && styles.overflowHidden]
547-
: [isFirstItem && [styles.searchTableTopRadius, styles.overflowHidden], isLastItem && [styles.searchTableBottomRadius, styles.overflowHidden]],
546+
: [
547+
isFirstItem && [styles.searchTableTopRadius, styles.overflowHidden],
548+
isLastItem && [styles.searchTableBottomRadius, styles.overflowHidden],
549+
!isLastItem && StyleUtils.getSelectedBorderBottomStyle(isItemSelected),
550+
],
548551
]}
549552
>
550553
{({hovered}) => (

src/components/Search/SearchList/ListItem/TransactionListItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ function TransactionListItem<TItem extends ListItem>({
122122
}
123123
: {...styles.flexColumn, ...styles.alignItemsStretch},
124124
isLargeScreenWidth && isLastItem && [styles.searchTableBottomRadius, styles.overflowHidden],
125-
!isLargeScreenWidth && !isLastItem && StyleUtils.getSelectedBorderBottomStyle(item.isSelected),
126125
!isLargeScreenWidth && isFirstItem && [styles.searchTableTopRadius, styles.overflowHidden],
127126
!isLargeScreenWidth && isLastItem && [styles.searchTableBottomRadius, styles.overflowHidden],
128127
];
@@ -227,6 +226,7 @@ function TransactionListItem<TItem extends ListItem>({
227226
isLargeScreenWidth && isLastItem && styles.searchTableBottomRadius,
228227
!isLargeScreenWidth && isFirstItem && styles.searchTableTopRadius,
229228
!isLargeScreenWidth && isLastItem && styles.searchTableBottomRadius,
229+
!isLargeScreenWidth && !isLastItem && StyleUtils.getSelectedBorderBottomStyle(item.isSelected),
230230
]}
231231
>
232232
{({hovered}) => (

0 commit comments

Comments
 (0)