Skip to content

Commit ef8640a

Browse files
committed
fix zero height popover menu display in hybrid ios
1 parent 1abb943 commit ef8640a

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

src/components/PopoverMenu.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ function PopoverMenu({
314314
}}
315315
wrapperStyle={[
316316
StyleUtils.getItemBackgroundColorStyle(!!item.isSelected, focusedIndex === menuIndex, item.disabled ?? false, theme.activeComponentBG, theme.hoverComponentBG),
317-
shouldUseScrollView && StyleUtils.getOptionMargin(menuIndex, currentMenuItems.length - 1),
318317
]}
319318
shouldRemoveHoverBackground={item.isSelected}
320319
titleStyle={StyleSheet.flatten([styles.flex1, item.titleStyle])}
@@ -329,7 +328,7 @@ function PopoverMenu({
329328
if (!headerText || enteredSubMenuIndexes.length !== 0) {
330329
return;
331330
}
332-
return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pt3, headerStyles]}>{headerText}</Text>;
331+
return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pt4, headerStyles]}>{headerText}</Text>;
333332
};
334333

335334
useKeyboardShortcut(
@@ -429,7 +428,7 @@ function PopoverMenu({
429428
style={[menuContainerStyle, containerStyles, styles.pv0]}
430429
>
431430
{renderHeaderText()}
432-
<View style={{paddingTop, paddingBottom, paddingVertical, ...styles.flex1}}>
431+
<View style={{paddingTop, paddingBottom, paddingVertical, ...(isWebOrDesktop ? styles.flex1 : styles.flexGrow1)}}>
433432
{enteredSubMenuIndexes.length > 0 && renderBackButtonItem()}
434433
{renderWithConditionalWrapper(shouldUseScrollView, restScrollContainerStyle, renderedMenuItems)}
435434
</View>

0 commit comments

Comments
 (0)