Merge branch 'main' into marcaaron-requestEarlyCancellation

Author: marcaaron

.eslintrc.changed.js

@@ -8,6 +8,7 @@ module.exports = {
         'deprecation/deprecation': 'error',
         'rulesdir/no-default-id-values': 'error',
         'rulesdir/provide-canBeMissing-in-useOnyx': 'error',
+        'rulesdir/no-unstable-hook-defaults': 'error',
         'no-restricted-syntax': [
             'error',
             {

.eslintrc.js

@@ -100,6 +100,11 @@ const restrictedImportPaths = [
         name: 'react-native-animatable',
         message: "Please use 'react-native-reanimated' instead.",
     },
+    {
+        name: 'react-native-onyx',
+        importNames: ['useOnyx'],
+        message: "Please use '@hooks/useOnyx' instead.",
+    },
 ];
 
 const restrictedImportPatterns = [
@@ -214,6 +219,7 @@ module.exports = {
         'es/no-optional-chaining': 'off',
         'deprecation/deprecation': 'off',
         'arrow-body-style': 'off',
+        'no-continue': 'off',
 
         // Import specific rules
         'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
@@ -225,6 +231,7 @@ module.exports = {
         'rulesdir/no-multiple-onyx-in-file': 'off',
         'rulesdir/prefer-underscore-method': 'off',
         'rulesdir/prefer-import-module-contents': 'off',
+        'rulesdir/no-beta-handler': 'error',
 
         // React and React Native specific rules
         'react-native-a11y/has-accessibility-hint': ['off'],
@@ -271,6 +278,14 @@ module.exports = {
                 property: 'isHybridApp',
                 message: 'Use CONFIG.IS_HYBRID_APP instead.',
             },
+            // Prevent direct use of HybridAppModule.closeReactNativeApp().
+            // Instead, use the `closeReactNativeApp` action from `@userActions/HybridApp`,
+            // which correctly updates `hybridApp.closingReactNativeApp` when closing NewDot
+            {
+                object: 'HybridAppModule',
+                property: 'closeReactNativeApp',
+                message: 'Use `closeReactNativeApp` from `@userActions/HybridApp` instead.',
+            },
         ],
         'no-restricted-imports': [
             'error',

.github/.eslintrc.js

@@ -7,6 +7,16 @@ module.exports = {
         'no-await-in-loop': 'off',
         'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
         'no-continue': 'off',
-        'no-restricted-imports': 'off',
+        'no-restricted-imports': [
+            'error',
+            {
+                patterns: [
+                    {
+                        group: ['@src/**'],
+                        message: 'Do not import files from src/ directory as they can break the GH Actions build script.',
+                    },
+                ],
+            },
+        ],
     },
 };

.github/ISSUE_TEMPLATE/NewPatchTemplate.md

@@ -0,0 +1,39 @@
+---
+name: Patch Tracking
+about: Template for tracking patches applied to third-party libraries
+---
+
+If you haven't already, check out our [contributing guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md) and [patch guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/PATCHES.md) for information on how to manage patches.
+___
+
+## Patch Information
+
+**Library Name:** <!-- e.g., react-native-pdf -->
+**Library Version:** <!-- e.g., 6.7.3 -->
+**Patch Number:** <!-- e.g., 001 -->
+**Patch Description:** <!-- e.g., update-podspec-to-support-new-arch -->
+**Full Patch Filename:** <!-- e.g., react-native-pdf+6.7.3+001+update-podspec-to-support-new-arch.patch -->
+
+## Patch Details
+
+### Reason for Patch
+<!-- Explain why this patch is necessary. What issue does it solve? -->
+
+### Changes Made
+<!-- Briefly describe the changes made in the patch -->
+
+### Upstream Status
+**Upstream PR/Issue:** <!-- Link to the PR or issue in the upstream repository, if one exists -->
+
+## Related Information
+
+**PR Introducing Patch:** <!-- Link to the PR that introduced this patch -->
+
+## Additional Notes
+<!-- Any other relevant information about this patch -->
+
+## Checklist
+- [ ] Patch file is correctly named and placed in the appropriate directory
+- [ ] Patch is documented in the corresponding `details.md` file
+- [ ] This issue is linked in the `details.md` file
+- [ ] Upstream PR/issue has been created (if applicable)

.github/actions/javascript/authorChecklist/index.js

@@ -2,7 +2,7 @@
 import * as core from '@actions/core';
 import CONST from '@github/libs/CONST';
 import GithubUtils from '@github/libs/GithubUtils';
-import {isEmptyObject} from '@src/types/utils/EmptyObject';
+import {isEmptyObject} from '@github/libs/isEmptyObject';
 
 const run = function (): Promise<void> {
     const issueNumber = Number(core.getInput('ISSUE_NUMBER', {required: true}));

.github/actions/javascript/awaitStagingDeploys/index.js

@@ -0,0 +1,10 @@
+name: 'Check Test Coverage'
+description: 'A simple action that takes a GitHub URL and prints it'
+inputs:
+    GITHUB_URL:
+        description: 'GitHub repository URL to check'
+        required: true
+
+runs:
+    using: 'node20'
+    main: './index.js'