Skip to content

Commit f031c0d

Browse files
committed
remove redundant test case
1 parent 76d7696 commit f031c0d

2 files changed

Lines changed: 1 addition & 24 deletions

File tree

src/libs/ReportSecondaryActionUtils.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -546,14 +546,6 @@ function isRemoveHoldAction(report: Report, chatReport: OnyxEntry<Report>, repor
546546
return policy?.role === CONST.POLICY.ROLE.ADMIN;
547547
}
548548

549-
function isRemoveHoldActionForTransaction(report: Report, reportTransaction: Transaction, policy?: Policy): boolean {
550-
if (!isOnHoldTransactionUtils(reportTransaction)) {
551-
return false;
552-
}
553-
554-
return policy?.role === CONST.POLICY.ROLE.ADMIN;
555-
}
556-
557549
function getSecondaryReportActions({
558550
report,
559551
chatReport,

tests/unit/ReportSecondaryActionUtilsTest.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1247,7 +1247,7 @@ describe('getSecondaryExportReportActions', () => {
12471247
expect(result.includes(CONST.REPORT.EXPORT_OPTIONS.MARK_AS_EXPORTED)).toBe(true);
12481248
});
12491249

1250-
it('includes REMOVE HOLD option for admin', () => {
1250+
it('includes REMOVE HOLD option for admin in expense report but not in transaction thread report', () => {
12511251
const report = {} as unknown as Report;
12521252
const policy = {
12531253
role: CONST.POLICY.ROLE.ADMIN,
@@ -1310,21 +1310,6 @@ describe('getSecondaryTransactionThreadActions', () => {
13101310
expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.HOLD)).toBe(true);
13111311
});
13121312

1313-
it('includes REMOVE HOLD option for admin', () => {
1314-
const report = {} as unknown as Report;
1315-
const policy = {
1316-
role: CONST.POLICY.ROLE.ADMIN,
1317-
} as unknown as Policy;
1318-
const transaction = {
1319-
comment: {
1320-
hold: 'REPORT_ACTION_ID',
1321-
},
1322-
} as unknown as Transaction;
1323-
1324-
const result = getSecondaryTransactionThreadActions(report, transaction, [], policy);
1325-
expect(result).toContain(CONST.REPORT.TRANSACTION_SECONDARY_ACTIONS.REMOVE_HOLD);
1326-
});
1327-
13281313
it('includes DELETE option for expense report submitter', async () => {
13291314
const report = {
13301315
reportID: REPORT_ID,

0 commit comments

Comments
 (0)