Merge pull request Expensify#90205 from emkhalid/fix/89431-stable-transactions-by-id

Fix distance rate request freeze when going back from confirmation

Author: cristipaval

src/hooks/useTransactionsByID.ts

@@ -1,13 +1,16 @@
-import {useCallback} from 'react';
+import {useCallback, useMemo} from 'react';
 import type {OnyxCollection} from 'react-native-onyx';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {Transaction} from '@src/types/onyx';
 import useOnyx from './useOnyx';
 
 function useTransactionsByID(transactionIDs: string[] | undefined) {
+    const transactionIDsKey = transactionIDs?.join('|') ?? '';
+    const stableTransactionIDs = useMemo(() => (transactionIDsKey ? transactionIDsKey.split('|') : []), [transactionIDsKey]);
+
     const transactionsSelector = useCallback(
-        (transactions: OnyxCollection<Transaction>) => transactionIDs?.map((id) => transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`]) ?? [],
-        [transactionIDs],
+        (transactions: OnyxCollection<Transaction>) => stableTransactionIDs.map((id) => transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`]),
+        [stableTransactionIDs],
     );
 
     const [transactions] = useOnyx(