Merge pull request Expensify#65727 from callstack-internal/perf/improve-tab-switching

perf: use Set instead of includes in useEffect on Search page

Author: mountiny

src/hooks/useSearchHighlightAndScroll.ts

@@ -61,8 +61,10 @@ function useSearchHighlightAndScroll({searchResults, transactions, previousTrans
             return;
         }
 
-        const hasTransactionsIDsChange = transactionsIDs.some((id) => !previousTransactionsIDs.includes(id));
-        const hasReportActionsIDsChange = reportActionsIDs.some((id) => !previousReportActionsIDs.includes(id));
+        const previousTransactionsIDsSet = new Set(previousTransactionsIDs);
+        const previousReportActionsIDsSet = new Set(previousReportActionsIDs);
+        const hasTransactionsIDsChange = transactionsIDs.some((id) => !previousTransactionsIDsSet.has(id));
+        const hasReportActionsIDsChange = reportActionsIDs.some((id) => !previousReportActionsIDsSet.has(id));
 
         // Check if there is a change in the transactions or report actions list
         if ((!isChat && hasTransactionsIDsChange) || hasReportActionsIDsChange || hasPendingSearchRef.current) {
@@ -74,12 +76,14 @@ function useSearchHighlightAndScroll({searchResults, transactions, previousTrans
             hasPendingSearchRef.current = false;
 
             const newIDs = isChat ? reportActionsIDs : transactionsIDs;
-            const hasAGenuinelyNewID = newIDs.some((id) => !existingSearchResultIDs.includes(id));
+            const existingSearchResultIDsSet = new Set(existingSearchResultIDs);
+            const hasAGenuinelyNewID = newIDs.some((id) => !existingSearchResultIDsSet.has(id));
 
             // Only skip search if there are no new items AND search results aren't empty
             // This ensures deletions that result in empty data still trigger search
             if (!hasAGenuinelyNewID && existingSearchResultIDs.length > 0) {
-                const hasDeletedID = existingSearchResultIDs.some((id) => !newIDs.includes(id));
+                const newIDsSet = new Set(newIDs);
+                const hasDeletedID = existingSearchResultIDs.some((id) => !newIDsSet.has(id));
                 if (!hasDeletedID) {
                     return;
                 }