Merge pull request Expensify#79100 from callstack-internal/eliran/sentry-OpenTransactionThread-RHP-tracking

Add transaction thread span

Author: rlinoz

src/CONST/index.ts

@@ -1714,6 +1714,10 @@ const CONST = {
         },
         // Attribute names
         ATTRIBUTE_IOU_TYPE: 'iou_type',
+        ATTRIBUTE_IS_ONE_TRANSACTION_REPORT: 'is_one_transaction_report',
+        ATTRIBUTE_IS_TRANSACTION_THREAD: 'is_transaction_thread',
+        ATTRIBUTE_REPORT_TYPE: 'report_type',
+        ATTRIBUTE_CHAT_TYPE: 'chat_type',
         ATTRIBUTE_IOU_REQUEST_TYPE: 'iou_request_type',
         ATTRIBUTE_REPORT_ID: 'report_id',
         ATTRIBUTE_MESSAGE_LENGTH: 'message_length',

src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

@@ -646,8 +646,8 @@ function MoneyRequestReportActionsList({
 
         didLayout.current = true;
 
-        markOpenReportEnd(reportID);
-    }, [reportID]);
+        markOpenReportEnd(report);
+    }, [report]);
 
     const isSelectAllChecked = selectedTransactionIDs.length > 0 && selectedTransactionIDs.length === transactionsWithoutPendingDelete.length;
     // Wrapped into useCallback to stabilize children re-renders

src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

@@ -166,7 +166,9 @@ function MoneyRequestReportView({report, policy, reportMetadata, shouldDisplayRe
 
     // We need to cancel telemetry span when user leaves the screen before full report data is loaded
     useEffect(() => {
-        return () => cancelSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportID}`);
+        return () => {
+            cancelSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportID}`);
+        };
     }, [reportID]);
 
     if (!!(isLoadingInitialReportActions && reportActions.length === 0 && !isOffline) || shouldWaitForTransactions) {

src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

@@ -516,6 +516,7 @@ function MoneyRequestReportPreviewContent({
             name: 'MoneyRequestReportPreviewContent',
             op: CONST.TELEMETRY.SPAN_OPEN_REPORT,
         });
+
         Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(iouReportID, undefined, undefined, Navigation.getActiveRoute()));
     }, [iouReportID]);
 

src/libs/telemetry/markOpenReportEnd.ts

@@ -1,13 +1,30 @@
 import Timing from '@libs/actions/Timing';
 import Performance from '@libs/Performance';
+import {isOneTransactionReport, isReportTransactionThread} from '@libs/ReportUtils';
 import CONST from '@src/CONST';
-import {endSpan} from './activeSpans';
+import type * as OnyxTypes from '@src/types/onyx';
+import {endSpan, getSpan} from './activeSpans';
 
 /**
  * Mark all 'open_report*' performance events as finished using both Performance (local) and Timing (remote) tracking.
  */
-function markOpenReportEnd(reportId: string) {
-    endSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportId}`);
+function markOpenReportEnd(report: OnyxTypes.Report) {
+    const {reportID, type, chatType} = report;
+
+    const isTransactionThread = isReportTransactionThread(report);
+    const isOneTransactionThread = isOneTransactionReport(report);
+
+    const spanId = `${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${reportID}`;
+    const span = getSpan(spanId);
+    span?.setAttributes({
+        [CONST.TELEMETRY.ATTRIBUTE_IS_TRANSACTION_THREAD]: isTransactionThread,
+        [CONST.TELEMETRY.ATTRIBUTE_IS_ONE_TRANSACTION_REPORT]: isOneTransactionThread,
+        [CONST.TELEMETRY.ATTRIBUTE_REPORT_TYPE]: type,
+        [CONST.TELEMETRY.ATTRIBUTE_CHAT_TYPE]: chatType,
+    });
+
+    endSpan(spanId);
+
     Performance.markEnd(CONST.TIMING.OPEN_REPORT);
     Timing.end(CONST.TIMING.OPEN_REPORT);
 

src/pages/home/report/ReportActionsView.tsx

@@ -269,8 +269,8 @@ function ReportActionsView({
 
         didLayout.current = true;
 
-        markOpenReportEnd(reportID);
-    }, [reportID]);
+        markOpenReportEnd(report);
+    }, [report]);
 
     // Check if the first report action in the list is the one we're currently linked to
     const isTheFirstReportActionIsLinked = newestReportAction?.reportActionID === reportActionID;