Skip to content

Commit f422e14

Browse files
committed
pass necessary props only
1 parent b945f4d commit f422e14

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/libs/actions/ReimbursementAccount/resetNonUSDBankAccount.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ import * as API from '@libs/API';
44
import {WRITE_COMMANDS} from '@libs/API/types';
55
import CONST from '@src/CONST';
66
import ONYXKEYS from '@src/ONYXKEYS';
7-
import type {Policy} from '@src/types/onyx';
7+
import type {ACHAccount} from '@src/types/onyx/Policy';
88

9-
function resetNonUSDBankAccount(policy: OnyxEntry<Policy>) {
10-
if (!policy) {
9+
function resetNonUSDBankAccount(policyID: string | undefined, achAccount: OnyxEntry<ACHAccount>) {
10+
if (!policyID) {
1111
throw new Error('Missing policy when attempting to reset');
1212
}
1313

1414
API.write(
1515
WRITE_COMMANDS.RESET_BANK_ACCOUNT_SETUP,
16-
{policyID: policy.id},
16+
{policyID},
1717
{
1818
optimisticData: [
1919
{
@@ -28,7 +28,7 @@ function resetNonUSDBankAccount(policy: OnyxEntry<Policy>) {
2828
},
2929
{
3030
onyxMethod: Onyx.METHOD.MERGE,
31-
key: `${ONYXKEYS.COLLECTION.POLICY}${policy.id}`,
31+
key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
3232
value: {
3333
achAccount: null,
3434
},
@@ -54,9 +54,9 @@ function resetNonUSDBankAccount(policy: OnyxEntry<Policy>) {
5454
},
5555
{
5656
onyxMethod: Onyx.METHOD.MERGE,
57-
key: `${ONYXKEYS.COLLECTION.POLICY}${policy.id}`,
57+
key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
5858
value: {
59-
achAccount: policy?.achAccount,
59+
achAccount,
6060
},
6161
},
6262
],

src/pages/workspace/WorkspaceResetBankAccountModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function WorkspaceResetBankAccountModal({
5555

5656
const handleConfirm = () => {
5757
if (isNonUSDWorkspace) {
58-
resetNonUSDBankAccount(policy);
58+
resetNonUSDBankAccount(policyID, policy?.achAccount);
5959

6060
if (setShouldShowConnectedVerifiedBankAccount) {
6161
setShouldShowConnectedVerifiedBankAccount(false);

0 commit comments

Comments
 (0)