refactor: simplify PDFViewProps and clean up type usage

Author: mohammadjafarinejad

src/components/PDFView/index.native.tsx

@@ -13,7 +13,7 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import useWindowDimensions from '@hooks/useWindowDimensions';
 import CONST from '@src/CONST';
 import PDFPasswordForm from './PDFPasswordForm';
-import type {PDFViewNativeProps} from './types';
+import type PDFViewProps from './types';
 
 /**
  * On the native layer, we use react-native-pdf/PDF to display PDFs. If a PDF is
@@ -33,7 +33,7 @@ import type {PDFViewNativeProps} from './types';
 const LOADING_THUMBNAIL_HEIGHT = 250;
 const LOADING_THUMBNAIL_WIDTH = 250;
 
-function PDFView({onToggleKeyboard, onLoadComplete, fileName, onPress, isFocused, onScaleChanged, sourceURL, onLoadError, isUsedAsChatAttachment}: PDFViewNativeProps) {
+function PDFView({onToggleKeyboard, onLoadComplete, fileName, onPress, isFocused, onScaleChanged, sourceURL, onLoadError, isUsedAsChatAttachment}: PDFViewProps) {
     const [shouldRequestPassword, setShouldRequestPassword] = useState(false);
     const [shouldAttemptPDFLoad, setShouldAttemptPDFLoad] = useState(true);
     const [shouldShowLoadingIndicator, setShouldShowLoadingIndicator] = useState(true);

src/components/PDFView/index.tsx

@@ -6,8 +6,8 @@ import {PDFPreviewer} from 'react-fast-pdf';
 import {View} from 'react-native';
 import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
 import PressableWithoutFeedback from '@components/Pressable/PressableWithoutFeedback';
-import useOnyx from '@hooks/useOnyx';
 import useLocalize from '@hooks/useLocalize';
+import useOnyx from '@hooks/useOnyx';
 import usePrevious from '@hooks/usePrevious';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
 import useStyleUtils from '@hooks/useStyleUtils';
@@ -18,7 +18,7 @@ import * as CanvasSize from '@userActions/CanvasSize';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import PDFPasswordForm from './PDFPasswordForm';
-import type {PDFViewProps} from './types';
+import type PDFViewProps from './types';
 
 const LOADING_THUMBNAIL_HEIGHT = 250;
 const LOADING_THUMBNAIL_WIDTH = 250;
@@ -147,4 +147,3 @@ function PDFView({onToggleKeyboard, fileName, onPress, isFocused, sourceURL, sty
 }
 
 export default memo(PDFView);
-

src/components/PDFView/types.ts

@@ -14,7 +14,7 @@ type PDFViewBaseProps = {
     onToggleKeyboard?: (isKeyboardOpen: boolean) => void;
 
     /** Handles press events like toggling attachment arrows natively */
-    onPress?: (event?: GestureResponderEvent | KeyboardEvent) => void;
+    onPress?: ((event?: GestureResponderEvent | KeyboardEvent) => void) & ((page: number, x: number, y: number) => void);
 
     /** Handles scale changed event in PDF component */
     onScaleChanged?: (newScale: number) => void;
@@ -34,8 +34,5 @@ type PDFViewBaseProps = {
 
 type PDFViewProps = PDFViewBaseProps;
 
-type PDFViewNativeProps = PDFViewBaseProps & {
-    onPress?: (page: number, x: number, y: number) => void;
-};
+export default PDFViewProps;
 
-export type {PDFViewNativeProps, PDFViewProps};