Merge pull request Expensify#64082 from FitseTLT/fix-money-report-preview-pending-delete-transactions-bug

fix - Expense - Expense preview is blank briefly when deleted offline and returning online

Author: pecanoro

src/hooks/useReportWithTransactionsAndViolations.ts

@@ -1,7 +1,9 @@
 import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
 import {reportTransactionsSelector} from '@libs/ReportUtils';
+import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {Report, Transaction, TransactionViolation} from '@src/types/onyx';
+import useNetwork from './useNetwork';
 import useOnyx from './useOnyx';
 
 const DEFAULT_TRANSACTIONS: Transaction[] = [];
@@ -13,20 +15,22 @@ function useReportWithTransactionsAndViolations(reportID?: string): [OnyxEntry<R
         selector: (_transactions) => reportTransactionsSelector(_transactions, reportID),
         canBeMissing: true,
     });
+    const {isOffline} = useNetwork();
+    const filteredTransactions = transactions?.filter((transaction) => isOffline || transaction?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
     const [violations] = useOnyx(
         ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
         {
             selector: (allViolations) =>
                 Object.fromEntries(
                     Object.entries(allViolations ?? {}).filter(([key]) =>
-                        transactions?.some((transaction) => transaction.transactionID === key.replace(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, '')),
+                        filteredTransactions?.some((transaction) => transaction.transactionID === key.replace(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS, '')),
                     ),
                 ),
             canBeMissing: true,
         },
-        [transactions],
+        [filteredTransactions],
     );
-    return [report, transactions ?? DEFAULT_TRANSACTIONS, violations ?? DEFAULT_VIOLATIONS];
+    return [report, filteredTransactions ?? DEFAULT_TRANSACTIONS, violations ?? DEFAULT_VIOLATIONS];
 }
 
 export default useReportWithTransactionsAndViolations;

tests/utils/collections/transaction.ts

@@ -34,7 +34,6 @@ export default function createRandomTransaction(index: number): Transaction {
         modifiedMerchant: randWord(),
         originalAmount: randAmount(),
         originalCurrency: rand(Object.values(CONST.CURRENCY)),
-        pendingAction: rand(Object.values(CONST.RED_BRICK_ROAD_PENDING_ACTION)),
         reportID: index.toString(),
         transactionID: index.toString(),
         tag: randWord(),