Merge pull request Expensify#90540 from Expensify/claude-fixZeroLimitValidation

Allow $0 as valid card limit when editing Expensify Card

Author: mjasikowski

src/libs/CardUtils.ts

@@ -1060,12 +1060,8 @@ function filterAllInactiveCards(cards: CardList | undefined, includeDeactivated
 
     const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED]);
     return filterObject(cards, (_key, card) => {
-        const isAdminZeroedExpensifyCard = isExpensifyCard(card) && isCardWithCustomZeroLimit(card);
         if (card.state === CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED) {
-            return !!card.nameValuePairs?.frozen || (includeDeactivated && isAdminZeroedExpensifyCard);
-        }
-        if (card.state === CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED) {
-            return includeDeactivated && isAdminZeroedExpensifyCard;
+            return !!card.nameValuePairs?.frozen || includeDeactivated;
         }
         return !closedStates.has(card.state);
     });
@@ -1083,7 +1079,7 @@ function filterInactiveCards(cardsList: WorkspaceCardsList | undefined) {
 
 /**
  * Onyx selector for workspace Expensify Card management pages. Same as `filterInactiveCards`, but also
- * keeps issued deactivated cards and zero-limit suspended cards so admins can view and edit them.
+ * keeps all suspended cards so admins can view and edit them.
  */
 function filterInactiveCardsForWorkspace(cardsList: WorkspaceCardsList | undefined) {
     const {cardList, ...assignedCards} = cardsList ?? {};

src/pages/workspace/expensifyCard/DynamicExpensifyCardLimitPage.tsx

@@ -105,7 +105,7 @@ function DynamicExpensifyCardLimitPage({route}: DynamicExpensifyCardLimitPagePro
         (values: FormOnyxValues<typeof ONYXKEYS.FORMS.EDIT_EXPENSIFY_CARD_LIMIT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.EDIT_EXPENSIFY_CARD_LIMIT_FORM> => {
             const errors = getFieldRequiredErrors(values, [INPUT_IDS.LIMIT], translate);
 
-            if (!Number(values.limit)) {
+            if (Number.isNaN(Number(values.limit))) {
                 errors.limit = translate('iou.error.invalidAmount');
             } else if (!Number.isInteger(Number(values.limit))) {
                 errors.limit = translate('iou.error.invalidIntegerAmount');

tests/unit/CardUtilsTest.ts

@@ -3441,10 +3441,12 @@ describe('CardUtils', () => {
             } as unknown as CardList;
 
             const ids = Object.values(filterAllInactiveCards(cards, true)).map((c) => c.cardID);
-            expect(ids).toEqual(expect.arrayContaining([1, 3, 5]));
+            // All suspended cards are kept when includeDeactivated is true (admins can view/edit them)
+            expect(ids).toEqual(expect.arrayContaining([1, 5, 6]));
             expect(ids).not.toContain(2);
+            // STATE_DEACTIVATED cards are always excluded (server rejects limit updates with 403)
+            expect(ids).not.toContain(3);
             expect(ids).not.toContain(4);
-            expect(ids).not.toContain(6);
             expect(ids).not.toContain(7);
             expect(ids).not.toContain(8);
         });
@@ -3495,11 +3497,13 @@ describe('CardUtils', () => {
 
             const result = filterInactiveCardsForWorkspace(cardsList);
             expect(result.active).toBeDefined();
-            expect(result.adminZeroedDeactivated).toBeDefined();
+            // All suspended cards are kept so admins can view and edit them
             expect(result.adminZeroedSuspended).toBeDefined();
+            expect(result.nonZeroSuspended).toBeDefined();
             expect(result.closed).toBeUndefined();
+            // STATE_DEACTIVATED cards are always excluded (server rejects limit updates with 403)
+            expect(result.adminZeroedDeactivated).toBeUndefined();
             expect(result.deactivatedNonZero).toBeUndefined();
-            expect(result.nonZeroSuspended).toBeUndefined();
             expect(result.deactivatedNoCustomFlag).toBeUndefined();
             expect(result.cardList).toBeDefined();
         });