merge latest main

Author: lorretheboy

.claude/skills/coding-standards/rules/consistency-5-justify-eslint-disable.md

@@ -7,7 +7,11 @@ title: Justify ESLint rule disables
 
 ### Reasoning
 
-ESLint rule disables without justification can mask underlying issues and reduce code quality. Clear documentation ensures team members understand exceptions, promoting better maintainability.
+`eslint-disable` comments completely hide violations from the seatbelt baseline — they will never be fixed unless the comment is removed. Because of this, they should only be used for **permanent** suppressions where you are certain the rule genuinely does not apply to that specific case and you don't expect the violation to ever be fixed.
+
+For **temporary** suppressions (e.g. the fix requires a large refactor that is out of scope), prefer widening the seatbelt baseline with `SEATBELT_INCREASE` instead — that keeps the violation visible so it can still be fixed later. See [`LINTING.md`](../../../../contributingGuides/LINTING.md) for full guidance on choosing between the two approaches.
+
+When `eslint-disable` is used, a justification comment is required so that reviewers and future maintainers understand why the rule was deliberately suppressed.
 
 ### Incorrect
 
@@ -37,6 +41,10 @@ Flag ONLY when ALL of these are true:
 - An ESLint rule is disabled (via `eslint-disable`, `eslint-disable-next-line`, etc.)
 - The disable statement lacks an accompanying comment explaining the reason
 
+**Also consider flagging if:**
+
+- `eslint-disable` is used for what appears to be a temporary/convenience suppression — in those cases, suggest `SEATBELT_INCREASE` as the preferred alternative (see [`LINTING.md`](../../../../contributingGuides/LINTING.md))
+
 **DO NOT flag if:**
 
 - The disablement is justified with a clear comment explaining why the rule is disabled

.storybook/main.ts

@@ -1,4 +1,4 @@
-import type {StorybookConfig} from 'storybook/internal/types';
+import type {StorybookConfig} from '@storybook/react-webpack5';
 
 const main: StorybookConfig = {
     stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'],
@@ -15,6 +15,9 @@ const main: StorybookConfig = {
         options: {},
     },
     docs: {},
+    typescript: {
+        reactDocgen: false,
+    },
 };
 
 export default main;

.storybook/preview.tsx

@@ -5,7 +5,9 @@ import {SafeAreaProvider} from 'react-native-safe-area-context';
 import type {Parameters} from 'storybook/internal/types';
 import EnvironmentProvider from '@components/EnvironmentContextProvider';
 import OnyxListItemProvider from '@components/OnyxListItemProvider';
+import ScreenWrapperStatusContext from '@components/ScreenWrapper/ScreenWrapperStatusContext';
 import {SearchContextProvider} from '@components/Search/SearchContext';
+import colors from '@styles/theme/colors';
 import ComposeProviders from '@src/components/ComposeProviders';
 import HTMLEngineProvider from '@src/components/HTMLEngineProvider';
 import {LocaleContextProvider} from '@src/components/LocaleContextProvider';
@@ -35,7 +37,9 @@ const decorators = [
                 SearchContextProvider,
             ]}
         >
-            <Story />
+            <ScreenWrapperStatusContext.Provider value={{didScreenTransitionEnd: true, isSafeAreaTopPaddingApplied: false, isSafeAreaBottomPaddingApplied: false}}>
+                <Story />
+            </ScreenWrapperStatusContext.Provider>
         </ComposeProviders>
     ),
 ];
@@ -46,6 +50,16 @@ const parameters: Parameters = {
             color: /(background|color)$/i,
         },
     },
+    backgrounds: {
+        options: {
+            dark: {name: 'Dark', value: colors.productDark100},
+            light: {name: 'Light', value: colors.productLight100},
+        },
+    },
+};
+
+const initialGlobals = {
+    backgrounds: {value: 'dark'},
 };
 
-export {decorators, parameters};
+export {decorators, parameters, initialGlobals};

Mobile-Expensify

@@ -1,4 +1,5 @@
 import type * as ReactNavigation from '@react-navigation/native';
+import {useEffect} from 'react';
 import createAddListenerMock from '../../../tests/utils/createAddListenerMock';
 
 const isJestEnv = process.env.NODE_ENV === 'test';
@@ -16,15 +17,14 @@ const {triggerTransitionEnd, addListener} = isJestEnv
           addListener: () => {},
       };
 
-const useNavigation = isJestEnv
-    ? realReactNavigation.useNavigation
-    : {
-          navigate: isJestEnv ? jest.fn() : () => {},
-          getState: () => ({
-              routes: [],
-          }),
-          addListener,
-      };
+const navigationMock = {
+    navigate: () => {},
+    getState: () => ({routes: []}),
+    isFocused: () => true,
+    addListener,
+};
+
+const useNavigation = isJestEnv ? realReactNavigation.useNavigation : () => navigationMock;
 
 type NativeNavigationMock = typeof ReactNavigation & {
     triggerTransitionEnd: () => void;
@@ -42,7 +42,12 @@ const useLinkProps = isJestEnv ? realReactNavigation.useLinkProps : () => null;
 const useLinkTo = isJestEnv ? realReactNavigation.useLinkTo : () => null;
 const useScrollToTop = isJestEnv ? realReactNavigation.useScrollToTop : () => null;
 const useRoute = isJestEnv ? realReactNavigation.useRoute : () => ({params: {}});
-const useFocusEffect = isJestEnv ? realReactNavigation.useFocusEffect : (callback: () => void) => callback();
+// Run callback in useEffect (like real useFocusEffect), not synchronously during render
+const useFocusEffect = isJestEnv
+    ? realReactNavigation.useFocusEffect
+    : (callback: () => (() => void) | void) => {
+          useEffect(() => callback(), [callback]);
+      };
 const usePreventRemove = isJestEnv ? jest.fn() : () => {};
 const useNavigationState = isJestEnv ? realReactNavigation.useNavigationState : () => {};
 

__mocks__/@react-navigation/native/index.ts

@@ -111,8 +111,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009037506
-        versionName "9.3.75-6"
+        versionCode 1009037702
+        versionName "9.3.77-2"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"

android/app/build.gradle

@@ -122,7 +122,6 @@
 "../../src/components/MoneyRequestAmountInput.tsx"	"react-hooks/immutability"	2
 "../../src/components/MoneyRequestConfirmationList.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/components/MoneyRequestConfirmationList.tsx"	"react-hooks/set-state-in-effect"	2
-"../../src/components/MoneyRequestHeaderSecondaryActions.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	3
 "../../src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx"	"react-hooks/refs"	6
 "../../src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx"	"react-hooks/set-state-in-effect"	3
@@ -234,7 +233,6 @@
 "../../src/hooks/useSearchBulkActions.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	5
 "../../src/hooks/useSearchBulkActions.ts"	"react-hooks/exhaustive-deps"	1
 "../../src/hooks/useSearchBulkActions.ts"	"react-hooks/preserve-manual-memoization"	2
-"../../src/hooks/useSearchBulkActions.ts"	"react-hooks/refs"	1
 "../../src/hooks/useSearchHighlightAndScroll.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/hooks/useSearchSelector/index.native.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/hooks/useSelectionModeReportActions.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	2
@@ -300,20 +298,17 @@
 "../../src/libs/PersonalDetailsUtils.ts"	"rulesdir/no-onyx-connect"	2
 "../../src/libs/Pusher/index.native.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/libs/Pusher/index.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
-"../../src/libs/ReceiptUploadRetryHandler/handleFileRetry.ts"	"no-restricted-syntax"	2
+"../../src/libs/ReceiptUploadRetryHandler/handleFileRetry.ts"	"no-restricted-syntax"	1
 "../../src/libs/ReportActionItemEventHandler/index.android.ts"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
-"../../src/libs/ReportActionsUtils.ts"	"@typescript-eslint/no-deprecated/getReportName"	2
-"../../src/libs/ReportActionsUtils.ts"	"@typescript-eslint/no-deprecated/getReportNameCallback"	1
 "../../src/libs/ReportActionsUtils.ts"	"@typescript-eslint/no-deprecated/reportAction.sequenceNumber"	1
 "../../src/libs/ReportActionsUtils.ts"	"@typescript-eslint/no-deprecated/reportAction?.originalMessage"	2
 "../../src/libs/ReportActionsUtils.ts"	"rulesdir/no-onyx-connect"	3
 "../../src/libs/ReportNameUtils.ts"	"@typescript-eslint/no-deprecated/translateLocal"	12
 "../../src/libs/ReportUtils.ts"	"@typescript-eslint/no-deprecated/getPolicy"	29
-"../../src/libs/ReportUtils.ts"	"@typescript-eslint/no-deprecated/getReportName"	10
+"../../src/libs/ReportUtils.ts"	"@typescript-eslint/no-deprecated/getReportName"	3
 "../../src/libs/ReportUtils.ts"	"@typescript-eslint/no-deprecated/getSearchReportName"	1
 "../../src/libs/ReportUtils.ts"	"@typescript-eslint/no-deprecated/translateLocal"	43
 "../../src/libs/ReportUtils.ts"	"rulesdir/no-onyx-connect"	17
-"../../src/libs/SearchUIUtils.ts"	"@typescript-eslint/no-deprecated/getReportName"	1
 "../../src/libs/SearchUIUtils.ts"	"@typescript-eslint/no-deprecated/getSearchReportName"	1
 "../../src/libs/SubscriptionUtils.ts"	"rulesdir/no-onyx-connect"	1
 "../../src/libs/TransactionUtils/index.ts"	"@typescript-eslint/no-deprecated/translateLocal"	5
@@ -504,7 +499,6 @@
 "../../src/pages/inbox/report/ContextMenu/BaseReportActionContextMenu.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/pages/inbox/report/ContextMenu/BaseReportActionContextMenu.tsx"	"react-hooks/preserve-manual-memoization"	1
 "../../src/pages/inbox/report/ContextMenu/BaseReportActionContextMenu.tsx"	"react-hooks/refs"	1
-"../../src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx"	"@typescript-eslint/no-deprecated/getReportNameDeprecated"	1
 "../../src/pages/inbox/report/ContextMenu/PopoverReportActionContextMenu.tsx"	"@typescript-eslint/no-deprecated/ConfirmModal"	1
 "../../src/pages/inbox/report/ContextMenu/PopoverReportActionContextMenu.tsx"	"react-hooks/refs"	29
 "../../src/pages/inbox/report/ListBoundaryLoader.tsx"	"react-hooks/set-state-in-effect"	1
@@ -515,7 +509,6 @@
 "../../src/pages/inbox/report/ReportActionCompose/ComposerWithSuggestions.tsx"	"react-hooks/refs"	7
 "../../src/pages/inbox/report/ReportActionCompose/SuggestionEmoji.tsx"	"react-hooks/refs"	1
 "../../src/pages/inbox/report/ReportActionCompose/SuggestionMention.tsx"	"react-hooks/refs"	3
-"../../src/pages/inbox/report/ReportActionItemMessage.tsx"	"@typescript-eslint/no-deprecated/getReportName"	1
 "../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions"	1
 "../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"no-restricted-syntax"	1
 "../../src/pages/inbox/report/ReportActionItemMessageEdit.tsx"	"react-hooks/preserve-manual-memoization"	1
@@ -736,10 +729,8 @@
 "../../src/utils/keyboard/index.web.ts"	"no-restricted-imports"	1
 "../../src/utils/keyboard/index.website.ts"	"no-restricted-imports"	1
 "../../tests/actions/ReportTest.ts"	"@typescript-eslint/no-deprecated/buildNextStepNew"	1
-"../../tests/perf-test/ReportUtils.perf-test.ts"	"@typescript-eslint/no-deprecated/getReportName"	1
 "../../tests/unit/Navigation/TransitionTrackerTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/NextStepUtilsTest.ts"	"@typescript-eslint/no-deprecated/buildNextStepNew"	23
-"../../tests/unit/ReportUtilsTest.ts"	"@typescript-eslint/no-deprecated/getReportNameDeprecated"	6
 "../../tests/unit/canEditFieldOfMoneyRequestTest.ts"	"@typescript-eslint/no-deprecated/randomReportAction.originalMessage"	3
 "../../tests/unit/submitDismissStrategiesTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/useSubStepTest.tsx"	"@typescript-eslint/no-deprecated/useSubStep"	13

config/eslint/eslint.seatbelt.tsv

@@ -78,6 +78,7 @@
         "autosync",
         "avds",
         "AVURL",
+        "bamboohr",
         "Bartek",
         "basehead",
         "baselined",
@@ -323,11 +324,13 @@
         "Heathrow",
         "helpdot",
         "helpsite",
+        "hibob",
         "Highfive",
         "Highlightable",
         "HKBCCATT",
         "Hoverable",
         "hrefs",
+        "hris",
         "HRMS",
         "HSBCSGS",
         "Humpty",
@@ -910,6 +913,7 @@
         "Monzo",
         "Novobanco",
         "Pekao",
+        "Playroll",
         "Pleo",
         "Polska",
         "Postale",

cspell.json

@@ -0,0 +1,89 @@
+---
+title: Playroll
+description: Learn how to connect Expensify with Playroll to automatically sync approved expenses for HR and EOR processing.
+keywords: [Expensify Classic, Playroll, HR, EOR, expense sync, integration, payroll]
+internalScope: Audience is Workspace Admins and Workspace Owners. Covers connecting to Playroll for one-way expense syncing. Does not cover Playroll configuration beyond the Expensify integration.
+---
+
+# Playroll 
+
+The Expensify-Playroll integration allows approved expenses in Expensify to automatically sync into Playroll for processing. This is a one-way integration (Expensify to Playroll only) — changes made after syncing will not sync back.
+
+**Important:** Only approved expenses will sync, and expenses without receipts will not sync to Playroll.
+
+---
+
+## Who can connect Expensify to Playroll
+
+You can connect Expensify to Playroll if:
+
+- You are a Workspace Admin or Workspace Owner
+- You have permission to configure integrations in Playroll
+- You are signed into the Expensify account that owns or administers the workspace
+
+This feature is not available on mobile.
+
+---
+
+## How to connect Expensify to Playroll
+
+Before connecting Playroll, configure the required workspace settings in Expensify.
+
+1. In the navigation tabs on the left, go to **Settings > Workspaces**.
+2. Select your workspace.
+3. Go to **Rules**.
+4. Enable **Public Receipt Visibility**.
+5. Set **Receipt Required Amount** to **$0**.
+6. Save your changes.
+
+Then connect the integration in Playroll.
+
+1. In Playroll, go to **Dashboard > Tools > Integrations**.
+2. Select **Expensify**.
+3. Open the **Configuration** tab.
+4. Click **Connect**.
+5. In Expensify, click **Find our Partner ID**.
+6. Copy the **Partner User ID** and **Partner User Secret**.
+7. Paste the credentials into Playroll.
+8. Click **Submit**.
+
+After the integration connects successfully, Playroll displays the status as **Active / Connected**.
+
+Employee email addresses in Expensify must match the Personal Email addresses in Playroll.
+
+---
+
+## What happens after you connect Expensify to Playroll
+
+After the integration is connected:
+
+- Approved expenses automatically sync from Expensify to Playroll
+- Expenses without attached receipts do not sync
+- Changes made after syncing do not sync back into Expensify
+- Expense category mappings in Playroll determine how synced expenses appear in Playroll
+
+---
+
+# FAQ
+
+## Why are expenses not syncing to Playroll?
+
+Expenses may not sync if:
+
+- The expense is not approved
+- The expense does not include a receipt
+- **Public Receipt Visibility** is disabled
+- Employee email addresses do not match between Expensify and Playroll
+- Expense categories are not mapped in Playroll
+
+## Can members connect Expensify to Playroll?
+
+No. Only Workspace Admins and Workspace Owners can configure the integration.
+
+## Does the Playroll integration sync changes back into Expensify?
+
+No. The integration only syncs expenses from Expensify to Playroll.
+
+## Can I connect Expensify to Playroll on mobile?
+
+No. This feature is not available on mobile.