Merge pull request Expensify#63650 from callstack-internal/use-staging-server-persistence

fix: Persist troubleshooting flags across login sessions

Author: cristipaval

src/libs/actions/SignInRedirect.ts

@@ -32,8 +32,17 @@ function clearStorageAndRedirect(errorMessage?: string): Promise<void> {
         keysToPreserve.push(ONYXKEYS.NETWORK);
     }
 
+    // Preserve troubleshooting flags
+    keysToPreserve.push(ONYXKEYS.APP_PROFILING_IN_PROGRESS);
+    keysToPreserve.push(ONYXKEYS.SHOULD_STORE_LOGS);
+    keysToPreserve.push(ONYXKEYS.SHOULD_MASK_ONYX_STATE);
+
+    // Preserve account settings (staging server, debug mode, etc.) across logout
+    keysToPreserve.push(ONYXKEYS.ACCOUNT);
+
     return Onyx.clear(keysToPreserve).then(() => {
         clearAllPolicies();
+
         if (!errorMessage) {
             return;
         }

src/pages/signin/SignInPage.tsx

@@ -106,7 +106,8 @@ function getRenderOptions({
     // SAML required users may reload the login page after having already entered their login details, in which
     // case we want to clear their sign in data so they don't end up in an infinite loop redirecting back to their
     // SSO provider's login page
-    if (hasLogin && isSAMLRequired && !shouldInitiateSAMLLogin && !hasInitiatedSAMLLogin && !account.isLoading) {
+    // Don't clear if we don't have account data - this prevents clearing during app resets when state is inconsistent
+    if (hasAccount && hasLogin && isSAMLRequired && !shouldInitiateSAMLLogin && !hasInitiatedSAMLLogin && !account.isLoading) {
         clearSignInData();
     }