fix: gate getModerationFlagState to ADD_COMMENT actions

Author: LukasMod

src/libs/ReportActionsUtils.ts

@@ -265,6 +265,10 @@ function isPendingRemove(reportAction: OnyxInputOrEntry<ReportAction>): boolean
  * Used by leaves that previously received the equivalent values as props from PureReportActionItem.
  */
 function getModerationFlagState(reportAction: OnyxInputOrEntry<ReportAction>): {latestDecision: DecisionName | undefined; hasBeenFlagged: boolean} {
+    // Moderation only applies to ADD_COMMENT actions
+    if (reportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT) {
+        return {latestDecision: undefined, hasBeenFlagged: false};
+    }
     const latestDecision = getReportActionMessage(reportAction)?.moderationDecision?.decision;
     const hasBeenFlagged =
         !!latestDecision &&

src/pages/inbox/report/ReportActionItemSingle.tsx

@@ -72,8 +72,7 @@ function ReportActionItemSingle({
     isHovered = false,
     isActive = false,
 }: ReportActionItemSingleProps) {
-    const {latestDecision, hasBeenFlagged} =
-        action?.actionName === CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT ? getModerationFlagState(action) : {latestDecision: undefined, hasBeenFlagged: false};
+    const {latestDecision, hasBeenFlagged} = getModerationFlagState(action);
     const theme = useTheme();
     const styles = useThemeStyles();
     const StyleUtils = useStyleUtils();

tests/unit/ReportActionsUtilsTest.ts

@@ -5173,5 +5173,13 @@ describe('ReportActionsUtils', () => {
                 hasBeenFlagged: true,
             });
         });
+
+        it('returns the safe default for non-ADD_COMMENT actions even when the message carries a flagged decision', () => {
+            const action = {
+                ...makeActionWithDecision(CONST.MODERATION.MODERATOR_DECISION_HIDDEN),
+                actionName: CONST.REPORT.ACTIONS.TYPE.IOU,
+            } as ReportAction;
+            expect(getModerationFlagState(action)).toEqual({latestDecision: undefined, hasBeenFlagged: false});
+        });
     });
 });