Pass all report actions to shouldReportActionBeVisible

Author: deetergp

src/libs/ReportActionsUtils.ts

@@ -1096,11 +1096,13 @@ function isResolvedActionableWhisper(reportAction: OnyxEntry<ReportAction>, allA
     // For mention whispers, only treat as deleted if the parent comment is also deleted.
     // This distinguishes cascade deletion (parent deleted -> whisper should hide) from
     // the backend's one-per-user cleanup (parent still exists -> whisper should stay visible).
-    if (allActionsForReport && reportAction?.reportActionID) {
-        if (isActionableMentionWhisper(reportAction) || isActionableReportMentionWhisper(reportAction)) {
+    if (reportAction?.reportActionID && (isActionableMentionWhisper(reportAction) || isActionableReportMentionWhisper(reportAction))) {
+        const reportID = reportAction.reportID;
+        const actions = allActionsForReport ?? (reportID ? allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`] : undefined);
+        if (actions) {
             const parentOffset = isActionableReportMentionWhisper(reportAction) ? 2n : 1n;
             const parentActionID = String(BigInt(reportAction.reportActionID) - parentOffset);
-            const parentAction = allActionsForReport[parentActionID];
+            const parentAction = actions[parentActionID];
             if (parentAction && !isDeletedAction(parentAction)) {
                 return false;
             }
@@ -1251,22 +1253,27 @@ function isReportActionVisible(
         return false;
     }
 
+    // Look up all actions for this report so the parent-check in isResolvedActionableWhisper
+    // can determine whether a whisper's `deleted` flag reflects a real cascade deletion
+    // (parent comment deleted) vs. the backend's one-per-user cleanup (parent still exists).
+    const reportActionsForReport = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`];
+
     // Actions with pendingAction are optimistic or in-flight, so their visibility may differ
     // from what's cached in visibleReportActions (which reflects persisted Onyx data).
     // We must recalculate visibility at runtime to ensure accuracy for these transient states.
     if (reportAction.pendingAction) {
-        return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction);
+        return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction, undefined, reportActionsForReport);
     }
 
     if (visibleReportActions) {
         const reportCache = visibleReportActions[reportID];
         if (!reportCache) {
-            return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction);
+            return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction, undefined, reportActionsForReport);
         }
         const staticVisibility = reportCache[reportAction.reportActionID];
         // If action is not in derived value cache, fall back to runtime calculation
         if (staticVisibility === undefined) {
-            return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction);
+            return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction, undefined, reportActionsForReport);
         }
         if (!staticVisibility) {
             return false;
@@ -1276,7 +1283,7 @@ function isReportActionVisible(
         }
         return true;
     }
-    return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction);
+    return shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction, undefined, reportActionsForReport);
 }
 
 /**