fix: address Copilot review comments on JSDoc and hook return shape

Author: BartekObudzinski

src/components/LHNOptionsList/OptionRowLHN/OptionRow/Subtitle.tsx

@@ -15,7 +15,7 @@ type SubtitleProps = {
     /** Option data for the row. Source of `alternateText` and emoji rendering hints. */
     optionItem: OptionData;
 
-    /** Display density mode. Compact rows hide the subtitle entirely. */
+    /** Display density mode. Compact rows render the subtitle with compact styles; the subtitle is hidden only when `optionItem.alternateText` is empty. */
     viewMode: OptionMode;
 
     /** Whether the row is the currently focused/active option. Drives the active text style. */

src/components/LHNOptionsList/OptionRowLHN/OptionRow/Title.tsx

@@ -14,7 +14,7 @@ type TitleProps = {
     /** Whether the row is the currently focused/active option. Drives the active text style. */
     isOptionFocused: boolean;
 
-    /** Numeric testID for the title node (mirrors `reportID`). */
+    /** Numeric testID for the title node. This is the FlashList row index passed in from the renderItem callback, not the report ID. */
     testID: number;
 };
 

src/components/LHNOptionsList/OptionRowLHN/OptionRowLHNData.tsx

@@ -25,8 +25,8 @@ import OptionRowLHN from './OptionRowLHN';
 /*
  * This component gets the data from onyx for the actual
  * OptionRowLHN component.
- * The OptionRowLHN component is memoized, so it will only
- * re-render if the data really changed.
+ * OptionRowLHN is auto-memoized by React Compiler, so it will
+ * only re-render when the inputs derived from this wrapper change.
  */
 function OptionRowLHNData({
     isOptionFocused = false,

src/components/LHNOptionsList/OptionRowLHN/useOptionRowChrome.ts

@@ -51,7 +51,6 @@ function useOptionRowChrome({isOptionFocused, viewMode}: UseOptionRowChromeParam
     }
 
     return {
-        hovered,
         setHovered,
         sidebarInnerRowStyle,
         contentContainerStyles,

tests/unit/hooks/useOptionRowChrome.test.ts

@@ -42,24 +42,6 @@ jest.mock('@hooks/useStyleUtils', () => ({
 }));
 
 describe('useOptionRowChrome', () => {
-    describe('hover state', () => {
-        it('initialises hovered to false', () => {
-            const {result} = renderHook(() => useOptionRowChrome({isOptionFocused: false, viewMode: CONST.OPTION_MODE.DEFAULT}));
-
-            expect(result.current.hovered).toBe(false);
-        });
-
-        it('setHovered(true) toggles hovered to true', () => {
-            const {result} = renderHook(() => useOptionRowChrome({isOptionFocused: false, viewMode: CONST.OPTION_MODE.DEFAULT}));
-
-            act(() => {
-                result.current.setHovered(true);
-            });
-
-            expect(result.current.hovered).toBe(true);
-        });
-    });
-
     describe('avatarBackgroundColor precedence', () => {
         it('returns the default sidebar color when neither focused nor hovered', () => {
             const {result} = renderHook(() => useOptionRowChrome({isOptionFocused: false, viewMode: CONST.OPTION_MODE.DEFAULT}));