update logic

Author: luacmartins

src/libs/ReportPreviewActionUtils.ts

@@ -102,9 +102,7 @@ function canApprove(report: Report, violations: OnyxCollection<TransactionViolat
         return false;
     }
 
-    const hasOnlyPendingTransactions = !!transactions && transactions?.length > 0 && transactions.every((transaction) => isPending(transaction));
-
-    if (hasOnlyPendingTransactions) {
+    if (!!transactions && transactions?.length > 0 && !transactions.some((transaction) => !isPending(transaction))) {
         return false;
     }
 

src/libs/ReportPrimaryActionUtils.ts

@@ -122,9 +122,7 @@ function isApproveAction(report: Report, reportTransactions: Transaction[], poli
         return false;
     }
 
-    const hasOnlyPendingTransactions = reportTransactions.length > 0 && reportTransactions.every((transaction) => isPending(transaction));
-
-    if (hasOnlyPendingTransactions) {
+    if (reportTransactions.length > 0 && !reportTransactions.some((transaction) => !isPending(transaction))) {
         return false;
     }
 

src/libs/ReportSecondaryActionUtils.ts

@@ -152,11 +152,6 @@ function isSubmitAction(
         return true;
     }
 
-    const hasOnlyPendingTransactions = reportTransactions.length > 0 && reportTransactions.every((transaction) => isPending(transaction));
-    if (hasOnlyPendingTransactions) {
-        return false;
-    }
-
     const autoReportingFrequency = getCorrectedAutoReportingFrequency(policy);
 
     const isScheduledSubmitEnabled = policy?.harvesting?.enabled && autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL;
@@ -193,6 +188,10 @@ function isApproveAction(report: Report, reportTransactions: Transaction[], viol
         return true;
     }
 
+    if (reportTransactions.length > 0 && !reportTransactions.some((transaction) => !isPending(transaction))) {
+        return false;
+    }
+
     const transactionIDs = reportTransactions.map((t) => t.transactionID);
 
     const hasAllPendingRTERViolations = allHavePendingRTERViolation(transactionIDs, violations);