Perf/lhn options cache by Bar-Maz · Pull Request #36 · callstack-internal/Expensify-App

Bar-Maz · 2026-02-06T21:40:03Z

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ith Onyx.clear and waitForBatchedUpdates

coderabbitai · 2026-02-06T21:40:13Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch perf/lhn-options-cache

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

JKobrynski · 2026-02-11T10:24:44Z

+        const reportActionsForDisplay = sortedReportActions.filter(
+            (reportAction) =>
+                (!(isWhisperAction(reportAction) && !isReportPreviewAction(reportAction) && !isMoneyRequestAction(reportAction)) || isActionableMentionWhisper(reportAction)) &&
+                shouldReportActionBeVisible(reportAction, reportAction.reportActionID, isWriteActionAllowed) &&
+                reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
+                reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
+        );


I think we could make this part more readable, or maybe explain it somehow. I'm afraid it might be difficult to maintain. Wdyt?

JKobrynski · 2026-02-11T10:28:11Z

+        lastVisibleReportActions[reportID] = reportActionForDisplay;
+
+        const lastActorAccountID = report?.lastActorAccountID;
+        let lastActorDetails: Partial<PersonalDetails> | null = lastActorAccountID && allPersonalDetails?.[lastActorAccountID] ? allPersonalDetails[lastActorAccountID] : null;


Suggested change

let lastActorDetails: Partial<PersonalDetails> | null = lastActorAccountID && allPersonalDetails?.[lastActorAccountID] ? allPersonalDetails[lastActorAccountID] : null;

let lastActorDetails = allPersonalDetails?.[lastActorAccountID] ?? null;

Would that work?

LukasMod · 2026-02-12T10:37:27Z

+        if (!lastActorDetails && reportActionForDisplay) {
+            const lastActorDisplayName = reportActionForDisplay.person?.[0]?.text;
+            lastActorDetails = lastActorDisplayName
+                ? {
+                      displayName: lastActorDisplayName,
+                      accountID: lastActorAccountID,
+                  }
+                : null;
+        }
+    }


Is it a dead code? Is lastActorDetails used somewhere?

LukasMod · 2026-02-12T10:44:38Z

+    getCachedReportActionsForDisplay,
+    getCachedLastMessageText,


I don't see usage of these 2. Is it for follow up PRs or something?

LukasMod · 2026-02-12T10:48:47Z

+function getCachedLastMessageText(reportID: string, computeFn?: () => string): string | undefined {
+    let cached = lastMessageTextCache[reportID];
+    if (!cached && computeFn) {
+        cached = computeFn();
+        lastMessageTextCache[reportID] = cached;
+    }
+    return cached;
+}


How about empty string? Not sure if its a real issue but it would cause cache miss. Would be nice to have a unit tests for that

LukasMod · 2026-02-12T10:54:46Z

+ *
+ * @param reportID - The ID of the report to invalidate cache for
+ */
+function invalidateCacheForReport(reportID: string) {


This one also relies on allPersonalDetails, allReports, and allReportNameValuePairsOnyxConnect. Is it intentional that the cache is invalidated only for REPORT_METADATA and REPORT_ACTIONS? Will this not introduce stale data if eg only allPersonalDetails changes?

Bar-Maz added 5 commits February 3, 2026 15:56

Add cached actions and last-message text in OptionsListUtils

173d127

Fix OptionsListUtilsTest: isolate getLastMessageTextForReport tests w…

17ee5be

…ith Onyx.clear and waitForBatchedUpdates

Merge branch 'perf/lhn-baselines' into perf/lhn-options-cache

c89e04a

Merge branch 'perf/lhn-baselines' into perf/lhn-options-cache

e267744

Merge branch 'perf/lhn-sort-cache' into perf/lhn-options-cache

bac0e47

Bar-Maz added 6 commits February 9, 2026 10:54

Remove deprecated Onyx.connect calls

832b3b6

Merge branch 'perf/lhn-sort-cache' into perf/lhn-options-cache

89eb0f4

Merge branch 'perf/lhn-sort-cache' into perf/lhn-options-cache

00b0a59

Delete unnecessary SidebarLinks tests

4149f87

Delete unused sidebarReports test utils

a8d5ff5

Merge branch 'perf/lhn-baselines' into perf/lhn-options-cache

71cfc0c

JKobrynski reviewed Feb 11, 2026

View reviewed changes

LukasMod reviewed Feb 12, 2026

View reviewed changes

Bar-Maz closed this Feb 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perf/lhn options cache#36

Perf/lhn options cache#36
Bar-Maz wants to merge 11 commits into
perf/lhn-sort-cachefrom
perf/lhn-options-cache

Bar-Maz commented Feb 6, 2026

Uh oh!

coderabbitai Bot commented Feb 6, 2026 •

edited

Loading

Review skipped

Uh oh!

JKobrynski Feb 11, 2026

Uh oh!

JKobrynski Feb 11, 2026

Uh oh!

LukasMod Feb 12, 2026

Uh oh!

LukasMod Feb 12, 2026

Uh oh!

LukasMod Feb 12, 2026

Uh oh!

LukasMod Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	let lastActorDetails: Partial<PersonalDetails> \| null = lastActorAccountID && allPersonalDetails?.[lastActorAccountID] ? allPersonalDetails[lastActorAccountID] : null;
	let lastActorDetails = allPersonalDetails?.[lastActorAccountID] ?? null;

Conversation

Bar-Maz commented Feb 6, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

coderabbitai Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

JKobrynski Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

JKobrynski Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Feb 6, 2026 •

edited

Loading