Skip to content

fix: bulk operation, test 38 infinite loading while offline #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasMod merged 1 commit into from
Mar 20, 2026
Merged

fix: bulk operation, test 38 infinite loading while offline #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/libs/actions/IOU/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13213,11 +13213,13 @@ function updateMultipleMoneyRequests({transactionIDs, changes, policy, reports,
// Offline-created expenses can be missing a transaction thread until it's opened once.
// Ensure the thread exists before adding optimistic MODIFIED_EXPENSE actions so
// bulk-edit comments are visible immediately while still offline.
let didCreateThreadInThisIteration = false;
if (!transactionThreadReportID && iouReport?.reportID) {
const optimisticTransactionThread = createTransactionThreadReport(undefined, currentUserEmail, userAccountID, iouReport, reportAction, transaction);
if (optimisticTransactionThread?.reportID) {
transactionThreadReportID = optimisticTransactionThread.reportID;
transactionThread = optimisticTransactionThread;
didCreateThreadInThisIteration = true;
}
}

Expand Down Expand Up @@ -13483,10 +13485,23 @@ function updateMultipleMoneyRequests({transactionIDs, changes, policy, reports,

// Optimistic report action
if (transactionThreadReportID) {
// Backfill a CREATED action for threads never opened locally so
// MoneyRequestView renders and the skeleton doesn't loop offline.
// Skip when the thread was just created above (openReport handles it).
const threadReportActions = reportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${transactionThreadReportID}`] ?? {};
const hasCreatedAction = didCreateThreadInThisIteration || Object.values(threadReportActions).some((action) => action?.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED);
const optimisticCreatedValue: Record<string, Partial<OnyxTypes.ReportAction>> = {};
if (!hasCreatedAction) {
const optimisticCreatedAction = buildOptimisticCreatedReportAction(CONST.REPORT.OWNER_EMAIL_FAKE);
optimisticCreatedAction.pendingAction = null;
optimisticCreatedValue[optimisticCreatedAction.reportActionID] = optimisticCreatedAction;
}

optimisticData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${transactionThreadReportID}`,
value: {
...optimisticCreatedValue,
[modifiedExpenseReportActionID]: {
...optimisticReportAction,
reportActionID: modifiedExpenseReportActionID,
Expand Down
Loading