Restore reviewer checklist items to match reviewer tooling#53
Closed
kacper-mikolajczak wants to merge 750 commits into
Closed
Restore reviewer checklist items to match reviewer tooling#53kacper-mikolajczak wants to merge 750 commits into
kacper-mikolajczak wants to merge 750 commits into
Conversation
[NoQA] Fix false broken connection banner on Company Cards page for non-direct card feeds
…nse-chat-report-actions
…bump-lottie Upgrade `lottie-react-native` to the latest version
…live-markdown-0.1.327 chore: upgrade react-native-live-markdown to 0.1.327
…emove-explanation-modal [No QA] Remove explanation modal
fix: New workflow is not added via Import Spreadsheet in a control WS
- Drop "exactly once" overstatement: writes are sent serially and deduplicated server-side on the rare resend, not via a client-side lock. - Distinguish push()'s offline-at-entry path (returns without arming the READ gate) from going offline during the awaited persist. - Reframe restart head-dedupe as a defensive backstop, consistent with the atomic multiSet promotion. - Restate remaining time-based phrasing as current-state facts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nedPaidPoliciesCountsSelector
…h-selection-writeside Search selection: move write-side off <Search> onto provider/controller
…2b-invoice-report
Fix: “Reimbursable” column width is wider than necessary on report page
…rkspaces-list-page-composition-1 extract DeleteWorkspaceFlow component from WorkspacesListPage
[Submit] Add editor role to the filter for submit workspace
…ss-copy [NoQA] Update specialized role access copy
…r-multi-select feat: Make the Workspace and Domain member filter list multi-select, and update All members to Members
…cemaps [No QA] Patch time-analytics-webpack-plugin to fix sourcemaps
…nnect-patterns Stop repeated ReconnectApp calls when the device clock is behind the server
fix: Creating report from self dm opens hmm not here page briefly
Update the domain admins table to the new style
…ingCustomizeCategories Route Getting Started accounting row to categories for non-direct integrations
…/fix-global-create-scan [Performance] Fix global create scan misidentifying Search context via fallback chain
…xpenseChatEnabled-A1 [Payment due @Ollyws] Remove `isPolicyExpenseChatEnabled` from `PolicyUtils.ts` helpers
…policy-expense-chat-report-actions Defer policy expense chat report actions computation off the render path
…in-rules [Payment due @marufsharifi] Add currency selection to card rules
Revert Expensify#92007 Concierge AI Feature Promo Modal
The PR Reviewer Checklist action counts the unchecked items in contributingGuides/REVIEWER_CHECKLIST.md and requires the checklist pasted by reviewers to have a matching number of checked items, within a tolerance of +/- 2. Reviewers paste the checklist via tooling that carries its own copy of the list, so trimming this file without updating that tooling left the counts out of sync by more than the tolerance and failed the check on nearly every PR. Restore the seven items that were removed so the source count matches the list reviewers actually paste, turning the check green again. The items can be removed once the reviewer-facing tooling is updated in lockstep.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+22
to
+38
| name: Bun tests | ||
| runs-on: blacksmith-8vcpu-ubuntu-2404 | ||
| steps: | ||
| - name: Checkout | ||
| uses: useblacksmith/checkout@c9796daa2a4bdebdab5bd16be2c09a70cd4e1121 # v1 | ||
|
|
||
| - name: Setup Node | ||
| uses: ./.github/actions/composite/setupNode | ||
|
|
||
| - name: Run Bun tests | ||
| run: npm run test:bun | ||
|
|
||
| - name: Build victory-chart-renderer Linux x64 binary | ||
| run: npm run server:vcr:build:linux | ||
|
|
||
| - name: Smoke-test compiled victory-chart-renderer binary | ||
| run: ./server/victory-chart-renderer/dist/victory-chart-renderer-linux-x64 --chart-xml "$(cat server/victory-chart-renderer/tests/fixtures/top-categories-6.xml)" --out /tmp/vcr-smoke.png && test -s /tmp/vcr-smoke.png |
Author
|
Recreating against upstream Expensify/App. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PR Reviewer Checklist action counts the unchecked items in
contributingGuides/REVIEWER_CHECKLIST.mdand requires the checklist pasted by reviewers to contain a matching number of checked items, within a tolerance of +/- 2. Reviewers paste the checklist via tooling that carries its own copy of the list. When this file was trimmed without updating that tooling, the source count and the pasted count drifted apart by more than the tolerance, so the check failed on nearly every PR (for example: "You completed 59 out of 50 checklist items").Fix
Restore the seven items that were removed from the reviewer checklist so the source count matches the list reviewers actually paste, turning the check green again. The lines are restored verbatim in their original positions.
The items can be removed again once the reviewer-facing tooling is updated in lockstep with this file.
Tests
contributingGuides/REVIEWER_CHECKLIST.mdunchecked-item count returns to 57, within +/- 2 of the pasted checklist.